Monday, March 15, 2021
3 changes · master
Resolved issues and error corrections
The sales order portal now correctly shows the View Timesheets button when timesheets are linked to a sale, even if the sale was not automatically connected to an analytic account. This helps customers and staff access relevant timesheet information without missing records due to the original service setup.
Original PR description
Before this commit, when the user creates a SO with a service product which does not generate a task or a project, the analytic account is not set on the new SO. Then even if the user creates a task…
Before this commit, when the user creates a SO with a service product which does not generate a task or a project, the analytic account is not set on the new SO. Then even if the user creates a task and add timesheets for this product in this SO, the compute_timesheet_ids gives 0 timesheets in the sale.order model because the SO is not linked to an analytic account. This commit removes this condition and directly searches the timesheets linked to the SO and thus provides the correct number of timesheets for it. This bug is appeared from this commit: dc9ef81 Steps to reproduce: 1. Create a SO and add a SOL with 'Service on Timesheet' 2. Confirm the SO 3. Create a task in project for the same customer than the SO or a project with no customer set. 4. Add the customer of the SO in the task if it is not already the case. 5. Add the SOL in the task and add a timesheet. 6. Go to /my/orders 7. Select the SO that you have created and in this view, normally, you should have the View Timesheets buttons on the left side. Current behaviour: The 'View Timesheets' button does not appear in the view because the compute_timesheet_ids from the SO return no timesheets for it. Expected behaviour: The button should be visible in the view because we have a timesheet for this SO. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix removes survey report styling rules that were accidentally applied across all Odoo reports. It helps prevent unrelated reports from having broken layouts and reduces the risk of future style conflicts.
Original PR description
This commit removes 2 css rules that were applied on ALL odoo reports by mistake. Indeed, adding rules on "*" and "body" will most likely break other reporting layouts and is very dangerous / unintended. If these rules are needed for the survey reports, then it should be fixed to make them only applied to those reports instead. We also took this opportunity to get rid of some scss variables. These variables names were too "global" and could also conflict with other reporting css rulesets. If we want to use variables for that report, they should be correctly pre-fixed to avoid collisions. Source: 212b107fa155778e2b2063b66bb88517aba80498 Task-2341847 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Selecting icons in the website editor's media dialog now behaves correctly and displays the selected state properly. Icons are also centered, making the media picker clearer and easier to use.
Original PR description
The code added in bb65b742e7eec000248b7df0f048dda61ac3ff5a to update style for multi image selection is not compatible with .fa icons and causes a strange behaviour when trying to select one. The goal of this PR is to fix style for selected icons on Media Dialog. task-2326573