Wednesday, March 17, 2021
7 changes · master
Miscellaneous changes
This corrects rejection for import invoices. Previous to this PR, if you create an export invoice in different currency than CLP, will have two rejections or objections from the sii: (TED-3-640) Monto Total No Corresponde al Timbre: (amount in MNT is in CLP and should be in the same currency as the MntTotal) (HED-2-804) Exportacion : Campo obligatorio : Codigo de Modalidad de Venta (for export invoices there is a need to specify the sale type. As in most cases is used "a firme (01)"
Original PR description
This corrects rejection for import invoices. Previous to this PR, if you create an export invoice in different currency than CLP, will have two rejections or objections from the sii: (TED-3-640) Monto Total No Corresponde al Timbre: (amount in MNT is in CLP and should be in the same currency as the MntTotal) (HED-2-804) Exportacion : Campo obligatorio : Codigo de Modalidad de Venta (for export invoices there is a need to specify the sale type. As in most cases is used "a firme (01)" and as we cannot add additional fields to this version, we have put this value as fixed in the template) After the application of this fix, you will have the invoice accepted correctly by the SII. Forward-Port-Of: odoo/enterprise#16103
When linking an online account with an existing journal, the currency in the wizard was not adapted to the currency of the journal. Which, if the user is not looking, will try to change the currency of his existing journal. We change that behavior so that now when selecting a journal, it will change the currency to match the one from the journal Another problem is when we do not change the currency of the journal but that journal contains entries in multiple currencies. It will results
Original PR description
When linking an online account with an existing journal, the currency in the wizard was not adapted to the currency of the journal. Which, if the user is not looking, will try to change the currency of his existing journal. We change that behavior so that now when selecting a journal, it will change the currency to match the one from the journal Another problem is when we do not change the currency of the journal but that journal contains entries in multiple currencies. It will results in an error because there is a simple check that check the value of the currency passed in the write method and does not verify that the value has changed from before. To prevent that, we do not write the value of the currency_id on the journal if it has not changed. Forward-Port-Of: odoo/enterprise#17135
Steps to reproduce the bug: - Let's consider an employee E with no contract - Go to Payroll > Work Entries > Regenrate work entries - Choose E as employee Bug: A traceback was raised opw:2418854 Forward-Port-Of: odoo/enterprise#17122
Original PR description
Steps to reproduce the bug: - Let's consider an employee E with no contract - Go to Payroll > Work Entries > Regenrate work entries - Choose E as employee Bug: A traceback was raised opw:2418854 Forward-Port-Of: odoo/enterprise#17122
Since commit https://github.com/odoo/odoo/commit/933b21e2c5f88869ea358046d6ad80b52be8b55f, the field tag_ids was renamed to tax_tag_ids. opw-2476940 Forward-Port-Of: odoo/enterprise#17118
Original PR description
Since commit https://github.com/odoo/odoo/commit/933b21e2c5f88869ea358046d6ad80b52be8b55f, the field tag_ids was renamed to tax_tag_ids. opw-2476940 Forward-Port-Of: odoo/enterprise#17118
Before this commit, the date send on the cfdi xml was the date and time of the invoice post, and not the date of the invoice date. This will allow creating old invoices and sign it, and normally you cannot sign invoices older than 72 hours. Now, the invoice date is sent on the cfdi xml. Note that, this was already the behaviour on 13. Also, as the invoice date don't have time, we use the time of the invoice post. opw-2475948 Forward-Port-Of: odoo/enterprise#17064
Original PR description
Before this commit, the date send on the cfdi xml was the date and time of the invoice post, and not the date of the invoice date. This will allow creating old invoices and sign it, and normally you cannot sign invoices older than 72 hours. Now, the invoice date is sent on the cfdi xml. Note that, this was already the behaviour on 13. Also, as the invoice date don't have time, we use the time of the invoice post. opw-2475948 Forward-Port-Of: odoo/enterprise#17064
When approving a message in the moderation queue, the notification crashes in `mail_mobile` due to `msg_value` being `False` ``` msg_type = msg_vals.get('message_type') or msg_sudo.message_type AttributeError: 'bool' object has no attribute 'get' ``` This is because the method `_moderate_accept` from mail module calls `_notify_thread` without any value in `msg_value` `_notify_record_by_ocn` from `mail_mobile` assumes `msg_value` is a dict while `False` is a possible value Introduc
Original PR description
When approving a message in the moderation queue, the notification crashes in `mail_mobile` due to `msg_value` being `False`
```
msg_type = msg_vals.get('message_type') or msg_sudo.message_type
AttributeError: 'bool' object has no attribute 'get'
```
This is because the method `_moderate_accept` from mail module calls `_notify_thread` without any value in `msg_value`
`_notify_record_by_ocn` from `mail_mobile` assumes `msg_value` is a dict while `False` is a possible value
Introduced at 201ad00df4bb868d7ea8e2ea238
Forward-Port-Of: odoo/enterprise#17032saas-14.2 introduced a set of helpers to handle ids of account.report lines in a generic way. However, not all reports use them. Tax report, for example, still uses manual ids. Before this fix, such report crashed when trying to assign an action to a line, because their id was directly the model id (an int), not a generic id (a formatted string). An example of such use case can be found in l10n_be_reports, with the action added for lines 61 and 62 of the tax report (for tax adjustements) Forwar
Original PR description
saas-14.2 introduced a set of helpers to handle ids of account.report lines in a generic way. However, not all reports use them. Tax report, for example, still uses manual ids. Before this fix, such report crashed when trying to assign an action to a line, because their id was directly the model id (an int), not a generic id (a formatted string). An example of such use case can be found in l10n_be_reports, with the action added for lines 61 and 62 of the tax report (for tax adjustements) Forward-Port-Of: odoo/enterprise#17101