Monday, March 22, 2021
22 changes · master
Enhancements to existing features
The Website app now uses a more polished default logo instead of the previous text-like placeholder. This gives newly created websites a more professional appearance out of the box while keeping the change limited to branding visuals.
Original PR description
Previous default website logo of the 'website' module ('YourLogo'
image) looked like a text and not like a proper logo, so it has been
replaced by a more stylised, gray-coloured, version, as a svg.
--
task-2448746
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe DHL delivery integration test account credentials have been refreshed for DHL USA and DHL USA International. This helps keep testing and validation of DHL shipping workflows working reliably without changing day-to-day business features.
Original PR description
Credatials are updated for - DHL-USA DHL-USA International Task-id#2391361
Resolved issues and error corrections
This update removes an obsolete documentation link from the stock settings area. Users will no longer be directed to an unavailable quality documentation page, reducing confusion when configuring inventory-related options.
Original PR description
Remove obsolete quality documentation link (added after v14, hence 2 separate PRs). Related PR: odoo/odoo#68135 Task: 2457087 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Steps to reproduce the bug: 1/ Install these apps: Sales, Planning, Employees, Project, Timesheets 2/ Add some employees (stay below 20 employees) 3/ Create a project with Planning, Timesheets and Billable 4/ Click on the overview Bug: List of all employees opw:2460616 Forward-Port-Of: odoo/odoo#67726
Original PR description
Steps to reproduce the bug: 1/ Install these apps: Sales, Planning, Employees, Project, Timesheets 2/ Add some employees (stay below 20 employees) 3/ Create a project with Planning, Timesheets and Billable 4/ Click on the overview Bug: List of all employees opw:2460616 Forward-Port-Of: odoo/odoo#67726
This fix updates the Peruvian electronic invoicing module to use the correct document type reference after it was moved. It helps prevent errors when creating or processing debit notes for Peruvian localization.
Original PR description
'document_type08' has been moved to 'l10n_pe' at revisions: https://github.com/odoo/odoo/commit/c92332f555d96e590d952312bdef561f9b15f1b2 https://github.com/odoo/enterprise/commit/f4ff0b3fb731c49ee9e0459fa8ca58e2a7a91d39
Steps: - Install Projects - Go to Settings / Translations / Languages - Install Dutch - Go to Settings / Users & Companies / Users - Edit demo: - Language: Dutch - Go to Projects - Click the three dots on the first project in the dashboard - Click Share - Select demo as recipient - Send - Go to Settings / Technical / Email / Emails - Click the email you just sent Bug: The email is not translated in the partner's language Explanation: The context of the template didn't take
Original PR description
Steps: - Install Projects - Go to Settings / Translations / Languages - Install Dutch - Go to Settings / Users & Companies / Users - Edit demo: - Language: Dutch - Go to Projects - Click the three…
Steps: - Install Projects - Go to Settings / Translations / Languages - Install Dutch - Go to Settings / Users & Companies / Users - Edit demo: - Language: Dutch - Go to Projects - Click the three dots on the first project in the dashboard - Click Share - Select demo as recipient - Send - Go to Settings / Technical / Email / Emails - Click the email you just sent Bug: The email is not translated in the partner's language Explanation: The context of the template didn't take the current partner's language into account since it was out of the partners loop. The subject of the email wasn't aware of the partner's language as the context hadn't been changed. Wrapping the translations with the right `lang` context value fixes the issue. Also, the subject used the formatted string as the translation source. This makes it impossible to find a matching translation since the source is different every time. opw:2475398 Forward-Port-Of: odoo/odoo#68140 Forward-Port-Of: odoo/odoo#67969
PURPOSE in the crm lead if only formating different in email the email is updating in the partner also, but the email is same and it has only formatting difference than we don't have to update that email in partner, if the email is change than and only than we have to update that email Right way to detect the email change is: * lead email is difference from partner email * lead formatted email is different from partner formatted email
Original PR description
PURPOSE in the crm lead if only formating different in email the email is updating in the partner also, but the email is same and it has only formatting difference than we don't have to update that…
PURPOSE
in the crm lead if only formating different in email
the email is updating in the partner also, but the
email is same and it has only formatting difference
than we don't have to update that email in partner,
if the email is change than and only than we have
to update that email
Right way to detect the email change is:
* lead email is difference from partner email
* lead formatted email is different from partner formatted email
if this both conditions are match than we are quit sure the email
are different and not only formatting different.
SPECIFICATION
in this commit we are fix the inverse of email, email in the crm lead
has a two parts one is email header and one is email, if the we change
the header of the email it consider as a only formatting difference
and if we change in the email it consider as a email is change,
and if email is change than it also update the partner email.
Tests are added to ensure new behavior and that ribbon message is effectively
trig erred with correct content.
LINKS
Task ID-2461308
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#66890Description of the issue/feature this PR addresses: Add new VAT rate that was introduced since 16th of March 2021. Current behavior before PR: Vat rate of 14% is not supported. Desired behavior after PR is merged: VAT rate of 14% available on CoA template, VAT group for 14% is available. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67990
Original PR description
Description of the issue/feature this PR addresses: Add new VAT rate that was introduced since 16th of March 2021. Current behavior before PR: Vat rate of 14% is not supported. Desired behavior after PR is merged: VAT rate of 14% available on CoA template, VAT group for 14% is available. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67990
Add an additional report called "Voucher/记帐凭证" to print option in account.move form view. A library "cn2an" are required to conver a number to "amount in words/大写金额" for Chinese financial usage. Task 2179744 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68088
Original PR description
Add an additional report called "Voucher/记帐凭证" to print option in account.move form view. A library "cn2an" are required to conver a number to "amount in words/大写金额" for Chinese financial usage. Task 2179744 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68088
Add explicit label to invoice lines created with only amount, to avoid crashing in some tests Forward-Port-Of: odoo/odoo#67496
Original PR description
Add explicit label to invoice lines created with only amount, to avoid crashing in some tests Forward-Port-Of: odoo/odoo#67496
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67578
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67578
Description of the issue/feature this PR addresses: fixed passing arguments when handling an exception on the page `/website/info` which rises unexpected error Current behavior before PR: if an exception occurs there will be an error saying: `TypeError: _handle_exception() takes 2 positional arguments but 3 were given` Desired behavior after PR is merged: It should show actual exception -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-p
Original PR description
Description of the issue/feature this PR addresses: fixed passing arguments when handling an exception on the page `/website/info` which rises unexpected error Current behavior before PR: if an exception occurs there will be an error saying: `TypeError: _handle_exception() takes 2 positional arguments but 3 were given` Desired behavior after PR is merged: It should show actual exception -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68175
When a template string that contains an expression is translated, the resulting msgid is wrong. e.g.: _t(`blah blah ${expression}`) will generate a wrong msgid like this: msgid "blah blah ${expression}" Forward-Port-Of: odoo/odoo#68126
Original PR description
When a template string that contains an expression is translated, the
resulting msgid is wrong.
e.g.:
_t(`blah blah ${expression}`)
will generate a wrong msgid like this:
msgid "blah blah ${expression}"
Forward-Port-Of: odoo/odoo#68126In range references, the sheet is specified only once, at the begining. In the "Pipeline Revenue Report (Monthly)" template, there are several occurences of wrong references. e.g. "Sheet1!A1:Sheet1!A10" instead of "Sheet1!A1:A10" Note: it somehow works in 14.0, but it's broken in future o-spreadsheet versions, probably since the introduction of Ranges odoo/o-spreadsheet@67ca3a7 Task 2478170 Forward-Port-Of: odoo/enterprise#17225
Original PR description
In range references, the sheet is specified only once, at the begining. In the "Pipeline Revenue Report (Monthly)" template, there are several occurences of wrong references. e.g. "Sheet1!A1:Sheet1!A10" instead of "Sheet1!A1:A10" Note: it somehow works in 14.0, but it's broken in future o-spreadsheet versions, probably since the introduction of Ranges odoo/o-spreadsheet@67ca3a7 Task 2478170 Forward-Port-Of: odoo/enterprise#17225
In the next case: 1. Generate a customer invoice 2. Confirm and stamp with the SAT 3. Request EDI cancellation In Mexico, in the step 3, is necessary set the CFDI origin field with the UUID from the invoice, to ensure that will to relate in the new invoice (If will be validated again). But in some cases (before of this change), the CFDI origin is not set because the fiscal document is removed in the super, and the UUID is not found to be saved on the invoice. For this reason, first
Original PR description
In the next case: 1. Generate a customer invoice 2. Confirm and stamp with the SAT 3. Request EDI cancellation In Mexico, in the step 3, is necessary set the CFDI origin field with the UUID from the invoice, to ensure that will to relate in the new invoice (If will be validated again). But in some cases (before of this change), the CFDI origin is not set because the fiscal document is removed in the super, and the UUID is not found to be saved on the invoice. For this reason, first try to set the CFDI origin and after calls the super to set in draft the customer invoice. OPW#2480495 Forward-Port-Of: odoo/enterprise#17158
When the stopwatch resume button is pressed, if the stopwatch is no longer running, it throws an error, now it has been fixed. More in the video https://user-images.githubusercontent.com/65736397/111486811-17ac0580-8738-11eb-9530-c6ef79e3b53d.mp4 Forward-Port-Of: odoo/enterprise#17145
Original PR description
When the stopwatch resume button is pressed, if the stopwatch is no longer running, it throws an error, now it has been fixed. More in the video https://user-images.githubusercontent.com/65736397/111486811-17ac0580-8738-11eb-9530-c6ef79e3b53d.mp4 Forward-Port-Of: odoo/enterprise#17145
When generating the intrastat report, if the associated invoice linces are expressed in UoM different than the reference UoM, the weights and quantities won't be correct. To reproduce the error: (Need stock. Use French Company) 1. In Settings, enable: - Intrastat - Units of Measure 2. Create a customer C - Country: Belgium - VAT number: BE0477472701 3. Create a UoM - Name: Three - Category: Unit - Type: Bigger - Ratio: 3 4. Create a product P
Original PR description
When generating the intrastat report, if the associated invoice linces are expressed in UoM different than the reference UoM, the weights and quantities won't be correct. To reproduce the error:…
When generating the intrastat report, if the associated invoice linces
are expressed in UoM different than the reference UoM, the weights and
quantities won't be correct.
To reproduce the error:
(Need stock. Use French Company)
1. In Settings, enable:
- Intrastat
- Units of Measure
2. Create a customer C
- Country: Belgium
- VAT number: BE0477472701
3. Create a UoM
- Name: Three
- Category: Unit
- Type: Bigger
- Ratio: 3
4. Create a product P
- Unit of Measure: Three
- Weight: 1
5. Create an invoice
- Customer: C
- Invoice Line:
- Product: P
- Unit of Measure: Dozens
6. Post the invoice
7. Go to Intrastat Report
Error: The quantity is 1, it should be 12. This value is based on the
quantity of the account move line, but does not consider the UoM. If
this UoM is not the reference unit, the quantity must be converted.
Moreover, there is a similar problem with the weight (also equal to 1 on
the follow-up report).
The condition to use the `uom.factor` is not correct and does not use
the correct operator. When both invoice line and product have the same
UoM category, we can use the factor to convert the invoice line
quantity. It must be a division, not a multiplication (For instance:
'Three' has a factor of 0.33333 => 1 Three / 0.3333 = 3 Units)
The weight must be converted too. `prod.weight` is the weight of 1 X
product, where X is the UoM of the product and is not always the
reference UoM. In the case above, `prod.weight` is 1 kg, but since the
UoM of the product is 'Three', we have:
`1 'Three' P-product = 1 kg <=> 3 'Units' P-product = 1kg`.
However, the weight is multiplied by the quantity expressed in `Units`,
thus we have to get the weight per `Units` too:
`3 'Units' P-product = 1kg <=> 1 'Units' P-product = 0.333 kg`
OPW-2431764
Forward-Port-Of: odoo/enterprise#17214
Forward-Port-Of: odoo/enterprise#17007remove string interpolation from translations in o_spreadsheet.js Forward-Port-Of: odoo/enterprise#17195
Original PR description
remove string interpolation from translations in o_spreadsheet.js Forward-Port-Of: odoo/enterprise#17195
Forward-Port-Of: odoo/enterprise#16839
Original PR description
Forward-Port-Of: odoo/enterprise#16839
…lead If we convert a lead without phone and mobile and assign newly created ticket to a new partner its phone is not taken into account. Indeed original code takes as granted that partner is linked to the lead which is not always the case. Task ID-2461308 Linked to COM PR odoo/odoo#67859 X-Original-Commit odoo/enterprise@074cd4616e9380a76ee5a17043219f83bb3bdbdf
Original PR description
…lead If we convert a lead without phone and mobile and assign newly created ticket to a new partner its phone is not taken into account. Indeed original code takes as granted that partner is linked to the lead which is not always the case. Task ID-2461308 Linked to COM PR odoo/odoo#67859 X-Original-Commit odoo/enterprise@074cd4616e9380a76ee5a17043219f83bb3bdbdf
Copying templates was not tested as indicated by the test coverage report. This commit adds the missing tests. Forward-Port-Of: odoo/enterprise#17200
Original PR description
Copying templates was not tested as indicated by the test coverage report. This commit adds the missing tests. Forward-Port-Of: odoo/enterprise#17200
9227add2 [FIX] parser: change concatenate operator priority 7ae0a639 [IMP] prettier: add a script to check the formatting style 2bc061a9 [FIX] sheet: correctly duplicate cells 366da33c [FIX] gridcomposer: position composer assistant fd3122a4 [FIX] gridcomposer : resize height in some cases 9251fd33 [FIX] gridcomposer: apply cell style in some cases d3e7da57 [FIX] rollup: upgrade to lastest version Forward-Port-Of: odoo/enterprise#17090
Original PR description
9227add2 [FIX] parser: change concatenate operator priority 7ae0a639 [IMP] prettier: add a script to check the formatting style 2bc061a9 [FIX] sheet: correctly duplicate cells 366da33c [FIX] gridcomposer: position composer assistant fd3122a4 [FIX] gridcomposer : resize height in some cases 9251fd33 [FIX] gridcomposer: apply cell style in some cases d3e7da57 [FIX] rollup: upgrade to lastest version Forward-Port-Of: odoo/enterprise#17090