Wednesday, March 24, 2021
2 changes · master
Resolved issues and error corrections
This fix keeps HR skills page styling limited to the HR skills area so it no longer changes the appearance of unrelated Odoo screens. It also preserves the intended remove-button color in list views by moving that shared style to the web module.
Original PR description
Before this commit, hr_skills module defined a few css rules but weren't enclosed in a custom class to make them only for hr skills so these rules leaked everywhere in odoo. This commit encloses these css rules to not leak them and move a rule which changes the color of list's remove button into web module to keep the color.
This fix ensures automated tests clean up the temporary screen-blocking state created when simulating the Studio installation flow. It reduces the chance that one test affects another, making test results more reliable without changing normal user behavior.
Original PR description
The PromoteStudioDialog blocks UI when the user clicks on "Install Studio". The UI is then automatically unblocked as the webclient is reloaded. In tests, we mock the reload, but we didn't unblock the UI (i.e. the class o_ui_blocked remained on the body). This is a side-effect and we don't want tests to have side-effects, as it might influence other tests. In this case, a web_tour test failed if it was executed after those tests.