Daily updates from Odoo
Thursday, April 1, 2021
7 changes · master
Enhancements to existing features
This update renames an internal helper so it more accurately describes preparing contact data for an online response, rather than creating a new contact record. It reduces confusion for future maintenance without changing how users experience the helpdesk mail plugin.
Original PR description
Purpose ======= `_prepare_contact_values` sound like we will create a record. But the function will return the values for a JSON endpoint. Task 2466653
This update adds automated checks for field service projects that price work based on employee rates. It helps ensure sales order lines and timesheet billing stay accurate when tasks are completed or linked sales lines are changed.
Original PR description
Before this commit, very few tests exist to test the behaviour in a fsm project with pricing type set to employee rate. That is, with employee mappings. This commit adds some unit tests to check different cases that could be arrived when a fsm project has employee mappings. That is, the SOL generated in the SO generated to a fsm task when the user marks as done the task. When the user changes the SOL linked to the task, we need to search the SOLs for the timesheets based on the mappings, etc. task-2376382 Related PR: #16348
Code cleanup and technical improvements
This update adjusts several Odoo Enterprise apps to work with a recent reorganization of older JavaScript files. It is mainly an internal maintenance change that helps keep accounting, payments, planning, timesheets, signing, and web enterprise features functioning consistently.
Miscellaneous changes
The reconcilation page also suggests to reconcile the bank statement lines not posted yet. To reproduce the error: 1. Create a bank statement with one line BSL 2. Back to Accounting Dashboard, observe the Bank's Kanban Card - There is a button "Reconcile X Items" 3. Click on this button Error: There are actually X+1 items to reconcile. The difference comes from BSL. Moreover, since BSL is not posted, the user can not reconcile it ("You can only reconcile posted entries."). There
Original PR description
The reconcilation page also suggests to reconcile the bank statement
lines not posted yet.
To reproduce the error:
1. Create a bank statement with one line BSL
2. Back to Accounting Dashboard, observe the Bank's Kanban Card
- There is a button "Reconcile X Items"
3. Click on this button
Error: There are actually X+1 items to reconcile. The difference comes
from BSL. Moreover, since BSL is not posted, the user can not reconcile
it ("You can only reconcile posted entries."). Therefore, X is the
correct value and BSL should not be listed while it is not posted.
OPW-2469365
Forward-Port-Of: odoo/enterprise#17323Forward-Port-Of: odoo/enterprise#17422
Original PR description
Forward-Port-Of: odoo/enterprise#17422
When opened on a mobile device (smartphone or tablet), both the native Dialing Panel and the virtual one opens when composing a phone number. This commit sets the DialingPanel Widget's flag to detect such environment and properly hides the virtual dialing panel when the native one is available. Steps to reproduce: 1. Open VOIP panel 2. Click on dialing panel to compose a phone number 3. Both dialing panels are displayed => bug Task ID: 2495658 Forward-Port-Of: odoo/enterprise#1
Original PR description
When opened on a mobile device (smartphone or tablet), both the native Dialing Panel and the virtual one opens when composing a phone number. This commit sets the DialingPanel Widget's flag to detect such environment and properly hides the virtual dialing panel when the native one is available. Steps to reproduce: 1. Open VOIP panel 2. Click on dialing panel to compose a phone number 3. Both dialing panels are displayed => bug Task ID: 2495658 Forward-Port-Of: odoo/enterprise#17295
On dmfa, only count the co2 if the car was actually used by an employee Forward-Port-Of: odoo/enterprise#17409
Original PR description
On dmfa, only count the co2 if the car was actually used by an employee Forward-Port-Of: odoo/enterprise#17409