Thursday, April 1, 2021
2 changes · master
Enhancements to existing features
This update renames an internal helper so it more accurately describes preparing contact data for an online response, rather than creating a new contact record. It reduces confusion for future maintenance without changing how users experience the helpdesk mail plugin.
Original PR description
Purpose ======= `_prepare_contact_values` sound like we will create a record. But the function will return the values for a JSON endpoint. Task 2466653
This update adds automated checks for field service projects that price work based on employee rates. It helps ensure sales order lines and timesheet billing stay accurate when tasks are completed or linked sales lines are changed.
Original PR description
Before this commit, very few tests exist to test the behaviour in a fsm project with pricing type set to employee rate. That is, with employee mappings. This commit adds some unit tests to check different cases that could be arrived when a fsm project has employee mappings. That is, the SOL generated in the SO generated to a fsm task when the user marks as done the task. When the user changes the SOL linked to the task, we need to search the SOLs for the timesheets based on the mappings, etc. task-2376382 Related PR: #16348