Wednesday, April 7, 2021
20 changes · master
Enhancements to existing features
This change appears to adjust how website menu warning issues are loaded and displayed in Odoo. It likely helps users notice or manage website navigation problems more clearly, though the pull request details are incomplete and marked as work in progress.
Original PR description
Cancel :man_shrugging: https://www.odoo.com/web#id=2240373&action=327&model=project.task&view_type=form&cids=1&menu_id=4720  
Resolved issues and error corrections
The employee referrals page now displays the main superhero illustration at a more appropriate height. This keeps the page visually balanced and avoids an oversized graphic distracting users from the referral content.
Original PR description
Height of superhero was getting out of hand, had to shrink him down to size. He's happy he's the same size as his friends now.
Miscellaneous changes
Steps to reproduce the bug: 1/ Create an opening balance Journal Entry with debit 100$ "121000 Account Receivable" and credit 100$ on another account 2/ Create an invoice for 150$ 3/ Register a payment of 250$ for this invoice 4/ Reconcile the Journal Item of the payment (with "121000 Account Receivable" as account) with the opening balance => this line should be now fully reconcile 5/ Go to the payment and try to print the payment receipt Bug: The opening balance was shown as an in
Original PR description
Steps to reproduce the bug: 1/ Create an opening balance Journal Entry with debit 100$ "121000 Account Receivable" and credit 100$ on another account 2/ Create an invoice for 150$ 3/ Register a payment of 250$ for this invoice 4/ Reconcile the Journal Item of the payment (with "121000 Account Receivable" as account) with the opening balance => this line should be now fully reconcile 5/ Go to the payment and try to print the payment receipt Bug: The opening balance was shown as an invoice opw:2448349 Forward-Port-Of: odoo/odoo#68478
Problem ------- Writing on a calendar.event trigger _setup_alarms that may need to read on an ir.cron depending on the alarm setup. Non admin user are not allow to read ir.cron and thus an access error is trigger. Solution -------- Read the cron in sudo mode -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68553
Original PR description
Problem ------- Writing on a calendar.event trigger _setup_alarms that may need to read on an ir.cron depending on the alarm setup. Non admin user are not allow to read ir.cron and thus an access error is trigger. Solution -------- Read the cron in sudo mode -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68553
When a tax is deleted, remove the `account.tax.repartition.line` linked to it as well. Fixes #60603 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68824 Forward-Port-Of: odoo/odoo#68504
Original PR description
When a tax is deleted, remove the `account.tax.repartition.line` linked to it as well. Fixes #60603 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68824 Forward-Port-Of: odoo/odoo#68504
Retrieve the correct value of exta-saturation variable. Dynamically set the max, min value of the saturation slider. ### NB: The problem with this implementation is that if the user sets the saturation to the minimum value, the hue value will always revert to 0. **Proof:** Let L in [0, 100], and regardless of H1, H2 in [0, 360]: hsl(H1, 0, L) is always equal to hsl(H2, 0, L) Forward-Port-Of: odoo/odoo#68488
Original PR description
Retrieve the correct value of exta-saturation variable. Dynamically set the max, min value of the saturation slider. ### NB: The problem with this implementation is that if the user sets the saturation to the minimum value, the hue value will always revert to 0. **Proof:** Let L in [0, 100], and regardless of H1, H2 in [0, 360]: hsl(H1, 0, L) is always equal to hsl(H2, 0, L) Forward-Port-Of: odoo/odoo#68488
Added o_not_editable class to carousel-control-prev and carousel-control-next container divs so that the user can't add text when sliding carousel items task-2446852 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68823 Forward-Port-Of: odoo/odoo#65575
Original PR description
Added o_not_editable class to carousel-control-prev and carousel-control-next container divs so that the user can't add text when sliding carousel items task-2446852 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68823 Forward-Port-Of: odoo/odoo#65575
Forward PR from Master: #68819 #68827 #68830 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68858
Original PR description
Forward PR from Master: #68819 #68827 #68830 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68858
last-of-type pseudo class does not need parentheses [0]. This typo throws an exception only with recent versions of libsass. [0] https://developer.mozilla.org/en-US/docs/Web/CSS/:last-of-type Forward-Port-Of: odoo/odoo#68843
Original PR description
last-of-type pseudo class does not need parentheses [0]. This typo throws an exception only with recent versions of libsass. [0] https://developer.mozilla.org/en-US/docs/Web/CSS/:last-of-type Forward-Port-Of: odoo/odoo#68843
The resequence wizard should consider that the sequence is shared for invoices, journal entries and receipts; only refunds have a separate sequence. You could have journal entries in the purchase journal for expense reports for instance. In that case, we want to be able to resequence all of it at once. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68810
Original PR description
The resequence wizard should consider that the sequence is shared for invoices, journal entries and receipts; only refunds have a separate sequence. You could have journal entries in the purchase journal for expense reports for instance. In that case, we want to be able to resequence all of it at once. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68810
Before this, when making a partner without any country_id, any VAT could be set to it, which was inconsistent with the module's purpose. X-original-commit: 8c713ed2707cfd3fe2e519a6e6a02d63ae2601e8 Manual forward-port of https://github.com/odoo/odoo/pull/68253 (an enterprise branch was needed from 13.0 on) Forward-Port-Of: odoo/odoo#68751 Forward-Port-Of: odoo/odoo#68474
Original PR description
Before this, when making a partner without any country_id, any VAT could be set to it, which was inconsistent with the module's purpose. X-original-commit: 8c713ed2707cfd3fe2e519a6e6a02d63ae2601e8 Manual forward-port of https://github.com/odoo/odoo/pull/68253 (an enterprise branch was needed from 13.0 on) Forward-Port-Of: odoo/odoo#68751 Forward-Port-Of: odoo/odoo#68474
Without this, the website selector was not working Forward-Port-Of: odoo/odoo#68610
Original PR description
Without this, the website selector was not working Forward-Port-Of: odoo/odoo#68610
Odoo task : https://www.odoo.com/web#id=2497783&action=333&active_id=1695&model=project.task&view_type=form&cids=1&menu_id=4720 bug report from LNA: > here I am completely stuck, mouse in drag mode and blocked https://youtu.be/s6cB0f_Qhvo And why is the tool not on the picture and following me around ? https://youtu.be/pZIZwlCBc04 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68859
Original PR description
Odoo task : https://www.odoo.com/web#id=2497783&action=333&active_id=1695&model=project.task&view_type=form&cids=1&menu_id=4720 bug report from LNA: > here I am completely stuck, mouse in drag mode and blocked https://youtu.be/s6cB0f_Qhvo And why is the tool not on the picture and following me around ? https://youtu.be/pZIZwlCBc04 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68859
Currently, the company_id of an account move is related to its journal. This means that if you empty the journal field, the company_id is also emptied. This is then causing a traceback when adding a new line, for example. There is another issue in v14 where the list of possible journals is re-computed when the company_id change, effectively the user from adding back the journal. This change will transform the related company_id in a computed field, making sure to not lose the company_id
Original PR description
Currently, the company_id of an account move is related to its journal. This means that if you empty the journal field, the company_id is also emptied. This is then causing a traceback when adding a new line, for example. There is another issue in v14 where the list of possible journals is re-computed when the company_id change, effectively the user from adding back the journal. This change will transform the related company_id in a computed field, making sure to not lose the company_id if the journal_id is emptied. task id #2392004 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67238 Forward-Port-Of: odoo/odoo#62385
New module that adds argentinean requirements to the website ecommerce * Add fields to the checkout form * Identification type field * AFIP responsibility type field * Add logic to validate the new fields * Take into account the identification type when validating the VAT in the checkout form * Add validation of the combination between identification type and AFIP responsibility fields * Change label name for the vat field, to show "Number" instead of "VAT number". * Add de
Original PR description
New module that adds argentinean requirements to the website ecommerce * Add fields to the checkout form * Identification type field * AFIP responsibility type field * Add logic to validate the new fields * Take into account the identification type when validating the VAT in the checkout form * Add validation of the combination between identification type and AFIP responsibility fields * Change label name for the vat field, to show "Number" instead of "VAT number". * Add demo data to display an argentinean website and show products with taxes * Add module translations -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60309
*: website_sale_product_configurator The goal of this PR is to fix the tour : "shop_buy_product" by adding the "goToCart" step to work with the new "add to cart" scenarios (adding products in the same page is default behaviour). Forward-Port-Of: odoo/odoo#68839
Original PR description
*: website_sale_product_configurator The goal of this PR is to fix the tour : "shop_buy_product" by adding the "goToCart" step to work with the new "add to cart" scenarios (adding products in the same page is default behaviour). Forward-Port-Of: odoo/odoo#68839
When there are many account.asset records previous version of the query works slowly, because few selects are repeated for each asset without a chance to make a good plan. This commit changes that part: * for asset_method_number we join table with a single SELECT with grouped by asset_id * for first/last/before move queries we use a single SELECT query with DISTINCT ON Performance Test ================ * postgres 10.5 * Odoo v13 * Odoo.sh deployment * 4500 account.assets records
Original PR description
When there are many account.asset records previous version of the query works slowly, because few selects are repeated for each asset without a chance to make a good plan. This commit changes that part: * for asset_method_number we join table with a single SELECT with grouped by asset_id * for first/last/before move queries we use a single SELECT query with DISTINCT ON Performance Test ================ * postgres 10.5 * Odoo v13 * Odoo.sh deployment * 4500 account.assets records * 376 K account.move records for specific company * 680 K account.move records total Before: ~28 minutes for query execution After query optimization: ~48 seconds total (19871 10.460 37.158) After query optimization + company2code2account: ~21 seconds total (31 2.492 16.873) --- opw-2455194 Forward-Port-Of: odoo/enterprise#17522 Forward-Port-Of: odoo/enterprise#17450
- If it happened that disposal date is in the past and there are no posted depreciation moves that are less than the disposal date the disposal date get compared with today's date which results in entering the if block, thus get an error for no legit reason. - The bug as I encoutered it, I was not able to sell an asset with an invoice from the past. - opw-2476113 Forward-Port-Of: odoo/enterprise#17464
Original PR description
- If it happened that disposal date is in the past and there are no posted depreciation moves that are less than the disposal date the disposal date get compared with today's date which results in entering the if block, thus get an error for no legit reason. - The bug as I encoutered it, I was not able to sell an asset with an invoice from the past. - opw-2476113 Forward-Port-Of: odoo/enterprise#17464
The hierarchy builder is is based on the new report id mechanism. Backport of 7f4207ae95dd495eae10ccb79795a3887ec409d2 Forward-Port-Of: odoo/enterprise#17512
Original PR description
The hierarchy builder is is based on the new report id mechanism. Backport of 7f4207ae95dd495eae10ccb79795a3887ec409d2 Forward-Port-Of: odoo/enterprise#17512
The fix introduced in https://github.com/odoo/odoo/pull/68253 removes a case in which VAT numbers were not checked. These ones used to pass while they should not have. Forward-Port-Of: odoo/enterprise#17484 Forward-Port-Of: odoo/enterprise#17352
Original PR description
The fix introduced in https://github.com/odoo/odoo/pull/68253 removes a case in which VAT numbers were not checked. These ones used to pass while they should not have. Forward-Port-Of: odoo/enterprise#17484 Forward-Port-Of: odoo/enterprise#17352