Wednesday, April 21, 2021
4 changes · master
Enhancements to existing features
Payroll reports and declarations now gather payslip line totals much more efficiently, reducing generation time for Belgian monthly and annual documents. The update also includes related fixes to Belgian payroll declarations and data handling, improving reliability for payroll teams.
Original PR description
Purpose ======= For some payroll reports/declaration, we need to retrieve a lot of values for a lot of payslips, and aggregate those data in a PDF/XML/XLS/... file. Currently, it was mainly done by…
Purpose
=======
For some payroll reports/declaration, we need to retrieve a lot of values for a lot of payslips, and aggregate those data in a PDF/XML/XLS/... file.
Currently, it was mainly done by using some helpers like the method _get_salary_line_total to retrieve the value for a given code for a given payslip.
This PR introduces a new way to aggregate all those data in a single SQL request.
```python
a = sum(p._get_salary_line_total('BASIC') for p in payslips
b = sum(p._get_salary_line_total('NET') for p in payslips
c = sum(p._get_salary_line_quantity('MEAL_VOUCHERS') for p in payslips
```
would become
```python
line_values = payslips._get_line_values(['BASIC', 'NET'], vals_list=['total', 'quantity'], compute_sum=True)
a = line_values['BASIC']['sum']['total']
b = line_values['NET']['sum']['total']
c = line_values['MEAL_VOUCHERS']['sum']['quantity']
```
The value retrieval becomes O(1) instead of O(nbr_payslips x nbr_payslip_line)
For monthly/annual belgian reports, the execution time to generate a XML or PDF declaration for a hundred payslips is divided by 10.
TaskID: 2510163Accounting reports can now show tax details directly for each journal entry line, making tax amounts easier to review and trace. This improves the reliability of tax, general ledger, SAF-T, and related country-specific reports across different reporting scenarios.
Original PR description
task: 2352524
Marketing Automation now lets users edit activity filters directly inside the activity form instead of opening a second pop-up window. This reduces modal stacking, makes campaign setup smoother, and improves the overall user experience when configuring workflow activities.
Original PR description
PURPOSE In Marketing Automation, Change the domain editor in line. currently this activity_domain is open in wizard form, which is bad UX practice. CURRENT While creating/editing marketing activity in campaign it opens as wizard form, which is OK. But when we try to add domain on this particular activity, which open another wizard on the current one. which`s looks bad. TO BE Improves the behaviour of adding domain editor. Which is not open wizard for adding activity_domain, and open as inline domain editor. **TaskID - 2480625**
Pivot tables inserted into Documents spreadsheets no longer merge the top-left cells. This removes a purely visual formatting choice that could make selecting ranges harder, improving day-to-day spreadsheet usability.
Original PR description
…ertion Before this commit, the top left cells of a pivot are merged when inserting in spreadsheet. However, this merge can quickly become an issue when trying to select a range. Since the initial motivation for merging these cells was purely aesthetic, we simply get rid of this merge at pivot insertion. Task-id 2510104