Friday, April 23, 2021
22 changes · master
Enhancements to existing features
The Mail app’s message suggestion logic has been reorganized into dedicated reusable parts. This simplifies future maintenance and makes it easier to bring the same suggestion experience to other messaging areas without duplicating work.
Original PR description
This will reduce composer model complexity and allow to reuse suggestion code inside other component. task-2447140
This change makes it easier to add custom fields to the signup form without replacing the whole signup process. It helps businesses adapt customer registration to their needs with less development effort and lower maintenance risk.
Original PR description
Description of the issue/feature this PR addresses: In case you want add some custom field during sign up, you should override all method. @odony -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
Updated web test behavior so the same checks pass reliably in Firefox as well as Chrome. This reduces browser-specific test failures and helps keep future web changes easier to validate across supported browsers.
Original PR description
This fixes 3 tests which currently don't work in Firefox. * One is an overspecified check (which seems entirely unnecessary but...). * One is coding to Chrome's behaviour instead of spec. * The last is half/half between an FF bug and coding to an implementation: the FF behaviour is arguably stupid but apparently not out-of-spec.
Miscellaneous changes
Open a purchase order with several lines Switch to Edit mode Use the movement arrow on the left of a line to move it upward/downward At the end of the operation a traceback will popup opw-2508480 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69699
Original PR description
Open a purchase order with several lines Switch to Edit mode Use the movement arrow on the left of a line to move it upward/downward At the end of the operation a traceback will popup opw-2508480 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69699
CRM searches now keep letters and other typed characters when filtering phone numbers, instead of reducing the search to digits only. This prevents broad or misleading matches, such as searching for "hello123" and seeing unrelated numbers that merely contain "123".
Original PR description
Description of the issue/feature this PR addresses: When the user enters an american phone number containing letters, the filter can sometimes return phone numbers that do not match exactly with the provided input string. Current behavior before PR: The phone filter trim all non digit numbers. Desired behavior after PR is merged: The phone filter will no longer trim all non digit numbers. Task ID : 2424185 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Enterprise: https://github.com/odoo/enterprise/pull/17616 Upgrade: https://github.com/odoo/upgrade/pull/2377 Forward-Port-Of: odoo/odoo#69111
Original PR description
Enterprise: https://github.com/odoo/enterprise/pull/17616 Upgrade: https://github.com/odoo/upgrade/pull/2377 Forward-Port-Of: odoo/odoo#69111
…'t raise an exception any more when creating a new invoice Before this commit, when an attachment was present in the xml (pdf) and the import was to create a new invoice, it crashed when trying to post the pdf on the not-yet existant invoice. This commit also fixes: - In the tests, `create_invoice_from_file` didn't handle the subfolder parameter correctly - `create_invoice_from_file` now returns the created invoice Description of the issue/feature this PR addresses: Current behavi
Original PR description
…'t raise an exception any more when creating a new invoice Before this commit, when an attachment was present in the xml (pdf) and the import was to create a new invoice, it crashed when trying to post the pdf on the not-yet existant invoice. This commit also fixes: - In the tests, `create_invoice_from_file` didn't handle the subfolder parameter correctly - `create_invoice_from_file` now returns the created invoice Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69695 Forward-Port-Of: odoo/odoo#69582
Suppose both Google Calendar and Odoo Calendar are synced. Google will not send any invitation to attendees when the user creates an event from Odoo. This fix requires Google to notify attendees when an event is created, modified or cancelled. OPW-2501413 Forward-Port-Of: odoo/odoo#69444
Original PR description
Suppose both Google Calendar and Odoo Calendar are synced. Google will not send any invitation to attendees when the user creates an event from Odoo. This fix requires Google to notify attendees when an event is created, modified or cancelled. OPW-2501413 Forward-Port-Of: odoo/odoo#69444
To reproduce the error: (Need sale_management) 1. In Settings: - Line Subtotals Tax Display: Tax-Included 2. Create a tax T: - Included in Price: True 3. Create and save a SO - Add a line with T 4. Switch to mobile view Error: The amount of the order line is incorrect, it does not consider the option from step 1. OPW-2484646 Forward-Port-Of: odoo/odoo#69720 Forward-Port-Of: odoo/odoo#69627
Original PR description
To reproduce the error:
(Need sale_management)
1. In Settings:
- Line Subtotals Tax Display: Tax-Included
2. Create a tax T:
- Included in Price: True
3. Create and save a SO
- Add a line with T
4. Switch to mobile view
Error: The amount of the order line is incorrect, it does not consider
the option from step 1.
OPW-2484646
Forward-Port-Of: odoo/odoo#69720
Forward-Port-Of: odoo/odoo#69627Odoo task : https://www.odoo.com/web#action=333&active_id=1695&cids=1&id=2502240&menu_id=4720&model=project.task&view_type=form -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69588
Original PR description
Odoo task : https://www.odoo.com/web#action=333&active_id=1695&cids=1&id=2502240&menu_id=4720&model=project.task&view_type=form -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69588
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69413
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69413
**PURPOSE** In the chatter, the attachment preview image size is fixed with 160*160 but the actual preview area is 200*200px so the image is not filling correctly. It appears padding around the image, especially visible when hovering it. **SPECIFICATION** we have removed the cropping of the image. so it will display as it is without losing the exact image. We should make sure to use a properly sized image in the preview. we have to also provide the perfect resolution and preview f
Original PR description
**PURPOSE** In the chatter, the attachment preview image size is fixed with 160*160 but the actual preview area is 200*200px so the image is not filling correctly. It appears padding around the image, especially visible when hovering it. **SPECIFICATION** we have removed the cropping of the image. so it will display as it is without losing the exact image. We should make sure to use a properly sized image in the preview. we have to also provide the perfect resolution and preview for the small images without upscaling incorrectly. For large images, it should be display based on the aspect ratio Task : 2483885 Forward-Port-Of: odoo/odoo#68696
The timeout for images download from unsplash is set to 3s. The exception raised when this limit is reached was not correctly handled. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69697
Original PR description
The timeout for images download from unsplash is set to 3s. The exception raised when this limit is reached was not correctly handled. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69697
For customer invoices: * do not set default date because if you prepare an invoice (and it gets a default date), then validate it the next day, the date will be wrong * set the date when posting if it wasn't set, because why not? For vendor bills: * do not set default date because you rarely encode a bill at the bill date. Forcing the user to enter it reduces risks of user error (duplicated vendor bill) * do not set it when posting, same reason. Enterprise PR: https://github.c
Original PR description
For customer invoices: * do not set default date because if you prepare an invoice (and it gets a default date), then validate it the next day, the date will be wrong * set the date when posting if it wasn't set, because why not? For vendor bills: * do not set default date because you rarely encode a bill at the bill date. Forcing the user to enter it reduces risks of user error (duplicated vendor bill) * do not set it when posting, same reason. Enterprise PR: https://github.com/odoo/enterprise/pull/17502 Upgrade PR: https://github.com/odoo/upgrade/pull/2356 opw-2492862 Related #68368 Closes #68367 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69202 Forward-Port-Of: odoo/odoo#68689
Add the 'data-snippet' attribute on each snippet rendered by the configurator when building website pages. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69546
Original PR description
Add the 'data-snippet' attribute on each snippet rendered by the configurator when building website pages. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69546
Before introducing the new Odoo Editor, the body of an iframe containing the editor has the class "editor_enable". Now it's applied to the main document's body. This ensure the class is applied on the iframe's body like before. As a consequence, some CSS had to be adapted: - The position property of the snippets menu which had been overridden, probably as an ad-hoc fix for the fact that this class was missing. - The top padding which is applied to accomodate a top toolbar which was removed wi
Original PR description
Before introducing the new Odoo Editor, the body of an iframe containing the editor has the class "editor_enable". Now it's applied to the main document's body. This ensure the class is applied on the iframe's body like before. As a consequence, some CSS had to be adapted: - The position property of the snippets menu which had been overridden, probably as an ad-hoc fix for the fact that this class was missing. - The top padding which is applied to accomodate a top toolbar which was removed with the new editor and can now be removed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69760
- Create an invoice for a portal user - Add a credit note for that invoice - Connect with portal user - On Invoices & Bills menu, the correct count is displayed (i.e. 2) - Open Invoices & Bills page The "All" filter only displays out_invoice and in_invoice, making impossible to view the other types (out_refund, in_refund, out_receipt, in_receipt). opw-2486471 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged:
Original PR description
- Create an invoice for a portal user - Add a credit note for that invoice - Connect with portal user - On Invoices & Bills menu, the correct count is displayed (i.e. 2) - Open Invoices & Bills page The "All" filter only displays out_invoice and in_invoice, making impossible to view the other types (out_refund, in_refund, out_receipt, in_receipt). opw-2486471 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69693
Before this commit, it might happen that, in some situations, with several tabs opened, the CrossTabBus called the longpolling route repeatedly, thus slowing down the server, and freezing the webclient. The issue was tricky to reproduce. It was a race-condition that could occur when several tabs performed simultanous calls to addChannel, while being unloaded or becoming mastertab in the meantime (e.g. when opening/closing/refreshing several tabs simultaneously). This issue has been
Original PR description
Before this commit, it might happen that, in some situations, with several tabs opened, the CrossTabBus called the longpolling route repeatedly, thus slowing down the server, and freezing the…
Before this commit, it might happen that, in some situations, with several tabs opened, the CrossTabBus called the longpolling route repeatedly, thus slowing down the server, and freezing the webclient. The issue was tricky to reproduce. It was a race-condition that could occur when several tabs performed simultanous calls to addChannel, while being unloaded or becoming mastertab in the meantime (e.g. when opening/closing/refreshing several tabs simultaneously). This issue has been introduced by [1] which by mistake (probably) made each tab calling itself the localStorage to update the list of channels when it was notified that the list of channels in the localStorage just changed. So if several tabs had a slightly different list of channels at a given moment (e.g. at startup), it might happen that they in turn, undo what another tab just put in the localStorage, and thus produced an infinite loop of localStorage writes and longpolling request aborts/calls. The issue could be reproduced with the OCA module [2], which performs several addChannel at webclient startup. This commit restores this part of the code as it was initially written in [3]. Closes #69067 opw~2502799 maybe opw~2451865 as well [1] https://github.com/odoo/odoo/commit/6448420 [2] https://odoo-community.org/shop/product/web-notify-2670#attr=10773 [3] https://github.com/odoo/odoo/commit/38581f67236377daa767ca2216529a26b8708b00#diff-f6eccad21ae3543606ab8f97b8b097d015412caeaee2bf8cc928eb3ccabac9f5R149 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69756 Forward-Port-Of: odoo/odoo#69383
_get_report_country_code() existed in ec sales reports, but then was added in account_report with slight different function. Partially braking it's intended behavior for ec sales. Countries that do not have a specific ec sale report must use the generic report. This was not the case anymore. To prevent confusion with account_report _get_report_country_code() method, the mechanism in ec sales was changed with _get_non_generic_country_codes() method. Forward-Port-Of: o
Original PR description
_get_report_country_code() existed in ec sales reports, but then was added in account_report with slight different function. Partially braking it's intended behavior for ec sales. Countries that do not have a specific ec sale report must use the generic report. This was not the case anymore. To prevent confusion with account_report _get_report_country_code() method, the mechanism in ec sales was changed with _get_non_generic_country_codes() method. Forward-Port-Of: odoo/enterprise#17906
In previous versions, it was the amount of the write-off that should have been zero when the currencies were not the same. The problem is that now the entire amount is 0 when the currencies are different. So, we remove those conditions. And at least now, it will pass non-zero when the currencies are different. Forward-Port-Of: odoo/enterprise#17688
Original PR description
In previous versions, it was the amount of the write-off that should have been zero when the currencies were not the same. The problem is that now the entire amount is 0 when the currencies are different. So, we remove those conditions. And at least now, it will pass non-zero when the currencies are different. Forward-Port-Of: odoo/enterprise#17688
See https://github.com/odoo/odoo/pull/68689 Forward-Port-Of: odoo/enterprise#17825 Forward-Port-Of: odoo/enterprise#17502
Original PR description
See https://github.com/odoo/odoo/pull/68689 Forward-Port-Of: odoo/enterprise#17825 Forward-Port-Of: odoo/enterprise#17502
Community: https://github.com/odoo/odoo/pull/69111 Upgrade: https://github.com/odoo/upgrade/pull/2377 Forward-Port-Of: odoo/enterprise#17616
Original PR description
Community: https://github.com/odoo/odoo/pull/69111 Upgrade: https://github.com/odoo/upgrade/pull/2377 Forward-Port-Of: odoo/enterprise#17616