Monday, April 26, 2021
31 changes · master
Enhancements to existing features
This update makes key parts of the stock delivery slip report easier to identify and customize. Businesses and implementation partners can adapt delivery documents more reliably without changing the report from scratch.
Original PR description
Description of the issue/feature this PR addresses: Poor extensibility of delivery slip report supersedes https://github.com/odoo/odoo/pull/28333 Current behavior before PR: The most important nodes of report doesn't have names Desired behavior after PR is merged: they have names and can be xpathed noramlly -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Customer rating labels were adjusted so the choices feel more balanced from dissatisfied to satisfied. This makes feedback requests in Helpdesk and Subscriptions clearer and less negatively biased, helping businesses collect more accurate satisfaction signals.
Original PR description
Rating texts had a negative skewness. TaskID: 2439720
This update removes unnecessary payroll rules related to double holiday calculations for Belgian employees. It simplifies payroll configuration and reduces the chance of confusion without changing core payroll functionality.
Original PR description
TaskID: 2496599
The marketing automation mailing settings now use consistent wording for reply handling options. This reduces confusion for users and aligns the terminology with related email gateway behavior.
Spreadsheet pivot-related menu options have been moved from the general Insert section to the dedicated Pivots section. This makes the options easier to find and keeps related spreadsheet actions grouped together for users.
Original PR description
Menu items "re-Insert Pivot" and "Insert pivot cell" are currently in the "Insert" section. This commit moves them in the "Pivots" section Task 2339867
Resolved issues and error corrections
This fixes an error that could occur when using the calendar in month view on a mobile device. Users can now open mobile calendar month view with events without running into a blocking issue.
Original PR description
This PR fix a bug introduced in odoo/odoo@ac13964244f54f268635b3a5d209d0b8e7d78076. On mobile, 'this.el' is empty because '_getFullCalendarOptions' is overridden and so the scope is not the same, instead we use the FullCalendar view element. Note : the use of _.str.sprintf is not needed as it introduces an unnecessary overhead. Steps to reproduce: * Open Odoo (Mobile) * Go in a calendar view * Select month view (with a event inside) => BUG -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
This change removes duplicate logic from the stock accounting price calculation. It keeps the code easier to maintain without changing expected business behavior.
Original PR description
Title^
Miscellaneous changes
Steps to reproduce the bug: - Let's consider a consumable product P with a subcontracted BOM B - Let's consider that B is subcontracted by a partner S and B has a storable component C - C has the route Resupply Subcontractor on Order and has a partner SUP as supplier - Create a purchase order PO with 1 P to S and confirm PO - A delivery order DO1 is created with C to S - Change the ordered quantity on PO and set 2 instead of 1 Bug: DO1 was canceled and a new delivery order DO2 was
Original PR description
Steps to reproduce the bug: - Let's consider a consumable product P with a subcontracted BOM B - Let's consider that B is subcontracted by a partner S and B has a storable component C - C has the…
This fix prevents a web test helper from trying to load a messaging component when the related mail module is not present. It keeps automated checks stable in setups that do not include that module, reducing false failures during development and maintenance.
Original PR description
Follow up on bd67479316dfb19021de06b7007d2ae3c84284e3
This test file is not respecting Odoo module dependencies.
If the module is not defined, calling `[Symbol.for("default")]` will crash.
Old require system didn't have this syntax, the similar guard was done just
before using the class.The CRM Leads reporting list now uses the correct lead list and lets users open the matching lead form from that view. This makes reporting navigation consistent with graph, pivot, and dashboard views and removes confusion when reviewing lead analysis.
Original PR description
PURPOSE When we go to CRM -> Reporting -> Leads, It shows the analysis of leads. We can open the form view of every leads from the different views wise Graph, 'Pivot', and 'Dashboard' except the 'List' view and it's a bit odd. We should be able to open the form view from corresponding leads in the list view. Currently, the view which is coming in the 'List' view is not correct and should be replaced by the same view which is rendered by action 'crm_lead_all_leads' SPECIFICATIONS Initially, we have to fix the correct list view to be rendered and that is 'crm_case_tree_view_leads' instead of 'crm_case_tree_view_oppor'. Next, we have added the form view in addition to the list view in view_ids of the corresponding action. This is the goal of this commit. LINKS PR #17839 Task 2497936
This fixes an issue where the calendar could show an error on mobile when users opened the month view with events. The change helps mobile users view and manage calendar entries reliably without interruption.
Original PR description
This PR fix a bug introduced in odoo/odoo@ac13964244f54f268635b3a5d209d0b8e7d78076 Before this commit, on mobile, 'this' was undefined because '_getFullCalendarOptions' was overridden and so the scope was not properly passed along. After this commit, now we bind the event with the FullCalendar instance to keep the original 'this' through the override. Steps to reproduce: * Open Odoo (Mobile) * Go in a calendar view * Select month view (with a event inside) => BUG
Steps to reproduce the bug: - Let's consider a consumable product P with a subcontracted BOM B - Let's consider that B is subcontracted by a partner S and B has a storable component C - C has the route Resupply Subcontractor on Order and has a partner SUP as supplier - Create a purchase order PO with 1 P to S and confirm PO - A delivery order DO1 is created with C to S - Change the ordered quantity on PO and set 2 instead of 1 Bug: DO1 was canceled and a new delivery order DO2 was created with only 1 C instead of 2 It happens due to merge move, when updating the PO line a new rule is trigger and create the object in this order: - Move Sub-Stock(finished) -> Subcontract Order -> Move Stock-Sub(comp) Then the action_confirm is trigger and will run _merge_move on object from left to right order. But when the move Sub-Stock is merged, everything is write in the first move and the new move is unlink. It result by canceling all the following object (so the new subcontractor and the Move Stock-Sub). It was not an issue for the subcontracting since the write of stock.move is overridden in order to update the order quantity when the move quantity is updated. However in this case the rule are not triggered in order to create the moves that ressuply the subcontractor. In order to avoid this mess, this PR prevent the merge in case of a subcontracting move. opw-2419222 Forward-Port-Of: odoo/odoo#67745
Purpose of this commit is to fix computation of access link. In some cases msg_vals modification leads to invalid URL computation, notably for frontend or backend differentiation for target recipients. Followup of odoo/odoo#63292 . COM PR odoo/odoo# ENT PR odoo/enterprise#17849 Forward-Port-Of: odoo/odoo#69759 Forward-Port-Of: odoo/odoo#69607
Original PR description
Purpose of this commit is to fix computation of access link. In some cases msg_vals modification leads to invalid URL computation, notably for frontend or backend differentiation for target recipients. Followup of odoo/odoo#63292 . COM PR odoo/odoo# ENT PR odoo/enterprise#17849 Forward-Port-Of: odoo/odoo#69759 Forward-Port-Of: odoo/odoo#69607
PURPOSE When sending a bounce autoreply it should have correct alias name in mail body. SPECIFICATION Current: When sending mail in cc to the alias which is partner only, bounce mail body contatins 'to' mail_id rather than 'cc' mail_id. To Be: It should contain correct alias name( mail_id ). It should not be matter that it is send in 'to' or as 'cc'. LINKS PR: #66654 TASK ID: 2390310 I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
PURPOSE When sending a bounce autoreply it should have correct alias name in mail body. SPECIFICATION Current: When sending mail in cc to the alias which is partner only, bounce mail body contatins 'to' mail_id rather than 'cc' mail_id. To Be: It should contain correct alias name( mail_id ). It should not be matter that it is send in 'to' or as 'cc'. LINKS PR: #66654 TASK ID: 2390310 I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69752 Forward-Port-Of: odoo/odoo#66654
This commit round the payment line instead of the total amount. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69604 Forward-Port-Of: odoo/odoo#69544
Original PR description
This commit round the payment line instead of the total amount. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69604 Forward-Port-Of: odoo/odoo#69544
- Report line should be in alphabetical order Task: https://www.odoo.com/web#id=2502322&action=333&active_id=967&model=project.task&view_type=form&cids=2&menu_id=4720 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69032
Original PR description
- Report line should be in alphabetical order Task: https://www.odoo.com/web#id=2502322&action=333&active_id=967&model=project.task&view_type=form&cids=2&menu_id=4720 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69032
Description of the issue/feature this PR addresses: ID should be the number of the invoice, especially when it is a customer invoice.  @oco-odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68528
Original PR description
Description of the issue/feature this PR addresses: ID should be the number of the invoice, especially when it is a customer invoice.  @oco-odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68528
- Create Tax Exempt fiscal position - Create Customer with Tax Exempt in fiscal position - Enable Tax Exempt fiscal position in POS settings - In POS, set customer to one with Tax Exempt - Create a sale, apply, payment, validate, and click New Order - Click magnifying glass to reprint receipt - Default tax is automatically applied to all past orders/receipts This occur because: - in Pos OrderList the total is based on the amount total, and not the actual amount paid - the fiscal posi
Original PR description
- Create Tax Exempt fiscal position - Create Customer with Tax Exempt in fiscal position - Enable Tax Exempt fiscal position in POS settings - In POS, set customer to one with Tax Exempt - Create a sale, apply, payment, validate, and click New Order - Click magnifying glass to reprint receipt - Default tax is automatically applied to all past orders/receipts This occur because: - in Pos OrderList the total is based on the amount total, and not the actual amount paid - the fiscal position object is not present when retrieving the order via `selectedOrder` opw-2485178 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69743 Forward-Port-Of: odoo/odoo#69475
PURPOSE: To resolve the error occurring while merging the mail list and change name of button to "MERGE" from "Merge Selected Mailing Lists". SPECIFICATION: Current: Error: 'int' object is not subscriptable Button name: "MERGE" from "Merge Selected Mailing Lists". To be: To resolve this error and change button name to "MERGE" LINKS: Task Id: 2471692 PR: #67213 I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/od
Original PR description
PURPOSE: To resolve the error occurring while merging the mail list and change name of button to "MERGE" from "Merge Selected Mailing Lists". SPECIFICATION: Current: Error: 'int' object is not subscriptable Button name: "MERGE" from "Merge Selected Mailing Lists". To be: To resolve this error and change button name to "MERGE" LINKS: Task Id: 2471692 PR: #67213 I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69610 Forward-Port-Of: odoo/odoo#67213
The PR https://github.com/odoo/odoo/pull/68799 tried to prevent the form's edit button to bounce when quick editing. The fix was wrong and some field continued to bounce the button. This commit prevents the edit button to bounce when clicking on any field by checking if we are quick editing. Forward-Port-Of: odoo/odoo#69778 Forward-Port-Of: odoo/odoo#69452
Original PR description
The PR https://github.com/odoo/odoo/pull/68799 tried to prevent the form's edit button to bounce when quick editing. The fix was wrong and some field continued to bounce the button. This commit prevents the edit button to bounce when clicking on any field by checking if we are quick editing. Forward-Port-Of: odoo/odoo#69778 Forward-Port-Of: odoo/odoo#69452
Before this commit, There would be Traceback (AttributeError: 'bool' object has no attribute 'date') on Confirm Receipt Date If order has no Receipt Date. Now, Button Confirm Receipt Date will be hidden if there is not Receipt Date to confirm. Original behavior was fixed on #60659 but attribute was replaced here which misses this condition. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm
Original PR description
Before this commit, There would be Traceback (AttributeError: 'bool' object has no attribute 'date') on Confirm Receipt Date If order has no Receipt Date. Now, Button Confirm Receipt Date will be hidden if there is not Receipt Date to confirm. Original behavior was fixed on #60659 but attribute was replaced here which misses this condition. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69437
Steps to reproduce the bug: - Let's consider two companies C1, C2 and a partner P in C2 - Let's consider an customner invoice I in C1 with P as customer - Go to Accounting > Accounting > Partner Ledger and select I - Click on Reconcie Bug: An access error was raised due to the ir.rule res.partner company opw:2446242 Forward-Port-Of: odoo/odoo#69190
Original PR description
Steps to reproduce the bug: - Let's consider two companies C1, C2 and a partner P in C2 - Let's consider an customner invoice I in C1 with P as customer - Go to Accounting > Accounting > Partner Ledger and select I - Click on Reconcie Bug: An access error was raised due to the ir.rule res.partner company opw:2446242 Forward-Port-Of: odoo/odoo#69190
To display an aggregate in a list view, the field format method is used. But since mrp_time_counter that extend float_time has no format method, you would see eg. 2.07 as aggregate and 2:04 on the line which is a little confusing. opw-2514634 Forward-Port-Of: odoo/odoo#69770
Original PR description
To display an aggregate in a list view, the field format method is used. But since mrp_time_counter that extend float_time has no format method, you would see eg. 2.07 as aggregate and 2:04 on the line which is a little confusing. opw-2514634 Forward-Port-Of: odoo/odoo#69770
When the refactor of assets was done, the link to the stripe javascript framework was moved to __manifest__.py As the link does not end with '.js', the ORM just ignore it, the script is not send to the frontend and prevents the partner using any functionnality implementing stripe. See PR #60632 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69606
Original PR description
When the refactor of assets was done, the link to the stripe javascript framework was moved to __manifest__.py As the link does not end with '.js', the ORM just ignore it, the script is not send to the frontend and prevents the partner using any functionnality implementing stripe. See PR #60632 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69606
Forward-Port-Of: odoo/odoo#69681
Original PR description
Forward-Port-Of: odoo/odoo#69681
Task [2352493](https://www.odoo.com/web#id=2352493&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) When the user is asked to fill in the label on the invoice, the tooltip tells him that the label can be auto-filled by configuring its products. This leads the user to configure products. But then, as he doesn't fill in the label, the tour is "broken". Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior afte
Original PR description
Task [2352493](https://www.odoo.com/web#id=2352493&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) When the user is asked to fill in the label on the invoice, the tooltip tells him that the label can be auto-filled by configuring its products. This leads the user to configure products. But then, as he doesn't fill in the label, the tour is "broken". Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#62272
What are the steps to reproduce your issue ? 1. Install 'purchase_product_matrix' 2. try to edit a PO with more than one line 3. try to change the order of a product line What is currently happening ? Traceback: TypeError: Cannot read property 'data' of undefined What are you expecting to happen ? Change order lines without traceback Why is this happening ? There is a function `reset` that checkes if `ev` exists: https://github.com/odoo/odoo/blob/e0af1
Original PR description
What are the steps to reproduce your issue ? 1. Install 'purchase_product_matrix' 2. try to edit a PO with more than one line 3. try to change the order of a product line What is currently happening…
What are the steps to reproduce your issue ?
1. Install 'purchase_product_matrix'
2. try to edit a PO with more than one line
3. try to change the order of a product line
What is currently happening ?
Traceback: TypeError: Cannot read property 'data' of undefined
What are you expecting to happen ?
Change order lines without traceback
Why is this happening ?
There is a function `reset` that checkes if `ev` exists:
https://github.com/odoo/odoo/blob/e0af10ccc92cb3b07f0eea6fa44ebf5a1bdc86aa/addons/sale/static/src/js/product_configurator_widget.js#L117-L130
And in `purchase_product_matrix` there is a override of this same function that calls it
and then tries to use an `ev` attribute without checking it before
https://github.com/odoo/odoo/blob/a87f1706997eda1a72054c195fc63685d7a05c35/addons/purchase_product_matrix/static/src/js/product_matrix_configurator.js#L100-L105
How to fix the bug ?
Check 'ev' before accessing it
opw-2513061
Forward-Port-Of: odoo/odoo#69666A customer experienced 30-50 second delays after confirming the address in the e-commerce shopping cart. The reason this happened is that some of the Taxcloud code queries the first tax that meets certain criteria and sets the `active` field to `True`. The ORM currently doesn't check if this value was already the same, and will marked all fields and records dependent on the tax for recomputation. In the case of the customer that involved thousands of records and a dozen fields of those re
Original PR description
A customer experienced 30-50 second delays after confirming the address in the e-commerce shopping cart. The reason this happened is that some of the Taxcloud code queries the first tax that meets certain criteria and sets the `active` field to `True`. The ORM currently doesn't check if this value was already the same, and will marked all fields and records dependent on the tax for recomputation. In the case of the customer that involved thousands of records and a dozen fields of those records, which takes a while to recompute. This fix avoids that scenario by only setting the value if it wasn't already set. Ticket: 2451513 Forward-Port-Of: odoo/enterprise#17873
Steps to follow to reproduce the bug: - Go to documents app/ Create a spreadsheet or choose an existing one - Replace the document with another of a different format (pdf, zip, jpg ...) - Open the new document - An error is triggered Problem: Spreadsheet documents have a "spreadsheet" handler that we do not remove when replacing the document with another of a different type opw-2497869 Forward-Port-Of: odoo/enterprise#17837 Forward-Port-Of: odoo/enterprise#17715
Original PR description
Steps to follow to reproduce the bug: - Go to documents app/ Create a spreadsheet or choose an existing one - Replace the document with another of a different format (pdf, zip, jpg ...) - Open the new document - An error is triggered Problem: Spreadsheet documents have a "spreadsheet" handler that we do not remove when replacing the document with another of a different type opw-2497869 Forward-Port-Of: odoo/enterprise#17837 Forward-Port-Of: odoo/enterprise#17715
…stomers According to the commit ba244cef01132347df4d2d9553ea3105ba13a938 A new syntax is used for the translated terms. This commit is fixing an issue where it was not possible to correctly display the error message. opw-2479445 Forward-Port-Of: odoo/enterprise#17199
Original PR description
…stomers According to the commit ba244cef01132347df4d2d9553ea3105ba13a938 A new syntax is used for the translated terms. This commit is fixing an issue where it was not possible to correctly display the error message. opw-2479445 Forward-Port-Of: odoo/enterprise#17199
Fixup of https://github.com/odoo/enterprise/commit/f0bee57971dabf8a6dd49ca5a979d8220e20e16b opw-2498103 Forward-Port-Of: odoo/enterprise#17843 Forward-Port-Of: odoo/enterprise#17771
Original PR description
Fixup of https://github.com/odoo/enterprise/commit/f0bee57971dabf8a6dd49ca5a979d8220e20e16b opw-2498103 Forward-Port-Of: odoo/enterprise#17843 Forward-Port-Of: odoo/enterprise#17771
See community PR for more details. COM PR odoo/odoo# ENT PR odoo/enterprise# Forward-Port-Of: odoo/enterprise#17907 Forward-Port-Of: odoo/enterprise#17849
Original PR description
See community PR for more details. COM PR odoo/odoo# ENT PR odoo/enterprise# Forward-Port-Of: odoo/enterprise#17907 Forward-Port-Of: odoo/enterprise#17849