Odoo Changelog — 2021-05-03

Monday, May 3, 2021

33 changes · master

Improvements(4)

Enhancements to existing features

[IMP] Base: specify placeholder for company partners

Coremasterbase

When an individual contact is linked to a company but has no company image set, the contact card now shows a company-style placeholder instead of a generic camera icon. This makes company-related contacts easier to recognize visually and improves consistency in the contact overview.

Original PR description

taskid: 2491161

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#contacts#company#placeholder#kanban

[IMP] mail: add update command and use it on thread viewer

PR #70251

Coremastermail

The mail app now handles thread viewer updates through each related model rather than relying on many shared dependencies. This makes the thread viewing experience easier to maintain and adapt across different areas of Odoo, with minimal direct impact on end users.

Original PR description

Instead of thread viewer having many dependencies, this allows models "having
the thread viewer feature" to keep their own logic for themselves.

The "create or update" part has to be done manually in this case (as opposed to
using "insert") because thread viewer has no clear identifying data, since it
would depend on which model is using it in the first place.

#mail#thread viewer#maintainability

[IMP] core: speed up registry setup

PR #17963

Enterprisemasteraccount_assetmarketing_automationsocial

This update supports faster setup of core system components by making some internal field behavior explicit. It helps improve reliability during system startup and module loading, with no expected day-to-day workflow changes for users.

Original PR description

Companion of https://github.com/odoo/odoo/pull/69924.

#performance#registry#setup#reliability

[IMP] helpdesk: improve the helpdesk stages form view

PR #17865

Enterprisemasterhelpdesk

The Helpdesk stage form now aligns its legend fields more consistently, matching the layout used in project stages. This makes the configuration screen cleaner and easier for users to read without changing any underlying helpdesk behavior.

Original PR description

Currently, in the helpdesk stages legend_* fields are not properly aligned.

so in this commit, align the legend fields on helpdesk stage same as aligned in the project stages.

TaskID: 2508642

#helpdesk#user interface#stage configuration

Bug Fixes(4)

Resolved issues and error corrections

[FIX] Calendar: fix avatar preview on hover

PR #69139

Coremasterweb

Fixed an issue in the Calendar view where hovering over a responsible person could show a default camera image instead of the correct avatar. This restores the expected visual preview and helps users quickly identify people in the calendar sidebar.

Original PR description

delete redundant '}' added by another developer by accident

taskid: 2504659

#calendar#avatars#hover#user interface

[FIX] project : onboarding tour message name

PR #70219

Other(25)

Miscellaneous changes

[FIX] web: js_transpiler accepts object exports containing comments

PR #69407

Coremasterweb

Documents a known limitation in Odoo's web JavaScript tooling around exported objects that contain comments. This helps developers avoid patterns that can cause generated code to be incorrect, reducing troubleshooting time for web customizations.

Original PR description

Before this commit, the js_transpiler did not convert object exports containing a comment. This commit will modify the regex EXPORT_OBJECT_RE and EXPORT_FROM_RE so that they match all characters…

Before this commit, the js_transpiler did not convert object exports
containing a comment.

This commit will modify the regex EXPORT_OBJECT_RE and EXPORT_FROM_RE
so that they match all characters between { and }.

Example:
```js
export {
    a // this is a comment
}

export {
    a // this is a comment
}
```

Output before this commit (no modification is applied)
```js
export {
    a // this is a comment
}

export {
    a // this is a comment
} from "@addon/path"
```

Output after this commit

```js
Object.assign(__exports, {
        a // this is a comment
        })

{const {
        a // this is a comment
        } = require("@addon/path");Object.assign(__exports, {
        a // this is a comment
        })};
```

Limitation:
It is still impossible to have a comment containing `}` inside
an exported object. The js_tranpiler will generate wrong code
if this happens.

Example:
```js
export {
    a // this is a comment with }
}
```

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

taskid: 2491161 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Instead of thread viewer having many dependencies, this allows models "having the thread viewer feature" to keep their own logic for themselves. The "create or update" part has to be done manually in this case (as opposed to using "insert") because thread viewer has no clear identifying data, since it would depend on which model is using it in the first place.

Before this commit, the js_transpiler did not convert object exports containing a comment. This commit will modify the regex EXPORT_OBJECT_RE and EXPORT_FROM_RE so that they match all characters between { and }. Example: ```js export { a // this is a comment } export { a // this is a comment } ``` Output before this commit (no modification is applied) ```js export { a // this is a comment } export { a // this is a comment } from "@addon/path" ``` Output after this commit ```js Object.assign(__exports, { a // this is a comment }) {const { a // this is a comment } = require("@addon/path");Object.assign(__exports, { a // this is a comment })}; ``` Limitation: It is still impossible to have a comment containing `}` inside an exported object. The js_tranpiler will generate wrong code if this happens. Example: ```js export { a // this is a comment with } } ``` Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Previously, when toggling on background shapes, they always had the default colours. In 1e30bce81eb8deb732747f8964ebd7fcd78c802c we made it so that when you toggle on a shape on a section, it would automatically reuse the colors of the surrounding shapes if any. Unfortunately, when the "implicit" colors were also the default colors, they were still marked on the shape, and it got an explicit background image that would no longer react to changes in the palette. This was caused by the fact that the call to _getDefaultColors returns an empty object when the section doesn't already have a shape-container, this was not a problem before since we were not passing in any colors when creating the initial shape previously, the the aforementioned change made it so that we did. This commit fixes the issue by creating the shape-container before calling the method that will set the colors on the shape, this way getDefaultColors works as expected, and the colors are not marked on the section when they are the default ones, restoring the ability of the shape colors to adapt to the palette task-2500607 Co-authored-by: Tom De Caluwé <tdc@odoo.com> Forward-Port-Of: odoo/odoo#68893

When changing the product price precision, this can lead to incorrect stock valuations. To reproduce the error: (Enable debug mode) 1. Go to Settings > Technical > Database Strucutre > Decimal Accuracy 2. Edit Product Price: - Digits: 4 3. Create a Product Category PC: - Costing Method: FIFO 4. Create a Product P: - Product Type: Storable Product - Product Category: PC 5. Create a RfQ with product P: - Quantity: 1000 - Unit Price: 0.035 6. Confirm Order, Receive Products, Validate 7. Click on Valuation Error: The total value is equal to $40 instead of $35. The calculation was done after rounding the unit price: $0.035 becomes $0.04, then 1000*0.04=$40. When confirming the RfQ, a stock move is created. To do so, the method `_get_stock_move_price_unit` is called. When validating the delivery, it recomputes the unit price thanks to method `_get_price_unit`. In both situation, and if the line has taxes, the method `compute_all` is called like this: ```python price_unit = line.taxes_id.with_context(round=False).compute_all(price_unit, currency=line.order_id.currency_id, quantity=1.0)['total_void'] ``` But here is the problem. In this method, total amount is computed with this line: ```python base = currency.round(price_unit * quantity) ``` However, `quantity` is equal to 1 and the multiplication is rounded using the currency precision. As a result, `base` is equal to $0.04. Then, all computations will use this value and will be incorrect. This fix applies the real quantity so `base` will have the correct value: ``` base = currency.round(price_unit * quantity) = currency.round(0.035 * 1000) = 35 ``` OPW-2472192 Forward-Port-Of: odoo/odoo#70080 Forward-Port-Of: odoo/odoo#69297

Improvements(4)

[IMP] Base: specify placeholder for company partners

[IMP] mail: add update command and use it on thread viewer

[IMP] core: speed up registry setup

[IMP] helpdesk: improve the helpdesk stages form view

Bug Fixes(4)

[FIX] Calendar: fix avatar preview on hover

[FIX] project : onboarding tour message name

Other(25)

[FIX] web: js_transpiler accepts object exports containing comments

Improvements(4)

[IMP] Base: specify placeholder for company partners

[IMP] mail: add update command and use it on thread viewer

[IMP] core: speed up registry setup

[IMP] helpdesk: improve the helpdesk stages form view

Bug Fixes(4)

[FIX] Calendar: fix avatar preview on hover

[FIX] project : onboarding tour message name

Other(25)

[FIX] web: js_transpiler accepts object exports containing comments

[MERGE] helpdesk_sale_timesheet: code cleaning

[FIX] hide optionalColumnsDropdown for signer_ids

[FW][FIX] l10n_in: Set automatically GST Treatment on invoice creation

[FW][FIX] web_editor, note: autofocus the editor on load note form view edit

[FW][FIX]repair: fix invoice deletion

[FW][FIX] stock: allow destination address change in transfer

[FW][FIX] sale_margin: avoid purchase price reset on order confirm

[FW][FIX] l10n_fr: assets update on account.account.template.csv

[FW][FIX] mrp: suggest the qty to produce instead of 0 in workorders

[FW][FIX] web_editor: update toolbar position on scroll

[FW][FIX] web_editor: fix default shapes not reacting to palette changes

[FW][FIX] stock : wrong float_compare

[FW][FIX] mrp: allow to select product w/o bom

[FW][FIX] stock_landed_costs: use the correct split method landed cost

[FW][FIX] point_of_sale: use lot's location for SML's location source

[FW][IMP] website: change some wordings in configurator features screen

[FW][FIX] crm: display right partner and action when convert lead

[FW][FIX] web_editor, *: remove some post new editor dead code

[FW][FIX] website: hide the cookie bar when entering edit mode

[FW][FIX] purchase_stock: consider product unit price precision

[FW][FIX] l10n_cl_edi: change dte template to include withholding taxes

[FW][FIX] account_reports: Traceback Trial Balance + Filter Hierarchy

[FW][FIX] mrp_workorder: pre-fill the qty to produce instead of 0

[FW]14.0 frupdate jco

[FW][FIX] delivery_dhl: make use of partner shipping address

[FW][FIX] industry_fsm_sale: compute bad amount in so when task mark as done