Thursday, May 20, 2021
17 changes · master
Enhancements to existing features
The expense app demo data now uses clearer, more realistic expense categories with updated sample expenses and reports. The cost field help text was also clarified so users can better understand fixed versus variable expense costs during demos or evaluation.
Original PR description
Currently, in the expense module, demo expense products are more specific to the expenses and label tooltip of the cost field doesn't convey proper difference between fixed and variable cost of expense products. So in this commit, replace old expense products with new expense products and recreate expenses and reports using these categories(products). it will provide better experience on demo. overwrite label tooltip of cost field in expense app to convey proper difference between fixed and variable cost of expense products. Task-id: 2491238 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mailing form in Marketing Automation now places the activities field below the source field. This small layout adjustment makes the form easier for users to understand and follow when setting up mailings.
Original PR description
This commit puts the activities field below the source field following community changes which aim at making the mailing form easier to understand by the user. Task-2469409 COM-PR: https://github.com/odoo/odoo/pull/68882
Resolved issues and error corrections
The update fixes how existing tracking links are reused when referral or social push notification links are created. This prevents confusing behavior where creating a duplicate link could unexpectedly open an existing record instead of following a clear reuse process.
Original PR description
Purpose ======= Clean the code, before the "search or create" behavior was implemented in the create, causing strange behavior (creating a link tracker with the same values as an existing one didn't raise an error, but open the form view of the existing link tracker). Task-2090344
Code cleanup and technical improvements
The Sales module's internal Python files were split and renamed to better match the business objects they manage, such as sales orders, payments, invoices, and campaigns. This does not introduce new user-facing features, but it makes the codebase clearer and easier to maintain for upcoming improvements.
Original PR description
The `sale` code is going to experience some refactorings/improvements soon, and in preparation of those tasks, we believed it was time to reorder the python files. Splitting files according to python classes, and using targeted names as file names will improve the clarity and maintainability of the module, easing the future work.
To conserve the blame history of the splitted files, the file split are done in 2+ commits.
* `account_move.py` & `account_invoice.py` -> `account.move{.line}.py`
* `payment.py` -> `payment_acquirer.py` & `payment_transaction.py`
* `sale.py` -> `sale.order{.line}.py`
* `utm.py` -> `utm_campaign.py`
Moved the `mail_compose_message.py` file to the `wizard` folder, since it targets a wizard.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prMiscellaneous changes
The requests_toolbelt package < 0.9 uses `from collections import ...` which is deprecated in python 3.8 [0]. The request_toolbelt package is not a dependency of Odoo but is needed by zeep [1]. Unfortunately, the Ubuntu python3-requests-toolbelt package is still 0.8 [2]. This commit filters out the warning. [0] https://github.com/requests/toolbelt/commit/979f95266c2044893b05cb2314e94c899915748c [1] https://packages.ubuntu.com/focal/python3-zeep [2] https://packages.ubuntu.com/focal
Original PR description
The requests_toolbelt package < 0.9 uses `from collections import ...` which is deprecated in python 3.8 [0]. The request_toolbelt package is not a dependency of Odoo but is needed by zeep [1]. Unfortunately, the Ubuntu python3-requests-toolbelt package is still 0.8 [2]. This commit filters out the warning. [0] https://github.com/requests/toolbelt/commit/979f95266c2044893b05cb2314e94c899915748c [1] https://packages.ubuntu.com/focal/python3-zeep [2] https://packages.ubuntu.com/focal/python3-requests-toolbelt Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70137
If a MO is validated with all of its (component) move_raw_ids.quality_done = 0, then when trying to validate the nonsensical "The quantity to produce must be positive" validation error will occur. This is due to all move_raw_ids being marked as Cancelled, which auto-updates the MO state to cancelled, which prevents the validation from properly completing. To avoid this error, we prevent the user from having 0 consumption for all components. Task: 2422698 Related (v13 fix + bug descr
Original PR description
If a MO is validated with all of its (component) move_raw_ids.quality_done = 0, then when trying to validate the nonsensical "The quantity to produce must be positive" validation error will occur. This is due to all move_raw_ids being marked as Cancelled, which auto-updates the MO state to cancelled, which prevents the validation from properly completing. To avoid this error, we prevent the user from having 0 consumption for all components. Task: 2422698 Related (v13 fix + bug description) Task: 2463893 ENT PR (test fixes): odoo/enterprise#18355 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70900
**Description of the issue/feature this PR addresses:** Fixes a recursion error and data inconsistency resulting from the update of quantities for the components of a kit product from a kit variant. **Steps to reproduce the error:** With stock locations activated: - Create and configure a storable product with two variants (kit). - Create a storable product (component). - Create the BoM for the kit and add the component in the BoM Lines. - From the kit template, navigate to one of the ki
Original PR description
**Description of the issue/feature this PR addresses:** Fixes a recursion error and data inconsistency resulting from the update of quantities for the components of a kit product from a kit variant.…
**Description of the issue/feature this PR addresses:** Fixes a recursion error and data inconsistency resulting from the update of quantities for the components of a kit product from a kit variant. **Steps to reproduce the error:** With stock locations activated: - Create and configure a storable product with two variants (kit). - Create a storable product (component). - Create the BoM for the kit and add the component in the BoM Lines. - From the kit template, navigate to one of the kit variants and click on Update Quantity. - Add new quantities for the component. - Try to go back to the product and you will get the error. **Current behavior before PR:** When updating the quantities available for a product, an inventory move is generated without setting the product_tmpl_id, as this field is related to the product_id of the move. However, when creating the move, Odoo will consider it a default missing value and will try to fill it in the method default_get. The problem when dealing with kits is that the products available to update their quantities are the components of the kit. When navigating to a variant and updating the quantities of a component of the kit variant, the default product template in the context will be the kit template. This is causing that, when generating the inventory move, the move is created with product_id of the component, and product_tmpl_id of the kit template. This issue creates a critical data inconsistency as the component's template is set to the kit's template, which apart from making no sense generates a recursion error. **Desired behavior after PR is merged:** By preventing setting a default product template when the action to create/update quants is triggered for kit products, we prevent writing a wrong template. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71037
Before this commit, Share action was displayed on list view as well which doesn't makes sense as it will always use `active_id` only. With this commit, we are displaying `Share` action on form view only. OPW 2530652 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70821
Original PR description
Before this commit, Share action was displayed on list view as well which doesn't makes sense as it will always use `active_id` only. With this commit, we are displaying `Share` action on form view only. OPW 2530652 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70821
Before this commit, we use the 'product.product_category_3' external_xmlid to find the 'Services' category but this record is in fact a demo data. This commit removes this using to create a new category called 'Services' for the product created in this test. Related PR: #65146 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70730
Original PR description
Before this commit, we use the 'product.product_category_3' external_xmlid to find the 'Services' category but this record is in fact a demo data. This commit removes this using to create a new category called 'Services' for the product created in this test. Related PR: #65146 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70730
The web editor does not work well with the e-learning fullscreen view. It actually completely closes the fullscreen view and opens the edition on a blank page. To avoid this, we intercept the click on the 'edit' button and redirect to the non-fullscreen view of this slide with the editor enabled, whose layout is more suited to edit in-place anyway. A small testing tour was added to ensure this behavior is kept. Task-2507179 Description of the issue/feature this PR addresses: C
Original PR description
The web editor does not work well with the e-learning fullscreen view. It actually completely closes the fullscreen view and opens the edition on a blank page. To avoid this, we intercept the click on the 'edit' button and redirect to the non-fullscreen view of this slide with the editor enabled, whose layout is more suited to edit in-place anyway. A small testing tour was added to ensure this behavior is kept. Task-2507179 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71025 Forward-Port-Of: odoo/odoo#69363
The value taken into account in the SQL for the calculation were wrong: - Not based on the state of the invoices (cancelled and draft were taken into account) - Had the tax included opw-2464004 feedback-2478356 Forward-Port-Of: odoo/odoo#70592 Forward-Port-Of: odoo/odoo#70536
Original PR description
The value taken into account in the SQL for the calculation were wrong: - Not based on the state of the invoices (cancelled and draft were taken into account) - Had the tax included opw-2464004 feedback-2478356 Forward-Port-Of: odoo/odoo#70592 Forward-Port-Of: odoo/odoo#70536
-If the Service Invoicing Policy of the product is Prepaid or Milestones then the project with Billable active will also appear and create a task by product. -If service_policy changes, the project field will be empty. TaskID-2522084 Forward-Port-Of: odoo/odoo#71083 Forward-Port-Of: odoo/odoo#70609
Original PR description
-If the Service Invoicing Policy of the product is Prepaid or Milestones then the project with Billable active will also appear and create a task by product. -If service_policy changes, the project field will be empty. TaskID-2522084 Forward-Port-Of: odoo/odoo#71083 Forward-Port-Of: odoo/odoo#70609
The "Accept Terms & Conditions" toggle had been mistakenly removed from the "Customize" tab by commit 573ed74. task-2494916 Forward-Port-Of: odoo/odoo#71045
Original PR description
The "Accept Terms & Conditions" toggle had been mistakenly removed from the "Customize" tab by commit 573ed74. task-2494916 Forward-Port-Of: odoo/odoo#71045
Currently, create a service product and select a project or a project template from the 'sales' tab, it is not possible to select projects with allow_timesheets = false So in this commit, the domain of the project_id and the project_template_id fields should include projects for which allow_timesheets is false except if the 'Timesheets on tasks' option is selected as a service_policy Related PR: odoo/odoo#70609 Task-ID: #2522084 Forward-Port-Of: odoo/enterprise#18415
Original PR description
Currently, create a service product and select a project or a project template from the 'sales' tab, it is not possible to select projects with allow_timesheets = false So in this commit, the domain of the project_id and the project_template_id fields should include projects for which allow_timesheets is false except if the 'Timesheets on tasks' option is selected as a service_policy Related PR: odoo/odoo#70609 Task-ID: #2522084 Forward-Port-Of: odoo/enterprise#18415
Add a missing `sudo()` in `retry_ocr`. Bug introduced in 75fab554980. Forward-Port-Of: odoo/enterprise#18405
Original PR description
Add a missing `sudo()` in `retry_ocr`. Bug introduced in 75fab554980. Forward-Port-Of: odoo/enterprise#18405
Some enterprise level tests were incorrectly not consuming any of their components. This leads to broken tests when adding in a community check that prevents 0 component consumption in MOs. COM PR: odoo/odoo#70900 Forward-Port-Of: odoo/enterprise#18355
Original PR description
Some enterprise level tests were incorrectly not consuming any of their components. This leads to broken tests when adding in a community check that prevents 0 component consumption in MOs. COM PR: odoo/odoo#70900 Forward-Port-Of: odoo/enterprise#18355
Forward-Port-Of: odoo/enterprise#18397
Original PR description
Forward-Port-Of: odoo/enterprise#18397