Friday, May 21, 2021
4 changes · master
Resolved issues and error corrections
SMS notifications now use the same phone number selection logic across standard and advanced messaging features. This reduces duplicated setup in CRM and related apps, helping messages reach the right contact numbers more consistently.
Original PR description
There are two mixin involved in SMS notifications * mail.thread: standard SMS sending capabilities; * mail.thread.phone: advanced use with support of blacklist; Both require to define fields to use when searching for phone numbers (generally phone and/or mobile). Those are ``_sms_get_number_fields`` for mail.thread standard implementation (in SMS module) and ``_phone_get_number _fields`` for mail.thread.phone advanced implementation (in phone_validation module). In this commit we make mail.thread.phone act like a more advanced version of mail.thread by making _sms_get_number_fields use result of _phone_get_number _fields, and not the inverse. It allows to remove some overrides notably in CRM having to define twice fields. Task ID-2528169
Mass mailing subject and preview fields are no longer marked as translatable, avoiding the misleading impression that each recipient will automatically see them in their own language. Users who need different languages should create separate mailings for each target audience, such as by language or country.
Original PR description
Having those fields as translatable lead people to think those will be translated into recipient's language. This is incorrect as translations in Odoo are based on current user, not about any recipient who would see the field value. In this commit we therefore remove translation capabilities for subject and preview. Indeed mailings currently offer no multi languages support. Instead people should create separate mailings targetting some specific recipients, based on lang or country for example. Task ID-2535807
This fix updates localized invoice report templates to use the current rendering approach required by a recent platform change. It helps keep German and Latin American invoice documents displaying correctly without changing business workflows.
Original PR description
Needed after https://github.com/odoo/odoo/commit/01875541b1a8131cb0c5459f18670e9a97713135 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A test in the marketing automation area was updated to match the current way phone fields are handled. This helps keep automated checks reliable and reduces the risk of false test failures during future changes.
Original PR description
Task ID-2528169