Tuesday, June 1, 2021
5 changes · master
Resolved issues and error corrections
The timesheet grid now keeps the employee overtime indicator in the correct position after an underlying avatar display change. This preserves the expected layout and avoids visual misalignment for users reviewing timesheets.
Original PR description
Before this commit, the `Many2OneAvatar` widget has recently been changed to add a div in its template. This changes impacted the `TimesheetM2OAvatarEmployee` widget in `timesheet_grid` module because this widget uses `Many2OneAvatar` widget in intern and then the positioning of the elements in the `TimesheetM2OAvatarEmployee` widget has changed. This commit changes the position of the overtime indication we add it in the new div created in the `Many2OneAvatar` to keep the initial behavior and alignment. Related PR: odoo/odoo#67366 Community PR: odoo/odoo#71461
Miscellaneous changes
filter_analytic_accounts/filter_analytic_tags are declared on 'self' only when using financial reports. If we tried to open a report being not a financial report but using the analytic filters, it leads to a KeyError: 'analytic_accounts'. This is because '_init_filter_analytic_accounts' is not executed since there is no existing filter 'filter_analytic_accounts' but 'filter_analytic'. Introduced by: https://github.com/odoo/enterprise/commit/1f325e84740aac6a686cd6df4cf9b9ff5d4edc8e Forward
Original PR description
filter_analytic_accounts/filter_analytic_tags are declared on 'self' only when using financial reports. If we tried to open a report being not a financial report but using the analytic filters, it leads to a KeyError: 'analytic_accounts'. This is because '_init_filter_analytic_accounts' is not executed since there is no existing filter 'filter_analytic_accounts' but 'filter_analytic'. Introduced by: https://github.com/odoo/enterprise/commit/1f325e84740aac6a686cd6df4cf9b9ff5d4edc8e Forward-Port-Of: odoo/enterprise#18580 Forward-Port-Of: odoo/enterprise#18560
Issue - Install "Subscriptions" module - Activate "Discount" feature in settings - Go to "Subscription" and create a new one - Set "Azure" as customer - Set "Start date" to 02/01/2021 - Set "Date of Next Invoice" to 02/01/2022 - Add product "Office Cleaning Subscription (Yearly)" - Save then move state to "TO UPSELL" - Click on "Upsell" button - Add product "Office Cleaning Subscription (Yearly)" and create quotation - In order line, remove discount value - Confirm
Original PR description
Issue - Install "Subscriptions" module - Activate "Discount" feature in settings - Go to "Subscription" and create a new one - Set "Azure" as customer - Set "Start date" to 02/01/2021 - Set "Date of…
Issue - Install "Subscriptions" module - Activate "Discount" feature in settings - Go to "Subscription" and create a new one - Set "Azure" as customer - Set "Start date" to 02/01/2021 - Set "Date of Next Invoice" to 02/01/2022 - Add product "Office Cleaning Subscription (Yearly)" - Save then move state to "TO UPSELL" - Click on "Upsell" button - Add product "Office Cleaning Subscription (Yearly)" and create quotation - In order line, remove discount value - Confirm and create Invoice In invoice lines description, the invoicing period is wrong. Cause The invoicing period is calculated by taking the ratio of the discount since this period is not stored on the line. Solution When creating quotation, display invoicing period on the order line, so we can use it in the invoice. If no invoicing period message, fallback on discount (for compatibility). opw-2517923 Forward-Port-Of: odoo/enterprise#18599 Forward-Port-Of: odoo/enterprise#18210
- After the PR #69026 the parameter `two_steps_sec` has been removed from `sale.subscription`:`do_payment`. Forward-Port-Of: odoo/enterprise#18398
Original PR description
- After the PR #69026 the parameter `two_steps_sec` has been removed from `sale.subscription`:`do_payment`. Forward-Port-Of: odoo/enterprise#18398
…ntries" Go to any financial report in debug mode. Open any popup (the far right column) and click on "View Journal Entries" => traceback Introduced by: https://github.com/odoo/enterprise/commit/23437092d780081a294750f5d18a3a8dd20b772c issue: 2539727 Forward-Port-Of: odoo/enterprise#18606
Original PR description
…ntries" Go to any financial report in debug mode. Open any popup (the far right column) and click on "View Journal Entries" => traceback Introduced by: https://github.com/odoo/enterprise/commit/23437092d780081a294750f5d18a3a8dd20b772c issue: 2539727 Forward-Port-Of: odoo/enterprise#18606