Tuesday, June 8, 2021
18 changes · master
Enhancements to existing features
Messages and notifications will no longer assume the current date when no date was supplied. This prevents misleading timestamps across mail, SMS, and postal mail notifications, improving clarity for users reviewing communications.
Original PR description
We should not assume that the default date of the message is now. A message should only have a date when it's coming from the database that supply it.
Resolved issues and error corrections
The purchase agreement screen no longer offers a separate Purchase Orders action that could create requests for quotation in inappropriate agreement states. This helps buyers follow the intended process and avoids quotations being created without the usual links or visibility from the agreement.
Original PR description
Delete purchase orders action on purchase agreements (PA)  On this document have New Quotation button which will create RFQ and can create when PA's state is Ongoing, Confirmed, Bid Selection  and Purchase orders action will create RFQ with all PA's state, this is my video  My reason should delete this action 1. RFQ should create when PA's state is Ongoing, Confirmed, Bid Selection 2. If create RFQ with this action and PA's state = draft, No have smart button link to RFQ -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
We check if the mimetype is supported when uploading an image. task-2523574 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70619
Original PR description
We check if the mimetype is supported when uploading an image. task-2523574 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70619
This fixes a minor internal warning shown when rendering abbreviated weekdays. It helps keep the web interface cleaner for developers and avoids unnecessary noise without changing how users interact with the calendar-related display.
Original PR description
Not sure this is correct but it seems about right? `weekdaysShort` is a simple array of weekday name abbreviations: https://github.com/odoo/odoo/blob/8e299ec4b257c2d87e60cdc4d97a0dbd0c77543c/addons/web/static/src/js/widgets/week_days.js#L49-L59
Currently there is an action_assign_serial_show_details button within the detailed operations form of a serial tracked product move. Unfortunately there is no way to undo the assigning/creating of move lines from this action (including via clicking the "Discard" button). This can lead to a lot of manual work (e.g. 500 SNs produced instead of 50) to remove unwanted move lines. To remedy this, we add in a button to unlink all of the move's move lines whenever the Assign Serial Numbers butto
Original PR description
Currently there is an action_assign_serial_show_details button within the detailed operations form of a serial tracked product move. Unfortunately there is no way to undo the assigning/creating of move lines from this action (including via clicking the "Discard" button). This can lead to a lot of manual work (e.g. 500 SNs produced instead of 50) to remove unwanted move lines. To remedy this, we add in a button to unlink all of the move's move lines whenever the Assign Serial Numbers button is visible. Task: 2426281 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71156
- before this commit, it was raising an error when trying to install the l10n_in module, due to unavailability of report element - after this commit, l10n_in module can be installed successfully -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71840
Original PR description
- before this commit, it was raising an error when trying to install the l10n_in module, due to unavailability of report element - after this commit, l10n_in module can be installed successfully -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71840
On safari in saas-14.2, opening the full mail editor cause an error: Traceback: Error: The string did not match the expected pattern. matches@[native code] getMatchedCSSRules This is happening because this cause an error in safari: document.body.matches(".custom-range::-webkit-slider-thumb"); and we get selector with :: that we should ignore because in d50c3b07f1 we use a global regex with `test` and multiple call of the regex on the same string iterates over the string, for
Original PR description
On safari in saas-14.2, opening the full mail editor cause an error:
Traceback: Error: The string did not match the expected pattern.
matches@[native code]
getMatchedCSSRules
This is happening because this cause an error in safari:
document.body.matches(".custom-range::-webkit-slider-thumb");
and we get selector with :: that we should ignore because in d50c3b07f1
we use a global regex with `test` and multiple call of the regex on the
same string iterates over the string, for example:
var x = /a/g;
[x.test('a'), x.test('a'), x.test('a')]
gives [true, false, true]
opw-2489730
opw-2489515
opw-2502066
opw-2504051
opw-2518635
opw-2532695
Forward-Port-Of: odoo/odoo#71819Description of the issue/feature this PR addresses: some conditions in time helpers are wrong for getting the date/time formats. Current behavior before PR: some conditions in time helpers are wrong for getting the date/time formats. Desired behavior after PR is merged: corrected and tested -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71855
Original PR description
Description of the issue/feature this PR addresses: some conditions in time helpers are wrong for getting the date/time formats. Current behavior before PR: some conditions in time helpers are wrong for getting the date/time formats. Desired behavior after PR is merged: corrected and tested -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71855
The user_type_id field seems a bit out of place at the moment in the header of the form view. We will move it to the accounting tab with other fields in order to improve that. Task id #2563472 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71863
Original PR description
The user_type_id field seems a bit out of place at the moment in the header of the form view. We will move it to the accounting tab with other fields in order to improve that. Task id #2563472 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#71863
Forward-Port-Of: odoo/enterprise#18813 Forward-Port-Of: odoo/enterprise#18804
Original PR description
Forward-Port-Of: odoo/enterprise#18813 Forward-Port-Of: odoo/enterprise#18804
before this commit, - Terms and Condition in invoice can be false and it was converting it to plaintext so N/A will never appear - Payment term note is considering tags in text after this commit, - now it will take N/A if there is no terms in invoice - payment terms will be converted to plain text Forward-Port-Of: odoo/enterprise#18807
Original PR description
before this commit, - Terms and Condition in invoice can be false and it was converting it to plaintext so N/A will never appear - Payment term note is considering tags in text after this commit, - now it will take N/A if there is no terms in invoice - payment terms will be converted to plain text Forward-Port-Of: odoo/enterprise#18807
The current generation of a tax closing entry for a period without values could cause issues. This will be changed to ensure its proper working. Forward-Port-Of: odoo/enterprise#18752 Forward-Port-Of: odoo/enterprise#18635
Original PR description
The current generation of a tax closing entry for a period without values could cause issues. This will be changed to ensure its proper working. Forward-Port-Of: odoo/enterprise#18752 Forward-Port-Of: odoo/enterprise#18635
What are the steps to reproduce your issue ? 1. Go to Payroll/Work Entries 2. Filter on employee with no conflict (Keith Byard) 3. Generate Payslip What is currently happening ? Warning message: "Some work entries could not be validated." What are you expecting to happen ? Generate payslip correctly Why is this happening ? Because server takes in any case all the employees How to fix the bug ? Send the domain to the server opw-2550749
Original PR description
What are the steps to reproduce your issue ?
1. Go to Payroll/Work Entries
2. Filter on employee with no conflict (Keith Byard)
3. Generate Payslip
What is currently happening ?
Warning message: "Some work entries could not be validated."
What are you expecting to happen ?
Generate payslip correctly
Why is this happening ?
Because server takes in any case all the employees
How to fix the bug ?
Send the domain to the server
opw-2550749
Forward-Port-Of: odoo/enterprise#18809
Forward-Port-Of: odoo/enterprise#18681On installation of the module `l10n_es_reports`, the field `l10n_es_reports_mod349_available` gets computed for all existing invoices, and if there are thousands of them it can take a while. In the case of the upgrade request #8578, it was taking more than 72 hours for all invoices, and counting. Using raw SQL, it's a matter of seconds to set this computed field. upg-8578 Forward-Port-Of: odoo/enterprise#18820
Original PR description
On installation of the module `l10n_es_reports`, the field `l10n_es_reports_mod349_available` gets computed for all existing invoices, and if there are thousands of them it can take a while. In the case of the upgrade request #8578, it was taking more than 72 hours for all invoices, and counting. Using raw SQL, it's a matter of seconds to set this computed field. upg-8578 Forward-Port-Of: odoo/enterprise#18820
Forward-Port-Of: odoo/enterprise#18802 Forward-Port-Of: odoo/enterprise#18796
Original PR description
Forward-Port-Of: odoo/enterprise#18802 Forward-Port-Of: odoo/enterprise#18796
Forward-Port-Of: odoo/enterprise#18665
Original PR description
Forward-Port-Of: odoo/enterprise#18665
Open a graph view in debug mode in studio Click on the "XML" button to see the arch Before this commit there was a crash because we passed the "mode" to the graphRenderer, which at this point was set to "readonly". After this commit, the right props are computed for the right Component because it can be either an EditorMixinOwl, or an OwlRenderer task-2497254 Forward-Port-Of: odoo/enterprise#18817
Original PR description
Open a graph view in debug mode in studio Click on the "XML" button to see the arch Before this commit there was a crash because we passed the "mode" to the graphRenderer, which at this point was set to "readonly". After this commit, the right props are computed for the right Component because it can be either an EditorMixinOwl, or an OwlRenderer task-2497254 Forward-Port-Of: odoo/enterprise#18817
latam task 556 --- We were not able to do dummy local validation of electronic invoices. We found that the problem was related to the order that the account.move is processed: 1. we try to post the AR electronic invoice in Odoo first. 2. if everything is ok then we validate it in AFIP. Since in the Odoo the invoice post() method is computing the invoice name then we are also trying to connect to AFIP to get the last invoice number that will be used to set this value. Adding a call
Original PR description
latam task 556 --- We were not able to do dummy local validation of electronic invoices. We found that the problem was related to the order that the account.move is processed: 1. we try to post the AR electronic invoice in Odoo first. 2. if everything is ok then we validate it in AFIP. Since in the Odoo the invoice post() method is computing the invoice name then we are also trying to connect to AFIP to get the last invoice number that will be used to set this value. Adding a call to _is_dummy_afip_validation() method in the method that gets the last sequence of the invoice to resolve the problem. Forward-Port-Of: odoo/enterprise#18586