Odoo Changelog — 2021-06-17

Thursday, June 17, 2021

5 changes · master

Bug Fixes(5)

Resolved issues and error corrections

[FIX] website: share snippet bug is fixed.

PR #71985

Coremasterwebsitewebsite_eventMedium

The website sharing snippet now sends both the page title and link when users share through WhatsApp, and it works better across desktop and mobile. Social sharing icons on event pages are also aligned more consistently, improving the appearance of event sidebars.

Original PR description

PURPOSE

   1. whats-app option was not working properly in
      share snippet and On click, Whats-app opens
      but only sends the text without link of
      shared record.

   2. in the social share template Buttons aren't
      centred.

SPECIFICATION

in this commit, on whats-app share button link
replace the old link (whatsapp://send?text=) with
new one (https://web.whatsapp.com/send?text=) and
in share snippet add one condition for shared record
URL. For button displayed properly centred remove the 
display: inline-block property of button.

Task Id: 2557077

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#whatsapp#social sharing#events#website

[FIX] base: avoid crash due to generation of key with model

PR #72238

CoremasterbaseMedium

This fixes a crash that could stop certain Odoo apps, such as Website and Timesheets-related sales features, from installing in development mode. The change avoids creating invalid internal identifiers when views are linked to models with dots in their names, improving installation reliability without changing user-facing features.

Original PR description

Until now, when you create a view of type qweb with a model, we use the model
as first part to generate the key. Since this model can contains dot, it is
wrong and we got some key like ir.ui.view.gen_key_xyz

This bug has been seen with commit ee8756b31186f2f21e9b70e124f29c678cebaea7
which make the installation of website & sale_timesheet impossible in dev mode.

  File /home/odoo/addons/base/models/ir_ui_view.py, line 294, in _compute_arch
    arch_fs = get_view_arch_from_file(fullpath, xml_id)
  File /home/odoo/addons/base/models/ir_ui_view.py, line 166, in get_view_arch_from_file
    module, view_id = xmlid.split('.')

  Too many values to unpack

Now we never try to make key beautiful. At first view it doesn't bring any
advantage, but only bug.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#installation#views#development-mode

[FIX][IMP] account,*: clean fpos taxes management

PR #71591

Coremasteraccountdeliverypoint_of_salepurchaserepairsalesale_couponsale_purchasewebsite_salewebsite_sale_deliveryMedium

This update improves how taxes are selected when products are used across multiple companies, preventing taxes from one company from affecting documents in another. It also corrects point-of-sale amount recalculations and removes unnecessary duplicate tax filtering, helping invoices, orders, deliveries, repairs, and online sales apply the right taxes more reliably.

Original PR description

Task-ID: 2486056
Enterprise: https://github.com/odoo/enterprise/pull/18670

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#taxes

[FIX] *: search_view_id expects an id/name pair

PR #72247

Coremasteraccounthr_holidaysmembershippoint_of_saleproduct_marginwebsite_sale

This fixes cases where Odoo ignored a requested search view and fell back to the default one. Users in affected areas should now see the intended filters and search layout more reliably.

Original PR description

Passing an id directly to `search_view_id` is not working. It is silently
ignored.
The framework js code expects an id/name pair, as described in the ORM doc.

Most of the time, this will be unoticed as the specified search view being
ignored, the default one will be used instead, which is often the same one as
there is only one search view.

Only 3 occurences are real misbehavior.

Note that the `name` of the pair is useless, you can just pass the ID in an
array.

Working:
'search_view_id': [123, 'search'],
'search_view_id': [123],

Not working:
'search_view_id': 123,

**Technical explanation:**
It will silently just ignore the value set to `search_view_id` in Javascript [here](https://github.com/odoo/odoo/blame/master/addons/web/static/src/js/chrome/action_manager_act_window.js#L424) since
```javascript
const a = 123;
const b = a && a[0]; // this is undefined
```

Noticed on https://github.com/odoo/odoo/pull/71826#discussion_r652720721

#search view

[FIX] documents_spreadsheet: fix non-deterministic test

PR #19081

Enterprisemasterdocuments_spreadsheet

This update stabilizes an automated test for the Documents Spreadsheet area that was failing unpredictably during validation. It helps keep release checks dependable without changing user-facing behavior.

Original PR description

The test introduced in 8e3dd4f fails randomly on runbot. I couldn't reproduce it
locally.
This commit attempts to fix the issue.
QUnit tests have run more than 100x with this commit on runbot without failing.
Hopefully, it's ok now :)

https://runbot.odoo.com/web/#cids=1&id=1811&model=runbot.build.error&view_type=form&menu_id=

#tests#stability#documents

PURPOSE 1. whats-app option was not working properly in share snippet and On click, Whats-app opens but only sends the text without link of shared record. 2. in the social share template Buttons aren't centred. SPECIFICATION in this commit, on whats-app share button link replace the old link (whatsapp://send?text=) with new one (https://web.whatsapp.com/send?text=) and in share snippet add one condition for shared record URL. For button displayed properly centred remove the display: inline-block property of button. Task Id: 2557077 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Until now, when you create a view of type qweb with a model, we use the model as first part to generate the key. Since this model can contains dot, it is wrong and we got some key like ir.ui.view.gen_key_xyz This bug has been seen with commit ee8756b31186f2f21e9b70e124f29c678cebaea7 which make the installation of website & sale_timesheet impossible in dev mode. File /home/odoo/addons/base/models/ir_ui_view.py, line 294, in _compute_arch arch_fs = get_view_arch_from_file(fullpath, xml_id) File /home/odoo/addons/base/models/ir_ui_view.py, line 166, in get_view_arch_from_file module, view_id = xmlid.split('.') Too many values to unpack Now we never try to make key beautiful. At first view it doesn't bring any advantage, but only bug. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Passing an id directly to `search_view_id` is not working. It is silently ignored. The framework js code expects an id/name pair, as described in the ORM doc. Most of the time, this will be unoticed as the specified search view being ignored, the default one will be used instead, which is often the same one as there is only one search view. Only 3 occurences are real misbehavior. Note that the `name` of the pair is useless, you can just pass the ID in an array. Working: 'search_view_id': [123, 'search'], 'search_view_id': [123], Not working: 'search_view_id': 123, **Technical explanation:** It will silently just ignore the value set to `search_view_id` in Javascript [here](https://github.com/odoo/odoo/blame/master/addons/web/static/src/js/chrome/action_manager_act_window.js#L424) since ```javascript const a = 123; const b = a && a[0]; // this is undefined ``` Noticed on https://github.com/odoo/odoo/pull/71826#discussion_r652720721

The test introduced in 8e3dd4f fails randomly on runbot. I couldn't reproduce it locally. This commit attempts to fix the issue. QUnit tests have run more than 100x with this commit on runbot without failing. Hopefully, it's ok now :) https://runbot.odoo.com/web/#cids=1&id=1811&model=runbot.build.error&view_type=form&menu_id=