This fixes an issue where actions opened in pop-up dialogs could unexpectedly change the browser page title. The main page title now stays stable when users work in dialogs, reducing confusion and keeping navigation context clear.

Before this commit, all actions, even those executed in target
"new" (i.e. in dialogs) updated the document's title. Actions in
dialog should not do that.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Description of the issue/feature this PR addresses: after the last update in 4/6/2021 the receipt printing not working in offline mode Current behavior before PR: printing receipt not working in offline mode Desired behavior after PR is merged: add exception for "XmlHttpRequestError", to make the receipt printing available for offline mode -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72240

Description of the issue/feature this PR addresses:
after the last update in 4/6/2021 the receipt printing not working in offline mode
Current behavior before PR:
printing receipt not working in offline mode
Desired behavior after PR is merged:
add exception for "XmlHttpRequestError", to make the receipt printing available for offline mode

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#72240

Issue - Install 'addons/website_crm_partner_assign' module - Create a partner X without a phone number (edit only name). - Save and click on "Opportunities" stat button - Create an opportunity Y and set X as customer - Edit it and set "Joel Willis" as assigned partner - Logout then login with portal user (Joel Willis) - Go to "My account" page and click on "Opportunities" - Select the opportunity Y and edit "Contact" - Change phone number then save Access error message.

Issue

	- Install 'addons/website_crm_partner_assign' module
	- Create a partner X without a phone number (edit only name).
	- Save and click on "Opportunities" stat button
	- Create an opportunity Y and set X as customer
	- Edit it and set "Joel Willis" as assigned partner
	- Logout then login with portal user (Joel Willis)
	- Go to "My account" page and click on "Opportunities"
	- Select the opportunity Y and edit "Contact"
	- Change phone number then save

	Access error message.

Cause

	When editing the opportunity (OPP) phone (or email_from) field,
	if a partner is linked to the OPP and the phone is different,
	we will update also the phone of the partner.
	User portal is not allowed to edit phone partner.

Solution

	Override `_inverse_phone` and `_inverse_email_from`:
	If assigned partner on opportunity is same
	as env.user commercial partner, then use
	sudo() on lead.partner_id to update phone or email_from.

opw-2530744

Forward-Port-Of: odoo/odoo#71497

The tour bubble "animation" that makes it to bounce up and down can cause issues when its position is at the edge of the bottom of the screen. In the sale tour, this would make the window constantly resize to show a scrollbar and then resize to hide the scrollbar, creating quite a sickening effect visually. Task-Id: 2480195 Forward-Port-Of: odoo/odoo#68391

The tour bubble "animation" that makes it to bounce up and down can cause
issues when its position is at the edge of the bottom of the screen.

In the sale tour, this would make the window constantly resize to show a
scrollbar and then resize to hide the scrollbar, creating quite a sickening
effect visually.

Task-Id: 2480195

Forward-Port-Of: odoo/odoo#68391

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72419

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#72419

The media modal from the description field of an exhibitor was missing its video tab. This is because it was disabled as a rule for field_html. This adds the possibility to restore it via node option, and sets that option on the exhibitor description field. Task: 2551345 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72295

The media modal from the description field of an exhibitor was missing its video tab. This is because it was disabled as a rule for field_html. This adds the possibility to restore it via node option, and sets that option on the exhibitor description field.

Task: 2551345

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#72295

PURPOSE When writing something in signture field in stock.picking and enable signature field in listview throws traceback. SPEC Remove boolean widget on signature field. TASK 2570929 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72276

PURPOSE
When writing something in signture field in stock.picking and enable signature field in listview throws traceback.

SPEC
Remove boolean widget on signature field.

TASK 2570929



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#72276

Purpose ======= Allow to upload the attachments of the email when logging it on the partner / lead / ticket. Technical ========= The attachments posted on this new endpoint are base 64 encoded and added in the JSON data in a list (name, encoded content). Links ===== Task 2545048 See odoo/mail-client-extensions/pull/11 Forward-Port-Of: odoo/odoo#71543

Purpose
=======
Allow to upload the attachments of the email when logging it on the
partner / lead / ticket.

Technical
=========
The attachments posted on this new endpoint are base 64 encoded and
added in the JSON data in a list (name, encoded content).

Links
=====
Task 2545048
See odoo/mail-client-extensions/pull/11

Forward-Port-Of: odoo/odoo#71543

If a user has no accounting permission, when he opens/closes a POS session (without any sale), he will not be able to close the session To reproduce the error: (Use demo data) 1. Remove all Marc Demo's permissions for the Accounting module 2. Login with Marc Demo 3. Open a POS Session 4. Close the POS Session Error: "Sorry, you are not allowed to delete documents of type 'Journal Entries' (account.move) [...]" Note: if the user processes at least one order during the POS session,

If a user has no accounting permission, when he opens/closes a POS
session (without any sale), he will not be able to close the session

To reproduce the error:
(Use demo data)
1. Remove all Marc Demo's permissions for the Accounting module
2. Login with Marc Demo
3. Open a POS Session
4. Close the POS Session

Error: "Sorry, you are not allowed to delete documents of type 'Journal
Entries' (account.move) [...]"

Note: if the user processes at least one order during the POS session,
he will be able to close it thanks to sudo mode:
https://github.com/odoo/odoo/blob/369331dfdc144cf852c80c99d00ce8d5da843be1/addons/point_of_sale/models/pos_session.py#L302

OPW-2523187

Forward-Port-Of: odoo/odoo#72290
Forward-Port-Of: odoo/odoo#72032

The import logging (ish) assumes that if an exception has at least 2 args the second arg is metadata added by the callee. As it turns out, `UnicodeEncodeError` has *five* arguments, none of which is added by us. So if encoding something fails during the process (e.g. because the file contains a lone surrogate, which leads to the database insert failing when psycopg2 tries to encode the query to UTF8), then the `_log` function itself will fail, yielding a very unhelpful error of: diction

The import logging (ish) assumes that if an exception has at least 2 args the second arg is metadata added by the callee.

As it turns out, `UnicodeEncodeError` has *five* arguments, none of which is added by us. So if encoding something fails during the process (e.g. because the file contains a lone surrogate, which leads to the database insert failing when psycopg2 tries to encode the query to UTF8), then the `_log` function itself will fail, yielding a very unhelpful error of:

   dictionary update sequence element #0 has length 1; 2 is required

(because we tried to update a dict using a string).

This issue occurs only during *field conversion* and most fields have no need to interact with the database (so don't need to encode the value, which is what fails), however it is a problem when the invalid string is used as a record name to look for (e.g. an m2o).

Further improve the experience by converting the UnicodeEncodeError to a ValueError using the stringified UEE: `_log` assumes the first argument to the exception is an error message of some sort, but for UnicodeError subclasses it's just the encoding involved in the error (here `utf-8`), which doesn't really serve as an error message.

Stringifying the exception generates a complete error message which is quite a bit more helpful.

Issue 2480064

Forward-Port-Of: odoo/odoo#72473
Forward-Port-Of: odoo/odoo#72352

Resupplying a product with a purchase order ask to choose the suitable supplier to put on the purchase order. Another search is perform on top of that to compute de date to order in order to respect the lead days promise by the supplier. The issue is that the first search is done with the orderpoint company into account but not the second one. This commit passes the company to _prepare_seller when computing the total lead days required for an order. opw : Description of the issue/f

Resupplying a product with a purchase order ask to choose the suitable
supplier to put on the purchase order. Another search is perform on top
of that to compute de date to order in order to respect the lead days
promise by the supplier. The issue is that the first search is done with
the orderpoint company into account but not the second one.

This commit passes the company to _prepare_seller when computing the total
lead days required for an order.

opw :

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#72340

This commit fixes the multi_company access error when the user is attempting to see a record belonging to another company then the one he is logged in to from the plugins, it returns the company_id with the record so that the plugin uses it to make sure that the user is redirected to the record with the right company ticked. Task-2541205 PLUGIN-PR: odoo/mail-client-extensions#10 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of

This commit fixes the multi_company access error when the user is attempting to
see a record belonging to another company then the one he is logged in to from
the plugins, it returns the company_id with the record so that the plugin uses
it to make sure that the user is redirected to the record with the right
company ticked.

Task-2541205

PLUGIN-PR: odoo/mail-client-extensions#10

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#71318

Purpose ======= In 14.3 we added the possibility to upload attachments when logging an email. In the commit, we add the translation for the corresponding error message. Task 2545048 See odoo/odoo/pull/71543 See odoo/mail-client-extensions/pull/11 Forward-Port-Of: odoo/odoo#72031

Purpose
=======
In 14.3 we added the possibility to upload attachments when logging
an email. In the commit, we add the translation for the corresponding
error message.

Task 2545048
See odoo/odoo/pull/71543
See odoo/mail-client-extensions/pull/11

Forward-Port-Of: odoo/odoo#72031

Introduced with 7fb016f9966b [0] access could crash, recordset could be empty after `filtered`. Step to reproduce: - Add admin group to website top level menu (Website > Debug > Menu) - Try to access frontend as non admin opw-2573763 task-2574346 Forward-Port-Of: odoo/odoo#72514 Forward-Port-Of: odoo/odoo#72359

Introduced with 7fb016f9966b
[0] access could crash, recordset could be empty after `filtered`.

Step to reproduce:
  - Add admin group to website top level menu (Website > Debug > Menu)
  - Try to access frontend as non admin

opw-2573763
task-2574346

Forward-Port-Of: odoo/odoo#72514
Forward-Port-Of: odoo/odoo#72359

task-2522081 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70893

task-2522081





--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#70893

all auth_* modules are sensitive and changes should be monitored more carefully Forward-Port-Of: odoo/odoo#72489 Forward-Port-Of: odoo/odoo#71127

all auth_* modules are sensitive and changes should be monitored more carefully

Forward-Port-Of: odoo/odoo#72489
Forward-Port-Of: odoo/odoo#71127

In case we take the online appointment on a website belonging to company 1 and for another user that only have access to company 2, we are facing a 403 error "Access to unauthorized or invalid companies.". We should adapt the allowed_companies in the context to match those of the user linked to the employee for which we are creating the event. opw-2457536 Forward-Port-Of: odoo/enterprise#19120 Forward-Port-Of: odoo/enterprise#18795

In case we take the online appointment on a website belonging to company 1
and for another user that only have access to company 2, we are facing a
403 error "Access to unauthorized or invalid companies.". We should adapt
the allowed_companies in the context to match those of the user linked to
the employee for which we are creating the event.

opw-2457536

Forward-Port-Of: odoo/enterprise#19120
Forward-Port-Of: odoo/enterprise#18795

Fixing a text overlap caused by the horizontal option when a wizard is open (smaller than the usual form of account.asset Form view) The example I encountered the account.account module form view. <img width="1108" alt="Screen Shot 2021-06-07 at 18 31 13" src="https://user-images.githubusercontent.com/19322270/121063756-a1f78900-c7be-11eb-9e8c-aca17878b00c.png"> opw-2550761 Forward-Port-Of: odoo/enterprise#18824

Fixing a text overlap caused by the horizontal option when a wizard is open (smaller than the usual form of account.asset Form view)
The example I encountered the account.account module form view.


<img width="1108" alt="Screen Shot 2021-06-07 at 18 31 13" src="https://user-images.githubusercontent.com/19322270/121063756-a1f78900-c7be-11eb-9e8c-aca17878b00c.png">




opw-2550761

Forward-Port-Of: odoo/enterprise#18824

Bug === When we post from Odoo to Facebook or Twitter, the social media will display a preview of the link (with the title, the description and the logo of the HTML page). But when we post from Social, this preview contains only "Redirecting..." for Facebook and nothing for Twitter. The reason is that we use link tracker to register clicks on our link. Here is what happen; 1. The social user write his post with an URL and click on post 2. The SQL transaction of the social user start

Bug
===
When we post from Odoo to Facebook or Twitter, the social media will
display a preview of the link (with the title, the description and the
logo of the HTML page). But when we post from Social, this preview
contains only "Redirecting..." for Facebook and nothing for Twitter.

The reason is that we use link tracker to register clicks on our link.

Here is what happen;
1. The social user write his post with an URL and click on post
2. The SQL transaction of the social user start
3. The link tracker is created
4. A HTTP request is made to the Facebook API
5. Facebook fetch the URL we give (link tracker) to build the preview
6. The SQL transaction of Facebook start
7. We try to search the code related to the link tracker, we do not find
   it because the SQL transaction of the social user is not yet
   committed
8. End of the SQL transaction of Facebook
9. So Facebook / Twitter consider that the link redirect to nowhere
   (Facebook show "Redirecting..." as title, Twitter nothing)
10. The Facebook API return the result to our HTTP request (point 4)
11. End of the transaction of the social user all changes are committed

So because Facebook / Twitter fetch our link tracker before we commit
the current transaction, the link tracker does not exist yet for them.

N.B. LinkedIn seems to fetch the link trackers after returning the
     response, so there's no issue for this media.

Task 2294034

Forward-Port-Of: odoo/enterprise#19094

As of now, the journal is not taken into account when calculating the columns of the account lines in the consolidation report. This can lead to wrong values when having two journals using a common account. Forward-Port-Of: odoo/enterprise#19102 Forward-Port-Of: odoo/enterprise#18916

As of now, the journal is not taken into account when calculating the
columns of the account lines in the consolidation report.

This can lead to wrong values when having two journals using a common
account.

Forward-Port-Of: odoo/enterprise#19102
Forward-Port-Of: odoo/enterprise#18916

A user could not import a pivot, edit some cell then try to undo both actions. task 2575478 Co-authored-by: Pierre Rousseau <pro@odoo.com> Forward-Port-Of: odoo/enterprise#19137

A user could not import a pivot, edit some cell then try to undo both
actions.

task 2575478

Co-authored-by: Pierre Rousseau <pro@odoo.com>

Forward-Port-Of: odoo/enterprise#19137

The tour bubble "animation" that makes it to bounce up and down can cause issues when its position is at the edge of the bottom of the screen. In the sale tour, this would make the window constantly resize to show a scrollbar and then resize to hide the scrollbar, creating quite a sickening effect visually. Task-Id: 2480195 Forward-Port-Of: odoo/enterprise#17393

The tour bubble "animation" that makes it to bounce up and down can cause
issues when its position is at the edge of the bottom of the screen.

In the sale tour, this would make the window constantly resize to show a
scrollbar and then resize to hide the scrollbar, creating quite a sickening
effect visually.

Task-Id: 2480195

Forward-Port-Of: odoo/enterprise#17393