Tuesday, June 22, 2021
8 changes · master
Resolved issues and error corrections
Fixes a problem in the debug menu where choosing to disable active guided tours could crash the page. The change sends the correct tour identifiers, making this developer/debug action work reliably without interrupting the user session.
Original PR description
In the debug menu, when there is at least a tour "alive", click on "Disable tours". Before this commit, it crashed because we sent the whole tour description as argument to the consume method. Issue reported on the wowl-bugs pad. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents Odoo from crashing when certain actions contain an empty context value. It improves reliability for users opening areas such as eLearning course contents and Fleet odometer records.
Original PR description
Before this commit, calling "evaluateExpr" with the empty string as argument crashed. For instance, this happened with at least two actions in Odoo: - Elearning > Courses > Contents - Fleet > Vehicules > Odometers In both cases, the context in the action is the empty string. Issue spotted thanks to the clickEverywhere test.
Odoo now handles actions that have an empty context value without crashing. This fixes navigation problems in areas such as eLearning course contents and Fleet odometer views, improving reliability for users.
Original PR description
Before this commit, calling "makeContext" with an empty string as context description crashed. For instance, this happened with at least two actions in Odoo: Elearning > Courses > Contents Fleet > Vehicules > Odometers In both cases, the context in the action is the empty string. Issue spotted thanks to the clickEverywhere test. The crash was caused by the pyjs parser. This is correct (even though the error was not clear), since an empty list of token do not represent a valid python AST. So, the fix is to make the makeContext function more tolerant. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a delay in Odoo's web client when a new live update channel is added. Users should receive refreshed real-time updates immediately instead of waiting several seconds for polling to restart.
Original PR description
Previously, adding a new channel to the longpolling bus would abort the current longpolling request, and was supposed to immediately send a new longpolling request with the new channels, but didn't. This was caused by the fact that the code that restarts the longpolling when aborting a previous request relies on the error message of the aborted request. While rewriting the web client in owl in 0573aca, a new RPC service was written which did not reject the promise the the same error message, causing the longpoll to wait for a few seconds before sending the next request. This request fixes that by rejecting the promise with the expected error message.
This fixes a crash that could occur when users exported data to Excel from a form view. The export process now works as expected by removing an outdated leftover parameter from earlier cleanup work.
Original PR description
In commit adf34b9001eb34e, we remove unused token param. These token's parameters are still a leftover of the previous cleaning. This commit fixes the export in Xls in view form that crash with: TypeError: index() missing 1 required positional argument: 'token' Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where actions opened in pop-up dialogs could unexpectedly change the browser page title. The main page title now stays stable when users work in dialogs, reducing confusion and keeping navigation context clear.
Original PR description
Before this commit, all actions, even those executed in target "new" (i.e. in dialogs) updated the document's title. Actions in dialog should not do that. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The activities shortcut in the top menu now responds when users click it. This restores quick access to planned activities and prevents confusion from an unresponsive navigation item.
Original PR description
The activities systray item didn't work anymore. Nothing happened on click. It was because the do action event was never caught. The systray item logic had a different flow and didn't go through the ViewAdapter code. We fix this by factoring the do action code and adding a listener on window (through legacy service provider) to execute this code when the do_action bubbles up. Instead of using the legacy service provided, we could have done this in the SystrayItemAdapter, but we then have the legacy environment and would need more work for the same result.
This fixes the Odoo Studio option for adding a custom field from the optional fields menu in list views. Business users can now customize list views as expected without needing a workaround.
Original PR description
Before this commit, the "Add custom field" entry in the optional fields dropdown in list views didn't work. The code handling the "studio_icon_clicked" had been removed by the wowl refactoring [1]. This commit makes this work again. [1] https://github.com/odoo/enterprise/commit/6563c16c2b2786efdbf175ae8254e242c10a9be7