Friday, July 2, 2021
3 changes · master
Enhancements to existing features
The date range picker now shows selected start and end dates with slightly rounder corners. This small visual refinement makes selected dates easier to distinguish and improves overall clarity for users.
Original PR description
PURPOSE Increase the roundness of the start/end dates in the daterange picker for clarity. SPEC Increase start/end dates roundness from 4px to 8px. TASK 2413932 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Duplicated emails will no longer carry over the failure reason from the original email. This prevents copied draft emails from incorrectly appearing as if they had already failed to send.
Original PR description
The Failure Reason should not be copied for obvious reasons. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects minor details in how Odoo communicates with Ingenico payment terminals, including message labels, response type, keepalive timing, and message length handling. These changes are not expected to affect current users, but they help keep the integration ready for future terminal firmware behavior.
Original PR description
* Typo in IncomingIngenicoMessage class name * HelloResponse had the wrong message type, which the terminal ignores * A 5005 instead of 5 second keepalive interval was specified to the terminal, which it also ignores. * The message length is a hex field, not a BCD one. The BCD to int function converted a hex field instead of a BCD field, so it was wrong but worked. None of these have a functional impact at the moment, hence it's an IMP for master. The second and third points might become a problem in stable if the Ingenico terminal firmware updates to actually read those fields.