Monday, July 5, 2021
21 changes · master
Enhancements to existing features
This change makes custom “create” labels in stock and website sales screens available for translation. It improves the experience for users working in languages other than English by ensuring these interface labels can be localized consistently.
Original PR description
PURPOSE The option "create_text" implies that the text cannot be translated as it is passed as node options SPEC Pass create_text as field node attribute so that it is parsed by translate.py TASK 1923433 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The project share button is now visible when users are editing a project, not only when viewing it. This makes sharing project access more convenient and reduces the need to switch modes.
Original PR description
PURPOSE Share button inside project was displayed only in readonly mode. SPEC Remove oe_readonly_mode class from button. TASK 2513815 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The web layer now checks common data issues before sending requests to the server, helping developers catch mistakes earlier and avoiding confusing server error screens. It also avoids unnecessary server calls when there is nothing to read or delete, improving efficiency in simple cases.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Marketing Automation campaign interface labels are now provided in a way that Odoo's translation tools can detect. This helps users see the correct localized text when working in different languages.
Original PR description
PURPOSE The option "create_text" implies that the text cannot be translated as it is passed as node options SPEC Pass create_text as field node attribute so that it is parsed by translate.py TASK 1923433
Resolved issues and error corrections
This update prevents a supplier information view meant only for replenishment rules from appearing in the general Purchase Configuration menu. It avoids errors for users opening supplier information outside that specific replenishment context.
Original PR description
The commit 6eaa4a2ae3b12b244f4c4277ef9cbc172f492f0a introduced a new view on model supplier info. The issue is that this new view is meant to be used on supplier info as One2Many on stock.orderpoint and so contains some `parent.` relation. As no sequence has been set. This view replaced the original one in the Purchase Configuration menu. Leading to some error as `parent.` in not defined for standalone tree view. This commit set a sequence on this new view to ensure it is used only on the orderpoint form view. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
**Description of the issue/feature this PR addresses:** According to Argentinean law 27440, Art. 5º it is mandatory to show the CBU on the report for electronic invoices and electronic debit notes. Before this commit, we were showing only in FCE, and here we add it for NDE on invoices reports with/without payment. Example: - [Report before](https://github.com/odoo/odoo/files/6709489/before.pdf) - [Report after](https://github.com/odoo/odoo/files/6709491/after.pdf) -- I confirm I h
Original PR description
**Description of the issue/feature this PR addresses:** According to Argentinean law 27440, Art. 5º it is mandatory to show the CBU on the report for electronic invoices and electronic debit notes. Before this commit, we were showing only in FCE, and here we add it for NDE on invoices reports with/without payment. Example: - [Report before](https://github.com/odoo/odoo/files/6709489/before.pdf) - [Report after](https://github.com/odoo/odoo/files/6709491/after.pdf) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72716
This update restores consistent access to context values when Odoo evaluates expressions in the web client. It helps prevent action filters or domains from behaving incorrectly when they rely on fallback context values.
Original PR description
When the owl refactoring landed, we rewrote the pyjs evaluation system.
Then, we used the new system in the new code. In particular, the action
service uses it to evaluate the action domain.
But the previous code had a subtle behaviour in the special case of
evaluating domain: it added the context as a pydict object in itself, so
one could evaluate expression such as `context.get('a', 14)` to read the
value of a key in the context with a fallback.
With this commit, we uniformize this behaviour across all python
expression: the `context` key is now reserved, and used to access
anything in the current evaluation context.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prAvoid website_publisher unwittingly breaking portal page layouts where publisher_comment is enabled. Forward-Port-Of: odoo/odoo#73055
Original PR description
Avoid website_publisher unwittingly breaking portal page layouts where publisher_comment is enabled. Forward-Port-Of: odoo/odoo#73055
Before this commit the map snippet had life-cycle and naming issues. After this commit the map snippet does not have those issues anymore. Also avoid partially reusing the color picker intended for background images for the color filter overlay. Implements changes discussed in https://github.com/odoo/odoo/pull/66766 after it was closed. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm
Original PR description
Before this commit the map snippet had life-cycle and naming issues. After this commit the map snippet does not have those issues anymore. Also avoid partially reusing the color picker intended for background images for the color filter overlay. Implements changes discussed in https://github.com/odoo/odoo/pull/66766 after it was closed. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73140 Forward-Port-Of: odoo/odoo#72271
Signing the CLA for Odoo version 13 onwards please. Will this commit get auto-forward merged? FYI @ged-odoo ref https://github.com/odoo/owl/pull/848 Forward-Port-Of: odoo/odoo#73191
Original PR description
Signing the CLA for Odoo version 13 onwards please. Will this commit get auto-forward merged? FYI @ged-odoo ref https://github.com/odoo/owl/pull/848 Forward-Port-Of: odoo/odoo#73191
This reverts commit e6871f1991a951391fe1942f86ed208385d31b38 (PR #72138). Finally we don't want to change the position of this button. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72993
Original PR description
This reverts commit e6871f1991a951391fe1942f86ed208385d31b38 (PR #72138). Finally we don't want to change the position of this button. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72993
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69584
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69584
**Description of the issue/feature this PR addresses:** When an installed module is not installable, we don't want to check its dependencies because they may not be available. Erroring out on such dependencies is not needed because the module will not be loaded anyway. On the contrary, such errors prevent starting a database which would otherwise function normally. Such errors occur when doing incremental migrations where it happens that addons are installed (from the previous versio
Original PR description
**Description of the issue/feature this PR addresses:** When an installed module is not installable, we don't want to check its dependencies because they may not be available. Erroring out on such…
**Description of the issue/feature this PR addresses:** When an installed module is not installable, we don't want to check its dependencies because they may not be available. Erroring out on such dependencies is not needed because the module will not be loaded anyway. On the contrary, such errors prevent starting a database which would otherwise function normally. Such errors occur when doing incremental migrations where it happens that addons are installed (from the previous version) but not migrated yet and therefore not installable. When we migrate and update lower level dependencies Odoo marks higher level addons as "to upgrade" even if they are not installable. That is usually harmless, except when such addons have dependencies that are themselves not available. This PR fixes that. **Current behavior before PR:** Errors about (external) dependencies of installed addons that are not installable, and a database that does not start. **Desired behavior after PR is merged:** No stack traces, only the usual logs about addons not being available, and a database that otherwise starts normally. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#64578
Move candidate.unlink out of the for loop to unlink records in batch. Turn self.mapped.filtered -> self.search to execute both in one query to the DB. ##### speed-up Customer DB, inventory with 532 lines Total inventory validation time: `18min -> 10s` `move_line._free_reservation` times when validating inventory | | Before PR | After PR| |:--:|:------------:|:-----------:| | avg | 9.48s | 0.067s | | min | 0.001s | 0.001s | | max | 16min | 5.38s | -- I confirm I have sig
Original PR description
Move candidate.unlink out of the for loop to unlink records in batch. Turn self.mapped.filtered -> self.search to execute both in one query to the DB. ##### speed-up Customer DB, inventory with 532 lines Total inventory validation time: `18min -> 10s` `move_line._free_reservation` times when validating inventory | | Before PR | After PR| |:--:|:------------:|:-----------:| | avg | 9.48s | 0.067s | | min | 0.001s | 0.001s | | max | 16min | 5.38s | -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73082
This makes it possible to patch only _prepare_transaction_request in case parameters need to be added. Forward-Port-Of: odoo/odoo#73185
Original PR description
This makes it possible to patch only _prepare_transaction_request in case parameters need to be added. Forward-Port-Of: odoo/odoo#73185
By default max cron threads is setted to 2. But this value must be setted to 0 in the IoT This parameter is added to odoo.conf of the IoT Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73162
Original PR description
By default max cron threads is setted to 2. But this value must be setted to 0 in the IoT This parameter is added to odoo.conf of the IoT Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73162
# Description of the issue/feature this PR addresses: In l10n_latam, creating a debit note with stock_account installed ends up in stock_account checking for a property that may not exist. # Current behavior before PR: ends-up in a traceback with a key-error # Desired behavior after PR is merged: debit note gets created properly But is present from V13 to master ticket: opw-2580992 bug-fix: opw-2588504 -- I confirm I have signed the CLA and read the PR guidelines
Original PR description
# Description of the issue/feature this PR addresses: In l10n_latam, creating a debit note with stock_account installed ends up in stock_account checking for a property that may not exist. # Current behavior before PR: ends-up in a traceback with a key-error # Desired behavior after PR is merged: debit note gets created properly But is present from V13 to master ticket: opw-2580992 bug-fix: opw-2588504 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73183
In case you have installed `sale_timesheet` and try to do a bulk invoice creation you will be blocked if one order does not have invoiceable lines instead of skipping this specific order. **Description of the issue/feature this PR addresses:** As soon as you try to invoice a single order which does not fit the date range given, the whole process is blocked. So, we should just move on and skip those and only block and inform the user if nothing was possible to be invoiced. **Current behav
Original PR description
In case you have installed `sale_timesheet` and try to do a bulk invoice creation you will be blocked if one order does not have invoiceable lines instead of skipping this specific order. **Description of the issue/feature this PR addresses:** As soon as you try to invoice a single order which does not fit the date range given, the whole process is blocked. So, we should just move on and skip those and only block and inform the user if nothing was possible to be invoiced. **Current behavior before PR:** One order is blocking all and without being explicit which order was blocking **Desired behavior after PR is merged:** Skip those orders and invoice the legit orders via bulk invoice creation. Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73145
Forward-Port-Of: odoo/enterprise#19352
Original PR description
Forward-Port-Of: odoo/enterprise#19352
Thanks to #19378, all dimensions are now converted to the appropriate UoM However, other tests are broken, they trigger some UPS error: > Package exceeds the maximum length constraint of 108 inches. Length is the longest side of a package. or > Package exceeds the maximum size total constraints of 165 inches (length + girth, where girth is 2 x width plus 2 x height). Forward-Port-Of: odoo/enterprise#19422 Forward-Port-Of: odoo/enterprise#19403
Original PR description
Thanks to #19378, all dimensions are now converted to the appropriate UoM However, other tests are broken, they trigger some UPS error: > Package exceeds the maximum length constraint of 108 inches. Length is the longest side of a package. or > Package exceeds the maximum size total constraints of 165 inches (length + girth, where girth is 2 x width plus 2 x height). Forward-Port-Of: odoo/enterprise#19422 Forward-Port-Of: odoo/enterprise#19403
Go to Accounting > Configuration > Taxes Enable purchase taxes for 2.5% and 5% Go to Accounting > Reporting > Argentinian Statements: Purchases VAT Book There's a traceback Out of Index error because the headers are not loaded but the cells are. This makes sure that the headers are loaded if those taxes are enabled. opw-2569173 Forward-Port-Of: odoo/enterprise#19269
Original PR description
Go to Accounting > Configuration > Taxes Enable purchase taxes for 2.5% and 5% Go to Accounting > Reporting > Argentinian Statements: Purchases VAT Book There's a traceback Out of Index error because the headers are not loaded but the cells are. This makes sure that the headers are loaded if those taxes are enabled. opw-2569173 Forward-Port-Of: odoo/enterprise#19269