Wednesday, July 28, 2021
13 changes · master
Resolved issues and error corrections
This update prevents contract history rows from opening an unnecessary form dialog when clicked. It makes the HR contract history view behave more predictably and reduces accidental navigation for users reviewing employee contract information.
Original PR description
clicking on the row of contract history opens the formViewDialog so this commit fixes the issue by adding the readonly attributes on the field so that clicking on the row of the contract history doesn't open the formViewDialog TaskID-2578874 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
The e-commerce product display and search components have been reorganized into dedicated files. This makes the website shop code easier to maintain without changing the visible shopping experience for customers.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
- Go to website shop - Add free product or discount to cart to make sure that total amount is 0 - Try to confirm order It will not be possible because the "Confirm Order" button is disabled by default and there is no way to enable it. opw-2577089 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74173
Original PR description
- Go to website shop - Add free product or discount to cart to make sure that total amount is 0 - Try to confirm order It will not be possible because the "Confirm Order" button is disabled by default and there is no way to enable it. opw-2577089 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74173
Github codeowner is replaced with a runbot version of codeowners for multiple reason: - github codeowners is difficult to maintain, the precedence rule will sometimes remove teams from some file because of a more specific rule added by another team. - github codeowner does not support version specific rules, especially the "all except master" rule. For this use case teams needs to adapt the new codeowner when freezing a new version. - github will trigger codeowner on failed rebase,
Original PR description
Github codeowner is replaced with a runbot version of codeowners for multiple reason: - github codeowners is difficult to maintain, the precedence rule will sometimes remove teams from some file because of a more specific rule added by another team. - github codeowner does not support version specific rules, especially the "all except master" rule. For this use case teams needs to adapt the new codeowner when freezing a new version. - github will trigger codeowner on failed rebase, and add almost all teams as reviewer. Runbot has specific commit and file limit to avoid this problem. - runbot codeowner is centralised and does not need to be managed cross repo/version - runbot codeowner works for enterprise Forward-Port-Of: odoo/odoo#74257 Forward-Port-Of: odoo/odoo#74094
Description of the issue/feature this PR addresses: The method to compute the quantity delivered of a sales order line considers the cancelled moves when fetching the related BoM for kits. Current behavior before PR: The current behaviour does not filter the cancelled moves when getting the related BoM. This implies that, if a new BoM is created for the same product but with some changes, and the original delivery is cancelled, the sale order line will still consider the previous BoM. Desi
Original PR description
Description of the issue/feature this PR addresses: The method to compute the quantity delivered of a sales order line considers the cancelled moves when fetching the related BoM for kits. Current behavior before PR: The current behaviour does not filter the cancelled moves when getting the related BoM. This implies that, if a new BoM is created for the same product but with some changes, and the original delivery is cancelled, the sale order line will still consider the previous BoM. Desired behavior after PR is merged: After the fix, the cancelled moves will not be considered when finding the BoM, as this is what should be expected from cancelled operations. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73833
The browser displays the horizontal scroll bar because the size of the carousel arrows are in percentage and considered offscreen. opw-2585526 Forward-Port-Of: odoo/odoo#74306 Forward-Port-Of: odoo/odoo#73641
Original PR description
The browser displays the horizontal scroll bar because the size of the carousel arrows are in percentage and considered offscreen. opw-2585526 Forward-Port-Of: odoo/odoo#74306 Forward-Port-Of: odoo/odoo#73641
Explain the situation when a manual change has been done to the sequence of `account.move`. This was needed because some user didn't realize that they changed the sequence, and when they realized it, it had polluted multiple numbers after that. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70941
Original PR description
Explain the situation when a manual change has been done to the sequence of `account.move`. This was needed because some user didn't realize that they changed the sequence, and when they realized it, it had polluted multiple numbers after that. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70941
Description of the issue/feature this PR addresses: Fine tuning of https://github.com/odoo/odoo/commit/c7b32e0795bc1573d81563f31a75fa44c64b39c2 @Whenrow it is a fine tuning to compute more fast qty_forecast, qty_to_order and _get_orderpoint_action() @amoyaux -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74004
Original PR description
Description of the issue/feature this PR addresses: Fine tuning of https://github.com/odoo/odoo/commit/c7b32e0795bc1573d81563f31a75fa44c64b39c2 @Whenrow it is a fine tuning to compute more fast qty_forecast, qty_to_order and _get_orderpoint_action() @amoyaux -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74004
PURPOSE Clicking on kanban cover image do not open kanban record, clicking on cover image should open record. SPEC Clicking on kanban cover image should open record. TASK 2524022 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74073
Original PR description
PURPOSE Clicking on kanban cover image do not open kanban record, clicking on cover image should open record. SPEC Clicking on kanban cover image should open record. TASK 2524022 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74073
opw-2578984 Forward-Port-Of: odoo/odoo#74024
Original PR description
opw-2578984 Forward-Port-Of: odoo/odoo#74024
## Description of the issue/feature this PR addresses: This commit aims to improve the CAMT file import by supporting the case in which the \<CcyXchg\> node is contained in the \<TxAmt\> node instead of the <CntrValAmt> node. ## Current behavior before PR: CAMT file with node \<CcyXchg\> contained in \<TxAmt\> node result in a ValidationError. ## Desired behavior after PR is merged: CAMT file is imported correctly closes opw-2596701 -- I confirm I have signed the CLA and
Original PR description
## Description of the issue/feature this PR addresses: This commit aims to improve the CAMT file import by supporting the case in which the \<CcyXchg\> node is contained in the \<TxAmt\> node instead of the <CntrValAmt> node. ## Current behavior before PR: CAMT file with node \<CcyXchg\> contained in \<TxAmt\> node result in a ValidationError. ## Desired behavior after PR is merged: CAMT file is imported correctly closes opw-2596701 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/enterprise#19917
When using percent-formatting, there can be these formatting error: ``` - KeyError: '%(h)s' % {} - ValueError: '1%' % {} - TypeError: '%(h)s %\n' % {'h':1} ``` When adding a single percent character, only the first one would show the error message "Use ... or %% if you want to use the percent character.'" opw-2611422 Forward-Port-Of: odoo/enterprise#19908
Original PR description
When using percent-formatting, there can be these formatting error:
```
- KeyError: '%(h)s' % {}
- ValueError: '1%' % {}
- TypeError: '%(h)s %\n' % {'h':1}
```
When adding a single percent character, only the first one would show
the error message "Use ... or %% if you want to use the percent character.'"
opw-2611422
Forward-Port-Of: odoo/enterprise#19908Fix traceback introduced by: https://github.com/odoo/enterprise/commit/6b7da51ad3d12d31cb0654d839e89de406cb6358 issue: 2608649 Forward-Port-Of: odoo/enterprise#19882 Forward-Port-Of: odoo/enterprise#19832
Original PR description
Fix traceback introduced by: https://github.com/odoo/enterprise/commit/6b7da51ad3d12d31cb0654d839e89de406cb6358 issue: 2608649 Forward-Port-Of: odoo/enterprise#19882 Forward-Port-Of: odoo/enterprise#19832