Thursday, July 29, 2021
16 changes · master
Enhancements to existing features
The CRM duplicate lead check has been optimized to reduce unnecessary database lookups. This should make related CRM operations faster, especially when working with larger lead databases.
Original PR description
…ates By computing the search domain before calling return_if_relevant, we can make only one query and thus speed up the method. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fix ensures prices shown in the website shop autocomplete search appear as intended instead of displaying visible HTML formatting text. Customers see cleaner, correctly formatted price information while browsing products through search suggestions.
Original PR description
/shop/products/autocomplete return price already rendered with monetary
widget, so it is plain html like:
"$ <span class=\"oe_currency_value\">12.00</span>"
It need to be marked MarkupSafe to avoid the escaping.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prMiscellaneous changes
…ng base A tax line affecting the base of subsequent taxes is a line having some values in 'tax_ids' & 'tag_ids'. When creating a refund, tags was wrongly computed in this case. issue: 2596368 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74223 Forward-Port-Of: odoo/odoo#73978
Original PR description
…ng base A tax line affecting the base of subsequent taxes is a line having some values in 'tax_ids' & 'tag_ids'. When creating a refund, tags was wrongly computed in this case. issue: 2596368 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74223 Forward-Port-Of: odoo/odoo#73978
The Analysis button is restored on worksheet template forms after it disappeared during a module restructuring. The change moves this behavior into the shared worksheet module so Field Service and Quality can both use it consistently.
Original PR description
Before this commit: The 'analysis' button is missing when going to field service > configuration > worksheet templates > open the form view This is happening after introducing the new worksheet module from industry_fsm_report to allow other modules to create their worksheet. see: 0324acc After this commit: The 'analysis' button will be displayed. Also, move that part in the worksheet module as we also want the 'analysis' button in Quality. Hence make it generic. Task-2555286
…state When using the online synchronization, you could have a wrong balance in 'processing' state. In that case, don't force the user to reset the whole statement to 'open' and allow him to edit balances directly. task: 2606857 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74093
Original PR description
…state When using the online synchronization, you could have a wrong balance in 'processing' state. In that case, don't force the user to reset the whole statement to 'open' and allow him to edit balances directly. task: 2606857 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74093
PURPOSE Grouping Purchase Order kanban doesn't work, grouped kanban view is displayed besides dahsboard div. SPEC Grouped purchase order kanban view should be displayed below dashboard value div. TASK 2366797 Fixes https://github.com/odoo/odoo/issues/59041 Closes https://github.com/odoo/odoo/issues/59041 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60597
Original PR description
PURPOSE Grouping Purchase Order kanban doesn't work, grouped kanban view is displayed besides dahsboard div. SPEC Grouped purchase order kanban view should be displayed below dashboard value div. TASK 2366797 Fixes https://github.com/odoo/odoo/issues/59041 Closes https://github.com/odoo/odoo/issues/59041 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60597
**Description of the issue/feature this PR addresses:** As of https://github.com/odoo/odoo/pull/72859 on every update of the delivery line in a sale order ALL pickings are overwritten with the new carrier, no matter what... To save you guys from more OPWs and desperate customers, let me help you with two things and I hope it is appreciated. **Current behavior before PR:** Updating shipping costs do overwrite carriers of done and processed (tracking reference) pickings and also deleting s
Original PR description
**Description of the issue/feature this PR addresses:** As of https://github.com/odoo/odoo/pull/72859 on every update of the delivery line in a sale order ALL pickings are overwritten with the new carrier, no matter what... To save you guys from more OPWs and desperate customers, let me help you with two things and I hope it is appreciated. **Current behavior before PR:** Updating shipping costs do overwrite carriers of done and processed (tracking reference) pickings and also deleting sale order lines (delivery line) already invoiced. **Desired behavior after PR is merged:** - Only pickings are written, where we are kinda sure that it is wanted by the user, on updating the shipping costs on a sale order. - The user is stopped to update the shipping costs in case it was already invoiced. Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73624 Forward-Port-Of: odoo/odoo#73187
Description of the issue/feature this PR addresses: In the popover date and float are wrongly formatted. This PR format date and float according to the user language. Current behavior before PR:  Desired behavior after PR is merged:  @amoyaux -- I confi
Original PR description
Description of the issue/feature this PR addresses: In the popover date and float are wrongly formatted. This PR format date and float according to the user language. Current behavior before PR:  Desired behavior after PR is merged:  @amoyaux -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74005
ISSUE Since 14.4, dropping the image gallery to a website was causing a traceback. CAUSE The bug appeared when new options were added to i.fa elements (such as Alignment, Shape, Padding). It was an issue for the image gallery as in the start method of the snippet widget, o_indicators_left and o_indicators_right elements are removed if not necessary. They are removed and not only hidden in order to keep the snippet responsive. In that situation, there was a concurrency issue, as an e
Original PR description
ISSUE Since 14.4, dropping the image gallery to a website was causing a traceback. CAUSE The bug appeared when new options were added to i.fa elements (such as Alignment, Shape, Padding). It was an issue for the image gallery as in the start method of the snippet widget, o_indicators_left and o_indicators_right elements are removed if not necessary. They are removed and not only hidden in order to keep the snippet responsive. In that situation, there was a concurrency issue, as an editor of a child snippet removed from the DOM (here in the start method of the parent snippet) was created and initializing options for an element that was not there anymore. SOLUTION When a snippet is dropped on a page, we wait for its widgets to be started before creating its options. task-2604383 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74251
Description of the issue/feature this PR addresses: When running the scheduler manually with a user who has no read access on pos.session (and point_of_sale is installed), the run fails silently for the user, and shows an error in the logs. "_alert_old_session" runs with the user's rights, who might have POS access. This commits runs the problematic search with sudo to work around this issue. Current behavior before PR: Scheduler silently fails. Desired behavior after PR is mer
Original PR description
Description of the issue/feature this PR addresses: When running the scheduler manually with a user who has no read access on pos.session (and point_of_sale is installed), the run fails silently for the user, and shows an error in the logs. "_alert_old_session" runs with the user's rights, who might have POS access. This commits runs the problematic search with sudo to work around this issue. Current behavior before PR: Scheduler silently fails. Desired behavior after PR is merged: Scheduler runs normally -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74158
Steps to reproduce the bug: - Install Accounting and Expense app - Go to accounting settings > enable cash basis option - Go to accounting > configuration > accounting > taxes - Create a new tax or choose an existing one e.g “Tax abc”: Tax Computation = `”Percentage of Price”` Tax Type = `”Purchases”` Choose any value for amount Select "Based on Payment" in tax due choose an account with the "Allow Reconciliation" option activated in the Cash Basis Transition Account field Save - Go
Original PR description
Steps to reproduce the bug: - Install Accounting and Expense app - Go to accounting settings > enable cash basis option - Go to accounting > configuration > accounting > taxes - Create a new tax or…
Steps to reproduce the bug: - Install Accounting and Expense app - Go to accounting settings > enable cash basis option - Go to accounting > configuration > accounting > taxes - Create a new tax or choose an existing one e.g “Tax abc”: Tax Computation = `”Percentage of Price”` Tax Type = `”Purchases”` Choose any value for amount Select "Based on Payment" in tax due choose an account with the "Allow Reconciliation" option activated in the Cash Basis Transition Account field Save - Go to expenses > Expense Reports > All reports > Create a new one : - Add 2 expense and for both set up the taxes to "Tax abc" and unit price > 0 - Submit to manager - Approve - Post journal entries - Register a payment Problem: A user error with the following message is triggered: “You are trying to reconcile some entries that are already reconciled” In the use case we have two expenses and for each, an `" account.partial.reconcile "` will be created, so we will loop twice and therefore add twice all the `”account.move.line”` linked to the taxes in the dict `" to_reconcile_after "`: https://github.com/odoo/odoo/blob/beccf82e09d536255d9d9cb9bfe58ebae2559843/addons/account/models/account_partial_reconcile.py#L585 Then we loop to reconcile all the `" account.move.line "` which are in the dict `" to_reconcile_after "`, but since we added them all twice, at each turn of the loop we give them all as a parameter of the “reconcile” function without checking whether they are already reconciled or not. opw-2565934 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74373
When setting a Bill or Material to subcontracting, the "Operations" tab is hidden. But it still effect eg. BoM Structure & Cost report. With this changeset, we get an error when we save a subcontracting BoM that has operations. opw-2513637 Forward-Port-Of: odoo/odoo#74382
Original PR description
When setting a Bill or Material to subcontracting, the "Operations" tab is hidden. But it still effect eg. BoM Structure & Cost report. With this changeset, we get an error when we save a subcontracting BoM that has operations. opw-2513637 Forward-Port-Of: odoo/odoo#74382
…dor Bills journal created for a l10n_nl chart of account Allow Cost of Revenue accounts to match the default expense account Ticket: 2458146 Forward-Port-Of: odoo/odoo#73645
Original PR description
…dor Bills journal created for a l10n_nl chart of account Allow Cost of Revenue accounts to match the default expense account Ticket: 2458146 Forward-Port-Of: odoo/odoo#73645
Incorporate Luigys TOro (desdelinux) as Vauxoo's contributor -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74343
Original PR description
Incorporate Luigys TOro (desdelinux) as Vauxoo's contributor -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#74343
The issue appear in the invoices view when the record has at least an attachment and `account_invoice_extract` is not installed. If the module is installed, an xpath replaces the part displaying the preview of attachments and modifies the domain of the modifier. The classname `o-aside` are not applied because the attachment preview exists. The attachment preview is created because there are attachments but is not inserted because the container is invisible (applied domain). The fix cons
Original PR description
The issue appear in the invoices view when the record has at least an attachment and `account_invoice_extract` is not installed. If the module is installed, an xpath replaces the part displaying the…
The issue appear in the invoices view when the record has at least an
attachment and `account_invoice_extract` is not installed. If the module
is installed, an xpath replaces the part displaying the preview of
attachments and modifies the domain of the modifier.
The classname `o-aside` are not applied because the attachment preview
exists. The attachment preview is created because there are attachments
but is not inserted because the container is invisible (applied domain).
The fix consists in checking if the preview attachment container is
visible to create the preview.
In community:
```xml
<div class="o_attachment_preview"
attrs="{'invisible': ['|',
('move_type', 'not in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund')),
('state', '!=', 'draft')]}" />
```
In enterprise:
```xml
<xpath expr="//div[hasclass('o_attachment_preview')]" position="replace">
<div class="o_attachment_preview" options="{'preview_priority_type': 'pdf'}"/>
</xpath>
```
opw-2517726
opw-2547527
Forward-Port-Of: odoo/enterprise#19904Go to tax report > do a comparison When doing a comparison, the taxes in the comparison column(s) will be the sum of all taxes in the date range AND everything in the past because strict_range was False. With this fix, strict_range is True from the start so only the correct tax values are selected in the comparison. opw-2547984 Forward-Port-Of: odoo/enterprise#19817 Forward-Port-Of: odoo/enterprise#19793
Original PR description
Go to tax report > do a comparison When doing a comparison, the taxes in the comparison column(s) will be the sum of all taxes in the date range AND everything in the past because strict_range was False. With this fix, strict_range is True from the start so only the correct tax values are selected in the comparison. opw-2547984 Forward-Port-Of: odoo/enterprise#19817 Forward-Port-Of: odoo/enterprise#19793