Thursday, August 5, 2021
9 changes · master
Resolved issues and error corrections
Image shape settings now behave correctly when users replace shaped images with GIFs or switch back to supported formats. This prevents animated GIFs from being incorrectly converted or losing animation, and avoids leftover shape data on image types that do not support shapes.
Original PR description
Issues: [ 1 ] - Edit mode > Set a shape on Image - Replace it by a GIF > GIF is not animated in the shape. - Remove the shape > the GIF is still not animated (converted and saved as base64). [ 2 ] - [1] Edit mode > Set a shape on image (mimetype = 'image/jpeg') - [2] Replace it by an animated GIF. - [3] Replace the .GIF image again by the old one. - The shape is not applied on it. The goal of this PR is to fix all issues related to wrong mimetype values / incoherent dataset by adding the `_isImageMimetypeSupported()` method to check if image format is supported and set shape accordingly. IMPORTANT: after this PR, the right mimetype value for GIF images is passed and shapes cannot be applied on them > useless shape data will be removed from non-supported images. task-2578242
The project overview now checks directly whether a project has timesheets instead of calculating total timesheet time first. This reduces unnecessary processing and should make the project kanban view load more efficiently when timesheets are present.
Original PR description
Before this commit, we use the `total_timesheet_time` field in the kanban view of `project.project` to know if there are some timesheets into each project. The problem is this field is computed and its compute method take more execution time than just use `timesheet_ids` field to allow if a project has at least one timesheet. This commit replaces the using of `total_timesheet_time` field by the `timesheet_ids` field in project kanban view to check if the project has at least one timesheet. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mail menu unread counter now excludes channels that are not pinned, preventing hidden or inactive conversations from inflating the displayed unread count. This helps users see a more accurate notification number for the conversations they actively keep in their menu.
Original PR description
Follow up of a795a2f7d8fd57120db5cafdc9f1929e118b0626
Adyen payment notifications will now always receive the expected confirmation response, even if Odoo encounters a validation issue while processing them. This avoids exposing internal error details in Adyen's backend and keeps payment notification handling cleaner and more consistent.
Original PR description
Before this commit, when the webhook was processing a notification, if there was a validation error, the webhook was sending the whole traceback to Adyen. Since this was still a response code 200, this didn't cause any problem, but we could see the response received in the Adyen backend. So we will now catch any validation error and send `'[accepted]'` in the response.
This fix ensures that when an Italian SdI Coop electronic invoice is sent successfully, the system reports the success correctly. This helps prevent follow-up processes or user feedback from treating a successful send as uncertain or failed.
Original PR description
…d return {'success': True}
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis fixes an issue that could prevent PDF reports, such as invoices, from printing correctly. Businesses can now generate and share key documents more reliably without print errors interrupting daily workflows.
Original PR description
fixes for odoo/odoo#68299 can be tested with invoice print to pdf
Customers returning to Odoo after paying with Adyen will no longer risk losing their payment session due to browser cookie behavior. This helps Odoo immediately find and finish processing the payment, reducing failed or delayed order confirmations. Related payment return descriptions for PayUmoney and SIPS were also clarified.
Original PR description
Before this commit, users returning from Adyen to Odoo after payment could see their session renewed, depending on their browser's implementation of the `SameSite` cookie attribute. This prevented Odoo from retrieving the transaction from the users' session. This commit flags the return route of Adyen with `save_session=False`, hence allowing all users to immediately post-process their transactions when they return to Odoo. While we're at it, the docstrings of the return routes of PayUmoney and SIPS' have been updated for better clarity.
Point of Sale users now see an error message when they select a loyalty reward for a free product that is not available in the POS. This prevents silent failures and helps staff understand why the reward cannot be applied.
Original PR description
This PR addresses multiple small changes for the POS according the task 2492631 which are: - Added an `ErrorPopup` when selecting a free product which is not loaded in the POS as a reward. - ~~Properly load the rewards and rules of the corresponding (only one) Loyalty Programs~~ (fixed in 0fbdbd082209f8f408c1a88f969a4fab26fd1589) Related community PR: https://github.com/odoo/odoo/pull/72793
A recent change caused errors when users tried to print accounting reports as PDF files. This fix restores reliable PDF printing so finance teams can generate and share reports without interruption.
Original PR description
odoo/enterprise#17270 introduced an error when trying to print accounting reports to PDF