Thursday, September 9, 2021
19 changes · master
Resolved issues and error corrections
The Google Calendar automated test was adjusted so it no longer fails because of the new appointment link button. This helps keep quality checks reliable without changing the user-facing calendar experience.
Original PR description
Fix the test to ignore the new part which manages the new button for appointment link
This fixes unnecessary warnings that appeared when a window close action included extra information for the client interface. The change helps keep system logs and user workflows cleaner without changing business behavior.
Original PR description
Clientside, the only key got from an `ir.actions.act_window_close` type action is 'infos'. But this key isn't a part of the whitelisted readable fields server side, which means you will get a warning if you use it.
Spreadsheet document breadcrumbs now display with the correct sizing in Firefox. This keeps navigation labels visually consistent across browsers and avoids layout issues for users working with documents and spreadsheets.
Original PR description
window.getComputedStyle on Firefox does not return the "font" attribute, we have to create it from fontSize and fontFamily. Task-id 2623513
The order of options in the spreadsheet document context menu has been adjusted to make actions easier to find. This helps users navigate spreadsheet tools more predictably and reduces confusion when working with documents.
Access rules for SMS templates were corrected so regular internal users can still read templates when other business processes need them. This helps prevent disruptions in features that rely on SMS templates while keeping restrictions on changing or deleting them.
Original PR description
Temporary PR, will be closed
Miscellaneous changes
**Description of the issue/feature this PR addresses:** - Go to runbot - create a second warehouse, resupply from the first - create a product, replenish W2 from W1 - Goto Inventory Forecast --> Issue value are wrong. An OUT is when WH source is Set and (WH dest is not set or destination location is 'transit'). An IN is when WH dest is Set and (WH source is not set or source location is 'transit'). **Current behavior before PR:** . An IN is when WH dest is Set and (WH source is not set or source location is 'transit'). **Current behavior before PR:**  **Desired behavior after PR is merged:**  @amoyaux @sla-subteno-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67598
Before this commit, 1: It was always calling method `_get_answer_score_values` even if we were getting `answer_score` in `vals`. 2: It was always accessing `user_input_id` and `question_id` from `vals` on and write method which might not exists in `vals`. With this Commit, 1: we are calling method `_get_answer_score_values` when its necessary get values for `answer_is_correct` and `answer_score`. 2: use `user_input_id` and `question_id` from `self` if it is not available in `vals` t
Original PR description
Before this commit, 1: It was always calling method `_get_answer_score_values` even if we were getting `answer_score` in `vals`. 2: It was always accessing `user_input_id` and `question_id` from `vals` on and write method which might not exists in `vals`. With this Commit, 1: we are calling method `_get_answer_score_values` when its necessary get values for `answer_is_correct` and `answer_score`. 2: use `user_input_id` and `question_id` from `self` if it is not available in `vals` to get values for `answer_is_correct` and `answer_score`. Fixes: #67429 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68500
Some assets are missing from layout due to an incorrect namespace since conversion to new assets system. opw-2638542 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76056
Original PR description
Some assets are missing from layout due to an incorrect namespace since conversion to new assets system. opw-2638542 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76056
Steps to reproduce the issue: - Let's log in Odoo with a user U1 - Create a lead with user U2 as salesperson - Click on New quotation Bug: A SO was suggested with U1 as salesperson instead of U2 opw:2520827 Forward-Port-Of: odoo/odoo#76021 Forward-Port-Of: odoo/odoo#75787
Original PR description
Steps to reproduce the issue: - Let's log in Odoo with a user U1 - Create a lead with user U2 as salesperson - Click on New quotation Bug: A SO was suggested with U1 as salesperson instead of U2 opw:2520827 Forward-Port-Of: odoo/odoo#76021 Forward-Port-Of: odoo/odoo#75787
no need to make rounding during computing qty_available STEPS (see the test): * create product with uom dozens * create product with uom units * create bom kit to convert one to another * set qty on hand to 1 for product dozens * check qty for product units BEFORE: qty=11 AFTER: qty=12 --- opw-2632782 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and r
Original PR description
no need to make rounding during computing qty_available STEPS (see the test): * create product with uom dozens * create product with uom units * create bom kit to convert one to another * set qty on hand to 1 for product dozens * check qty for product units BEFORE: qty=11 AFTER: qty=12 --- opw-2632782 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76145
Before this commit, Inventory Admin was not able to create new /edit picking type as Non-admin users doesn't have rights to create/edit sequence. With this commit, we are creating/editing `sequence_id` with sudo Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#75606
Original PR description
Before this commit, Inventory Admin was not able to create new /edit picking type as Non-admin users doesn't have rights to create/edit sequence. With this commit, we are creating/editing `sequence_id` with sudo Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#75606
The notification sent when starting a meeting used `partner.name` to display the name of the one who started the meeting. Therefore, it did not work properly with guests, for whom no partner is defined, resulting in `False started a live conference` being displayed. This commit fixes the issue by using `guest.name` instead of `partner.name` when no partner is defined. Also change some quotes to stick to the guidelines. Forward-Port-Of: odoo/odoo#76226
Original PR description
The notification sent when starting a meeting used `partner.name` to display the name of the one who started the meeting. Therefore, it did not work properly with guests, for whom no partner is defined, resulting in `False started a live conference` being displayed. This commit fixes the issue by using `guest.name` instead of `partner.name` when no partner is defined. Also change some quotes to stick to the guidelines. Forward-Port-Of: odoo/odoo#76226
…being done Following commit 637684fb50ff42a617cfa055d20aaa11b86c0b7b which improved the conditions under which the ComponentWrapper compatibility layer should trigger owl's `__callMounted` on all the owl children of a Legacy Widget. One case was forgotten though: when the current component (wherever it is in the hierarchy) is rendered BUT another rendering has been initiated meanwhile. In that case, we shouldn't mark the component as mounted. The owl's fiber.complete algorithm will
Original PR description
…being done Following commit 637684fb50ff42a617cfa055d20aaa11b86c0b7b which improved the conditions under which the ComponentWrapper compatibility layer should trigger owl's `__callMounted` on all the owl children of a Legacy Widget. One case was forgotten though: when the current component (wherever it is in the hierarchy) is rendered BUT another rendering has been initiated meanwhile. In that case, we shouldn't mark the component as mounted. The owl's fiber.complete algorithm will take care of calling __callMounted when it finishes. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#75950
This reverts commit odoo/odoo@3d72a6a4d21cb12cbe68672610bf83e8fe80b87b . This code is not used as finally Kanban ribbon as a widget has not been added after review. Moreover current use of ribbon classes in kanban is broken. Forward-Port-Of: odoo/odoo#76268
Original PR description
This reverts commit odoo/odoo@3d72a6a4d21cb12cbe68672610bf83e8fe80b87b . This code is not used as finally Kanban ribbon as a widget has not been added after review. Moreover current use of ribbon classes in kanban is broken. Forward-Port-Of: odoo/odoo#76268
Before this commit, trying to autofill the total of a pivot with dates leads to traceback. Task-id 2623369 Forward-Port-Of: odoo/enterprise#20712 Forward-Port-Of: odoo/enterprise#20268
Original PR description
Before this commit, trying to autofill the total of a pivot with dates leads to traceback. Task-id 2623369 Forward-Port-Of: odoo/enterprise#20712 Forward-Port-Of: odoo/enterprise#20268
Considering the field declaration: https://github.com/odoo/odoo/blob/fe5deb4ee4c8e07aed2f2cff6210271bfaa61476/addons/point_of_sale/models/pos_order.py#L1121 `discount` is a rate, not an amount. Therefore, suppose a discount of 10%, when opening a POS-generated SO, the discount shouldn't be "$10". OPW-2629493 Forward-Port-Of: odoo/enterprise#20654
Original PR description
Considering the field declaration: https://github.com/odoo/odoo/blob/fe5deb4ee4c8e07aed2f2cff6210271bfaa61476/addons/point_of_sale/models/pos_order.py#L1121 `discount` is a rate, not an amount. Therefore, suppose a discount of 10%, when opening a POS-generated SO, the discount shouldn't be "$10". OPW-2629493 Forward-Port-Of: odoo/enterprise#20654
In task-2475732 a default role was created for templates that had no sign items, to allow adding new items while signing. However adding this new role prevented the accesses for the sign request to be sent in templates without sign items. This PR adds a new check to verify this case and allow again the email to be sent. Forward-Port-Of: odoo/enterprise#20628
Original PR description
In task-2475732 a default role was created for templates that had no sign items, to allow adding new items while signing. However adding this new role prevented the accesses for the sign request to be sent in templates without sign items. This PR adds a new check to verify this case and allow again the email to be sent. Forward-Port-Of: odoo/enterprise#20628
…holiday pay Combination of a9c2a31 d1fe81b f2d0119 2a26b47 Forward-Port-Of: #20646 Forward-Port-Of: odoo/enterprise#20694
Original PR description
…holiday pay Combination of a9c2a31 d1fe81b f2d0119 2a26b47 Forward-Port-Of: #20646 Forward-Port-Of: odoo/enterprise#20694
Forward-Port-Of: odoo/enterprise#20646
Original PR description
Forward-Port-Of: odoo/enterprise#20646