Tuesday, September 28, 2021
31 changes · master
Enhancements to existing features
Survey administrators can now view and edit the completion description field in the survey backend. This restores control over the message or description shown after a survey is completed, helping teams better tailor respondent follow-up communication.
Original PR description
Description of the issue/feature this PR addresses: Add (back) the edition of description_done field on surveys Current behavior before PR: description_done field is not displayed on backend and therefore user cannot fill it. Desired behavior after PR is merged: description_done field is displayed to / editable by user -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77185
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77185
PURPOSE The date inputs should be having only one calendar button. The purpose of this commit is to remove the additional calendar buttons on the edit portal opportunities pop-up. SPECIFICATIONS Currently, while editing opportunities by a portal user, the popup is appearing. In that popup, 'Expected Closing' and 'Next Activity Date' input fields having date type so a calendar icon is added to the input. Thus, an additional calendar icon is added after the input, which looks ugly
Original PR description
PURPOSE The date inputs should be having only one calendar button. The purpose of this commit is to remove the additional calendar buttons on the edit portal opportunities pop-up. SPECIFICATIONS Currently, while editing opportunities by a portal user, the popup is appearing. In that popup, 'Expected Closing' and 'Next Activity Date' input fields having date type so a calendar icon is added to the input. Thus, an additional calendar icon is added after the input, which looks ugly and it is not working properly. This removes the additional calendar buttons on edit portal opportunities. This is the goal of this commit. PR #75453 TaskID-2624728 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#75453
Description of the issue/feature this PR addresses: - create Tree warehouses, WH1, WH2, WH3, with three different address - add route 2-1 to resupply WH2 from WH1, complete partner_address_id on rule with partner_id of WH2 - add route 3-1 to resupply WH3 from WH1, complete partner_address_id on rule with partner_id of WH3 - create a product - add orderpoint, WH2/Stock with route 2-1 and min_quantity to 1 - add orderpoint, WH3/Stock with route 3-1 and min_quantity to 1 Lauch scheduler.
Original PR description
Description of the issue/feature this PR addresses: - create Tree warehouses, WH1, WH2, WH3, with three different address - add route 2-1 to resupply WH2 from WH1, complete partner_address_id on rule with partner_id of WH2 - add route 3-1 to resupply WH3 from WH1, complete partner_address_id on rule with partner_id of WH3 - create a product - add orderpoint, WH2/Stock with route 2-1 and min_quantity to 1 - add orderpoint, WH3/Stock with route 3-1 and min_quantity to 1 Lauch scheduler. Issue: You have 1 out picking of WH1, with qty = 2. It doesn't make sens because WH2 and WH3 have not the same address. With this PR, 2 out picking are created. @amoyaux -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77099 Forward-Port-Of: odoo/odoo#73438
Purpose of this commit is to update the kanban card color same as the state color of the project update. TaskId: 2638993 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76332
Original PR description
Purpose of this commit is to update the kanban card color same as the state color of the project update. TaskId: 2638993 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76332
Allow users to build dynamic forms on their website. Dynamic meaning that some fields are only visible depending on what is selected on fields above. E.g. if we want to know about website visitor family, we would ask for children name only if visitor specify that he has children, or internally our own form: https://odoo.com/help Task 2431285 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67206
Original PR description
Allow users to build dynamic forms on their website. Dynamic meaning that some fields are only visible depending on what is selected on fields above. E.g. if we want to know about website visitor family, we would ask for children name only if visitor specify that he has children, or internally our own form: https://odoo.com/help Task 2431285 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67206
The user was able to remove the mega menu snippet without removing the corresponding link in the menu. To avoid this flow to happen we removed the delete button for the mega menu snippet. We also handle the case where the user remove the mega menu snippet columns one by one. On last column removal we put back the original template. task-2636545 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confi
Original PR description
The user was able to remove the mega menu snippet without removing the corresponding link in the menu. To avoid this flow to happen we removed the delete button for the mega menu snippet. We also handle the case where the user remove the mega menu snippet columns one by one. On last column removal we put back the original template. task-2636545 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76399
Steps: - Go to Journal Items - Switch to Kanban View - Click on create Issue: - Traeback due to unknow currency Fix: Journal Items are not created individually so we have disabled `Create` button in Kanban view. Fixes: odoo#76543 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#770
Original PR description
Steps: - Go to Journal Items - Switch to Kanban View - Click on create Issue: - Traeback due to unknow currency Fix: Journal Items are not created individually so we have disabled `Create` button in Kanban view. Fixes: odoo#76543 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77020 Forward-Port-Of: odoo/odoo#76990
Edit website select header and set scrolling effect as fixed. save. set header template as 'sidebar' scroll website. Website doesn't scroll properly . In this commit, fixed scrolling effect by setting the standard scrolling when scrolling type is fixed and header set as sidebar. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.c
Original PR description
Edit website select header and set scrolling effect as fixed. save. set header template as 'sidebar' scroll website. Website doesn't scroll properly . In this commit, fixed scrolling effect by setting the standard scrolling when scrolling type is fixed and header set as sidebar. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69219
… midnight Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77250
Original PR description
… midnight Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77250
Commit [1] migrated the old debug manager to the new OWL one. But is was missing a check, to actually ensure we are in debug mode before showing the icon. Without this fix, the debug icon is always shown, even if not in debug mode. [1]: https://github.com/odoo/odoo/commit/ce5599926af8cf2d69d3abbff0cb212b4af04473 Forward-Port-Of: odoo/odoo#77253
Original PR description
Commit [1] migrated the old debug manager to the new OWL one. But is was missing a check, to actually ensure we are in debug mode before showing the icon. Without this fix, the debug icon is always shown, even if not in debug mode. [1]: https://github.com/odoo/odoo/commit/ce5599926af8cf2d69d3abbff0cb212b4af04473 Forward-Port-Of: odoo/odoo#77253
The `image_256` field is computed (not stored) based on a dynamic resize of the stored `image_512`. When testing for the existence of an image value, the stored field should be used, to avoid processing the image and resizing it, then discarding the value immediately. Forward-Port-Of: odoo/odoo#77287
Original PR description
The `image_256` field is computed (not stored) based on a dynamic resize of the stored `image_512`. When testing for the existence of an image value, the stored field should be used, to avoid processing the image and resizing it, then discarding the value immediately. Forward-Port-Of: odoo/odoo#77287
Since commit [1], it crashed when, at the end of a tour, we tried to display a rainbow man, because we forgot to update the "type" key. 74dc3f654ee5849982b494e46eefb1fc2b4e0c74 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77274
Original PR description
Since commit [1], it crashed when, at the end of a tour, we tried to display a rainbow man, because we forgot to update the "type" key. 74dc3f654ee5849982b494e46eefb1fc2b4e0c74 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77274
Testing orderpoint generation assumes the whole test is done the same day. The assert could failed if the test is run right before midnight and end the day after. This commit ensure the time is frozen during all the tests about orderpoints generation Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: o
Original PR description
Testing orderpoint generation assumes the whole test is done the same day. The assert could failed if the test is run right before midnight and end the day after. This commit ensure the time is frozen during all the tests about orderpoints generation Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77280 Forward-Port-Of: odoo/odoo#77135
Previously, only the direct children of a recurrent tasks were copied during a recurrence. Also, the child tasks which had a recurrence were copied with the recurrence_id of the initial subtask, which lead the new subtask to be linked with the recurrence of the initial subtask. With this PR we copy the children until the 3rd layer. Also, we hard copy the recurrence of the initial subtask and link this new recurrence with the new subtask, to make it decoupled from the initial subtask rec
Original PR description
Previously, only the direct children of a recurrent tasks were copied during a recurrence. Also, the child tasks which had a recurrence were copied with the recurrence_id of the initial subtask, which lead the new subtask to be linked with the recurrence of the initial subtask. With this PR we copy the children until the 3rd layer. Also, we hard copy the recurrence of the initial subtask and link this new recurrence with the new subtask, to make it decoupled from the initial subtask recurrence. Furthermore, if several initial subtasks has been created with a same recurrence, only the first subtask is copied. PR: #77126 task-2522076 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77126
When attempting to mention a user or a channel, an RPC is performed. This uses a method on a model, which guests cannot perform as they don't have a valid session cookie. This commit deactivates the mention functionality for guests. Forward-Port-Of: odoo/odoo#77310
Original PR description
When attempting to mention a user or a channel, an RPC is performed. This uses a method on a model, which guests cannot perform as they don't have a valid session cookie. This commit deactivates the mention functionality for guests. Forward-Port-Of: odoo/odoo#77310
In odoo/odoo#76941 some getters were removed but the code using those getters was not entirely adapted, causing crashes. This commit also fixes an unrelated crash, where we were attempting to save the push-to-talk settings for guests, which cannot work as they do not have a correspoding user. Forward-Port-Of: odoo/odoo#77316
Original PR description
In odoo/odoo#76941 some getters were removed but the code using those getters was not entirely adapted, causing crashes. This commit also fixes an unrelated crash, where we were attempting to save the push-to-talk settings for guests, which cannot work as they do not have a correspoding user. Forward-Port-Of: odoo/odoo#77316
This fixes a performance issue: ORDER BY clauses in subqueries can make the query unexpectedly slow. We should avoid this situation, since ORM-generated queries have an ORDER BY clause which is not relevant in the context of a subquery. The following example was found: SELECT "pos_payment"."id" AS "id" FROM "pos_payment" WHERE ("pos_payment"."pos_order_id" in (SELECT "pos_order".id FROM "pos_order" WHERE ("pos_order"."c
Original PR description
This fixes a performance issue: ORDER BY clauses in subqueries can make the query unexpectedly slow. We should avoid this situation, since ORM-generated queries have an ORDER BY clause which is not…
This fixes a performance issue: ORDER BY clauses in subqueries can make
the query unexpectedly slow. We should avoid this situation, since
ORM-generated queries have an ORDER BY clause which is not relevant in
the context of a subquery.
The following example was found:
SELECT "pos_payment"."id" AS "id"
FROM "pos_payment"
WHERE ("pos_payment"."pos_order_id" in
(SELECT "pos_order".id
FROM "pos_order"
WHERE ("pos_order"."company_id" in (1))
ORDER BY "pos_order"."id"))
AND "pos_payment".id IN (1285508)
Here are the query plans made by PostgreSQL on this query with and
without the ORDER BY clause. The query time went from 1240ms to
0.402ms, which is 3000 times faster!
```
EXPLAIN ANALYZE SELECT "pos_payment"."id" as "id" FROM "pos_payment" WHERE ("pos_payment"."pos_order_id" in (SELECT "pos_order".id FROM "pos_order" WHERE ("pos_order"."company_id" in (1)) ORDER BY "pos_order"."id" )) AND "pos_payment".id IN (1285508);
QUERY PLAN
---------------------------------------------------------------------------------------------------------------------------------------------------
Merge Semi Join (cost=2.88..82726.85 rows=1 width=4) (actual time=1239.361..1239.364 rows=1 loops=1)
Merge Cond: (pos_payment.pos_order_id = pos_order.id)
-> Sort (cost=2.46..2.46 rows=1 width=8) (actual time=0.021..0.022 rows=1 loops=1)
Sort Key: pos_payment.pos_order_id
Sort Method: quicksort Memory: 25kB
-> Index Scan using pos_payment_pkey on pos_payment (cost=0.43..2.45 rows=1 width=8) (actual time=0.014..0.015 rows=1 loops=1)
Index Cond: (id = 1285508)
-> Index Scan using pos_order_pkey on pos_order (cost=0.43..66770.53 rows=1282120 width=4) (actual time=0.013..1148.194 rows=1182463 loops=1)
Filter: (company_id = 1)
Planning time: 0.272 ms
Execution time: 1239.396 ms
(11 rows)
EXPLAIN ANALYZE SELECT "pos_payment"."id" as "id" FROM "pos_payment" WHERE ("pos_payment"."pos_order_id" in (SELECT "pos_order".id FROM "pos_order" WHERE ("pos_order
"."company_id" in (1)) )) AND "pos_payment".id IN (1285508);
QUERY PLAN
------------------------------------------------------------------------------------------------------------------------------------
Nested Loop (cost=0.85..4.89 rows=1 width=4) (actual time=0.047..0.049 rows=1 loops=1)
-> Index Scan using pos_payment_pkey on pos_payment (cost=0.43..2.45 rows=1 width=8) (actual time=0.027..0.028 rows=1 loops=1)
Index Cond: (id = 1285508)
-> Index Scan using pos_order_pkey on pos_order (cost=0.43..2.45 rows=1 width=4) (actual time=0.018..0.018 rows=1 loops=1)
Index Cond: (id = pos_payment.pos_order_id)
Filter: (company_id = 1)
Planning time: 0.322 ms
Execution time: 0.080 ms
(8 rows)
```
Co-authored-by: Stanislas Sobieski (sts@odoo.com)
Forward-Port-Of: odoo/odoo#77234Description of the issue/feature this PR addresses: Add (back) the edition of description_done field on surveys Current behavior before PR: description_done field is not displayed on backend and therefore user cannot fill it. Desired behavior after PR is merged: description_done field is displayed to / editable by user -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76888
Original PR description
Description of the issue/feature this PR addresses: Add (back) the edition of description_done field on surveys Current behavior before PR: description_done field is not displayed on backend and therefore user cannot fill it. Desired behavior after PR is merged: description_done field is displayed to / editable by user -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#76888
Before this commit, if there were a change in the codeview of the field html and the record was saved while the codeview was still open, the changes made in the codeview were not saved. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77315
Original PR description
Before this commit, if there were a change in the codeview of the field html and the record was saved while the codeview was still open, the changes made in the codeview were not saved. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77315
Some browsers don't return a promise from mediaElement.play(), we wrap it in promise.resolve to solve the issue. Forward-Port-Of: odoo/odoo#77338
Original PR description
Some browsers don't return a promise from mediaElement.play(), we wrap it in promise.resolve to solve the issue. Forward-Port-Of: odoo/odoo#77338
Issue ----- Adding ('channel_partner_id', 'ilike', name) when searching for mail.channel.rtc.session does not filter out any record because the model mail.channel.partner does not define any _rec_name only the name_get Solution ------- Implement a _name_search method consistent with the name_get -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77340
Original PR description
Issue
-----
Adding ('channel_partner_id', 'ilike', name) when searching for
mail.channel.rtc.session does not filter out any record
because the model mail.channel.partner does not define any _rec_name
only the name_get
Solution
-------
Implement a _name_search method consistent with the name_get
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#77340Forward-Port-Of: odoo/odoo#77346
Original PR description
Forward-Port-Of: odoo/odoo#77346
Forward-Port-Of: odoo/odoo#77347
Original PR description
Forward-Port-Of: odoo/odoo#77347
Steps to reproduce: go to Planning > filter on 'employees on time off' or 'shifts in conflict' > open one of the resulting shifts Observed behavior: https://nimb.ws/xV8weW there is a grey area displayed below the warning Expected behavior: this grey area shouldn't be there task-2635074 Forward-Port-Of: odoo/enterprise#21174 Forward-Port-Of: odoo/enterprise#20550
Original PR description
Steps to reproduce: go to Planning > filter on 'employees on time off' or 'shifts in conflict' > open one of the resulting shifts Observed behavior: https://nimb.ws/xV8weW there is a grey area displayed below the warning Expected behavior: this grey area shouldn't be there task-2635074 Forward-Port-Of: odoo/enterprise#21174 Forward-Port-Of: odoo/enterprise#20550
Forward-Port-Of: odoo/enterprise#20965
Original PR description
Forward-Port-Of: odoo/enterprise#20965
Changing the partner, the referrer or commission plan of the referrer cannot change the commission plan of a confirmed SO. opw:2566419 Forward-Port-Of: odoo/enterprise#21115
Original PR description
Changing the partner, the referrer or commission plan of the referrer cannot change the commission plan of a confirmed SO. opw:2566419 Forward-Port-Of: odoo/enterprise#21115
Currently, when we connect as a timesheet user with the timesheet module and try to create a new timesheet entry, it throws an error because timesheet user does not have right to update the 'validated' field and due to inverse method of 'validated_status' it was going to update that field. So in this commit, remove the inverse method of the 'validated_status' as it was only used in statusbar to display the non-clickable statusbar. so no need to add the inverse method. TaskID: 2629541
Original PR description
Currently, when we connect as a timesheet user with the timesheet module and try to create a new timesheet entry, it throws an error because timesheet user does not have right to update the 'validated' field and due to inverse method of 'validated_status' it was going to update that field. So in this commit, remove the inverse method of the 'validated_status' as it was only used in statusbar to display the non-clickable statusbar. so no need to add the inverse method. TaskID: 2629541 Forward-Port-Of: odoo/enterprise#20735
This PR is a forward port of #21139 This commit fixes a multi-company issue with the timesheet timer widget. The domain filtering the selectable projects within the timesheet grid timer widget has been extended to only include projects in companies that are using hour encoding. Also prevents using the button at the start of the grid to start the timer on project which do not encode timesheets in hours. How to reproduces: - Have one company with timesheet encoding in hours, and one in
Original PR description
This PR is a forward port of #21139 This commit fixes a multi-company issue with the timesheet timer widget. The domain filtering the selectable projects within the timesheet grid timer widget has been extended to only include projects in companies that are using hour encoding. Also prevents using the button at the start of the grid to start the timer on project which do not encode timesheets in hours. How to reproduces: - Have one company with timesheet encoding in hours, and one in days - Create a project in the company with days encoding - Make the hour encoding company your main company - Activate the second company, so both are active - Start a timer and select the project created in the days encoding company Task ID: 2563519 X-original-commit: 6bc9e9f6e55e66c5db5576de8a92cb5ee62f74db Forward-Port-Of: odoo/enterprise#21177
Due to recent changes in the salary configurator the wage calculated when taking some time off was off everytime someone would sign. This was caused by a wrong order of operation in one of the formulaes to compute yearly costs. TaskId-2655671 Forward-Port-Of: odoo/enterprise#21157
Original PR description
Due to recent changes in the salary configurator the wage calculated when taking some time off was off everytime someone would sign. This was caused by a wrong order of operation in one of the formulaes to compute yearly costs. TaskId-2655671 Forward-Port-Of: odoo/enterprise#21157
ensure the tour are run without race conditions. Forward-Port-Of: odoo/enterprise#21120
Original PR description
ensure the tour are run without race conditions. Forward-Port-Of: odoo/enterprise#21120