Friday, October 15, 2021
29 changes · master
Enhancements to existing features
The packaging process now automatically shows the correct Odoo version in the Windows installer and handles missing RPM repository metadata more safely. This reduces manual release work and prevents build issues when preparing new Odoo versions.
Resolved issues and error corrections
The following modules: - l10n_de_purchase - l10n_de_repair - l10n_de_sale - l10n_de_stock Were renamed to: - l10n_din5008_purchase - l10n_din5008_repair - l10n_din5008_sale - l10n_din5008_stock The .po and .pot files will be generated anew, so the old ones can be removed. See odoo/odoo#76227 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
The following modules: - l10n_de_purchase - l10n_de_repair - l10n_de_sale - l10n_de_stock Were renamed to: - l10n_din5008_purchase - l10n_din5008_repair - l10n_din5008_sale - l10n_din5008_stock The .po and .pot files will be generated anew, so the old ones can be removed. See odoo/odoo#76227 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
The Time Off calendar code was reorganized to reduce duplication and make future changes easier to deliver. This supports better maintainability for calendar views used from employee records without changing the core business process.
Original PR description
task- 2643692 required customizing the calendar view to display a calendar from the employee form via the Time Off smart button. As the changes took place after the freeze of the saas-14.5 branch, it was not possible to split the time_off_calendar.js file into its different components to have them being re-used in time_off_calendar_employee.js file. Subsequently, some code duplication exists between the two files and makes it hard to maintain. This commit is for making the custom calendar components more modular and more maintainable. task-2661142 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
In mass mailing the link tools borders were not removed properly because the element couldn't be found inside the Iframe with a $() selector. Changed to use the `this.$link` of the `link_tool` class. task-2634073 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78385
Original PR description
In mass mailing the link tools borders were not removed properly because the element couldn't be found inside the Iframe with a $() selector. Changed to use the `this.$link` of the `link_tool` class. task-2634073 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78385
Module was not installable in some circumstances To reproduce: - Make Arabic and Arabic (Syria) languages active - Try installing l10n_sa ==> crash: "psycopg2.errors.CardinalityViolation: ON CONFLICT DO UPDATE command cannot affect row a second time" This was due to duplicate xmlid in the translation file. Forward-Port-Of: odoo/odoo#78283
Original PR description
Module was not installable in some circumstances
To reproduce:
- Make Arabic and Arabic (Syria) languages active
- Try installing l10n_sa
==> crash: "psycopg2.errors.CardinalityViolation: ON CONFLICT DO UPDATE command cannot affect row a second time"
This was due to duplicate xmlid in the translation file.
Forward-Port-Of: odoo/odoo#78283Translation files contained multiple instances of the same reference. This caused a traceback when loading the translations. Fixes: #68552 Forward-Port-Of: odoo/odoo#78398
Original PR description
Translation files contained multiple instances of the same reference. This caused a traceback when loading the translations. Fixes: #68552 Forward-Port-Of: odoo/odoo#78398
PR odoo/odoo#76376 made it so operations (of a BoM) can now be (un)archived in the list view. This commit makes it so we can also do the same in the form view as well as see the "Archived" ribbon in the form view. Part 3 of Task: 2660820 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77772
Original PR description
PR odoo/odoo#76376 made it so operations (of a BoM) can now be (un)archived in the list view. This commit makes it so we can also do the same in the form view as well as see the "Archived" ribbon in the form view. Part 3 of Task: 2660820 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77772
`_updateEditorUI` was reseting color to old or non css color value due to a race condition in the editor selection. task-2654666 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78210
Original PR description
`_updateEditorUI` was reseting color to old or non css color value due to a race condition in the editor selection. task-2654666 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78210
Description of the issue/feature this PR addresses: Removed service from rule-based delivery quantity. Current behavior before PR: Product of type service are accounted for when computing the quantity, weight and volume metrics used in the price computation of rule based delivery. Desired behavior after PR is merged: Service-type products should be excluded from such computations. opw-2647067 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-p
Original PR description
Description of the issue/feature this PR addresses: Removed service from rule-based delivery quantity. Current behavior before PR: Product of type service are accounted for when computing the quantity, weight and volume metrics used in the price computation of rule based delivery. Desired behavior after PR is merged: Service-type products should be excluded from such computations. opw-2647067 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78215
… product search Current situation in stock picking : Variant 1 : 'SoMething' Variant 2 : 'SomethingElse' Searching for 'SoMething' -> one result Searching for 'Something' -> two results Situation in generic product search : Variant 1 : 'SoMething' Variant 2 : 'SomethingElse' Searching for 'SoMething' -> two results Searching for 'Something' -> two results The fix make the product search in stock picking more consistent with the rest of Odoo. opw-2646214 -- I confirm I ha
Original PR description
… product search Current situation in stock picking : Variant 1 : 'SoMething' Variant 2 : 'SomethingElse' Searching for 'SoMething' -> one result Searching for 'Something' -> two results Situation in generic product search : Variant 1 : 'SoMething' Variant 2 : 'SomethingElse' Searching for 'SoMething' -> two results Searching for 'Something' -> two results The fix make the product search in stock picking more consistent with the rest of Odoo. opw-2646214 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78085
No task. Enterprise: https://github.com/odoo/enterprise/pull/21713 Forward-Port-Of: odoo/odoo#78429
Original PR description
No task. Enterprise: https://github.com/odoo/enterprise/pull/21713 Forward-Port-Of: odoo/odoo#78429
Process operations in wave transfers exists in community edition. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78116
Original PR description
Process operations in wave transfers exists in community edition. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78116
Recently, [1] broke the style of a few snippets, because it was adding a :not selector to the parent css class, that was used to define children classes that were adding a suffix to the parent class name with the & symbol. It was decided that every snippet css class should be explicitly declared to avoid breaking the style when adding selectors to the parent class. This will also prevent breaking the style when adding a new css version for the snippet. task-2660921 [1]: https://gi
Original PR description
Recently, [1] broke the style of a few snippets, because it was adding a :not selector to the parent css class, that was used to define children classes that were adding a suffix to the parent class name with the & symbol. It was decided that every snippet css class should be explicitly declared to avoid breaking the style when adding selectors to the parent class. This will also prevent breaking the style when adding a new css version for the snippet. task-2660921 [1]: https://github.com/odoo/odoo/pull/77312 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78357
In case an invoice is already paid it is useless to provide a QR Code for scanning to pay a residual of zero. **Description of the issue/feature this PR addresses:** If an invoice is already settled the QR Code is taking useless space on an invoice (report). **Current behavior before PR:** QR Code is always shown if the bank account is linked and has a valid QR Code **Desired behavior after PR is merged:** Only if the invoice is unpaid or has a residual it is shown on the invoice re
Original PR description
In case an invoice is already paid it is useless to provide a QR Code for scanning to pay a residual of zero. **Description of the issue/feature this PR addresses:** If an invoice is already settled the QR Code is taking useless space on an invoice (report). **Current behavior before PR:** QR Code is always shown if the bank account is linked and has a valid QR Code **Desired behavior after PR is merged:** Only if the invoice is unpaid or has a residual it is shown on the invoice report. Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78319 Forward-Port-Of: odoo/odoo#77997
web - If time off is for today then the calendar cell appears on white background. But it should be gray. project - project.project form view: remove the border under the 'description' notebook - project.task gantt view: the progress bar should start on the very left of the pill closes #78240 Task-ID: 2648148 Forward-Port-Of: odoo/odoo#78240
Original PR description
web - If time off is for today then the calendar cell appears on white background. But it should be gray. project - project.project form view: remove the border under the 'description' notebook - project.task gantt view: the progress bar should start on the very left of the pill closes #78240 Task-ID: 2648148 Forward-Port-Of: odoo/odoo#78240
How to reproduce the problem: - Install the website_slides modules - Go to the website -> Courses -> choose a course -> Add Content (Webpage) - In the new Webpage -> Edit -> Drag and drop a Form Builder -> Save The form is unusable: you can't write in the form's fields. Cause of the problem : usefull attributes and values of the form were removed due to the sanitizing of the HTML component. Solution : the HTML components in slide are not sanitized anymore, in order to keep valuable i
Original PR description
How to reproduce the problem: - Install the website_slides modules - Go to the website -> Courses -> choose a course -> Add Content (Webpage) - In the new Webpage -> Edit -> Drag and drop a Form Builder -> Save The form is unusable: you can't write in the form's fields. Cause of the problem : usefull attributes and values of the form were removed due to the sanitizing of the HTML component. Solution : the HTML components in slide are not sanitized anymore, in order to keep valuable information for building forms. Huuuge thanks to @abz-odoo for his great help on finding the bug <3 opw-2588089 Forward-Port-Of: odoo/odoo#77128
steps to reproduce the bug: - Go to inventory > products > Create a new Product from ```product.template``` - Assign two vendors to the record - Go to inventory > products > product variants > select the newly created product - Remove any vendor and save Problem: An error indicating that the record ```product.supplierinfo``` does not exist or has been deleted will be triggered In the ```product.product``` model, we have two One2Many fields ```seller_ids``` and ```variant_seller_ids```
Original PR description
steps to reproduce the bug: - Go to inventory > products > Create a new Product from ```product.template``` - Assign two vendors to the record - Go to inventory > products > product variants > select…
steps to reproduce the bug: - Go to inventory > products > Create a new Product from ```product.template``` - Assign two vendors to the record - Go to inventory > products > product variants > select the newly created product - Remove any vendor and save Problem: An error indicating that the record ```product.supplierinfo``` does not exist or has been deleted will be triggered In the ```product.product``` model, we have two One2Many fields ```seller_ids``` and ```variant_seller_ids``` which both point to ```product.supplierinfo```. When we save, the write method will be called and will first delete the seller with seller_ids and then try to update with variant_seller_ids but as both fields point to the same field, the seller will already be deleted and an access error will be thrown Solution: As the two fields are never displayed at the same time in the view. We can use the same invisibility condition to make them read only to prevent them from being both updated at the same time opw-2661082 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78431
Description of the issue/feature this PR addresses: In module `l10n_vn`, I think the translation is still incomplete. I'm Vietnamese, and I studied in accounting so i want to contribute translation file for it I hope you will check it out -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78459 Forward-Port-Of: odoo/odoo#77574
Original PR description
Description of the issue/feature this PR addresses: In module `l10n_vn`, I think the translation is still incomplete. I'm Vietnamese, and I studied in accounting so i want to contribute translation file for it I hope you will check it out -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78459 Forward-Port-Of: odoo/odoo#77574
Since commit [1], the filters were no longer tested by the clickbot because the DOM of the filter menu changed, and the clickbot selector hadn't been adapted. [1] https://github.com/odoo/odoo/commit/84715436d87bb05b421bc9ccaacda67d07571690 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#782
Original PR description
Since commit [1], the filters were no longer tested by the clickbot because the DOM of the filter menu changed, and the clickbot selector hadn't been adapted. [1] https://github.com/odoo/odoo/commit/84715436d87bb05b421bc9ccaacda67d07571690 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78284
Export studio customization will give you traceback if it contains server action. As we have removed ``channel_ids`` field from ``ir.actions.server`` by this commit: https://github.com/odoo/odoo/commit/1b0a6b7 But this field is still exist in one of the dictionary which tell studio to not export these fields. Forward-Port-Of: odoo/enterprise#21717
Original PR description
Export studio customization will give you traceback if it contains server action. As we have removed ``channel_ids`` field from ``ir.actions.server`` by this commit: https://github.com/odoo/odoo/commit/1b0a6b7 But this field is still exist in one of the dictionary which tell studio to not export these fields. Forward-Port-Of: odoo/enterprise#21717
Before this commit, there was a raise condition in the dashboard that could cause a crash. Sometimes, the call to the Chart.js lib to render the chart could have been done when the dashboard wasn't in the DOM yet. When this happenned, there was a crash in the lib as it tries to compute positions by looking into the DOM. This commit ensures that we wait to be inserted in the DOM before rendering the chart. This issue appears since [1] as with owl, the dashboard is inserted in the DOM
Original PR description
Before this commit, there was a raise condition in the dashboard that could cause a crash. Sometimes, the call to the Chart.js lib to render the chart could have been done when the dashboard wasn't in the DOM yet. When this happenned, there was a crash in the lib as it tries to compute positions by looking into the DOM. This commit ensures that we wait to be inserted in the DOM before rendering the chart. This issue appears since [1] as with owl, the dashboard is inserted in the DOM in the next animation frame (so a few ms after being rendered). [1] 29731b404fe624b733d784cd4321113d6b0d27b7 Forward-Port-Of: odoo/enterprise#21724
Correcting override of _validate_session opw-2666338 Forward-Port-Of: odoo/enterprise#21627
Original PR description
Correcting override of _validate_session opw-2666338 Forward-Port-Of: odoo/enterprise#21627
We only want the summary, and not the full country specific tax report when displaying the general ledger for one sale/purchase journal. [opw-2668955](https://www.odoo.com/web#id=2668955&model=project.task) Forward-Port-Of: odoo/enterprise#21716 Forward-Port-Of: odoo/enterprise#21694
Original PR description
We only want the summary, and not the full country specific tax report when displaying the general ledger for one sale/purchase journal. [opw-2668955](https://www.odoo.com/web#id=2668955&model=project.task) Forward-Port-Of: odoo/enterprise#21716 Forward-Port-Of: odoo/enterprise#21694
_* = helpdesk, project_timesheet_forecast, timesheet_grid, sale_plannig planning: - gantt view: the progress bar should start on the very left of the pill - fix the publish button visibility in planning industry_fsm_sale: - the domain should include the following types of products: consu, service with service_policy on delivered_manual, product helpdesk: - cannot assign a user to a helpdesk ticket closes #21629 task-2648148 Forward-Port-Of: odoo/enterprise#21629
Original PR description
_* = helpdesk, project_timesheet_forecast, timesheet_grid, sale_plannig planning: - gantt view: the progress bar should start on the very left of the pill - fix the publish button visibility in planning industry_fsm_sale: - the domain should include the following types of products: consu, service with service_policy on delivered_manual, product helpdesk: - cannot assign a user to a helpdesk ticket closes #21629 task-2648148 Forward-Port-Of: odoo/enterprise#21629
No task. Community: https://github.com/odoo/odoo/pull/78429 Forward-Port-Of: odoo/enterprise#21713
Original PR description
No task. Community: https://github.com/odoo/odoo/pull/78429 Forward-Port-Of: odoo/enterprise#21713
Steps to follow - Go to the Consolidation addon - Open studio -> The template throws an error: No enumerator given to foreach Cause of the issue field_values can be undefined Solution Replace field_values by an empty array if it's undefined opw-2649036 Forward-Port-Of: odoo/enterprise#21423
Original PR description
Steps to follow - Go to the Consolidation addon - Open studio -> The template throws an error: No enumerator given to foreach Cause of the issue field_values can be undefined Solution Replace field_values by an empty array if it's undefined opw-2649036 Forward-Port-Of: odoo/enterprise#21423
Problem: Traceback occurs when in projects - tasks - Gant View if you group by assigned to then project. This only occurs if there is no tasks that are unassigned if 1 task is unassigned it works as it should. Solution: Use an empty array by default instead of sending undefined OPW-2587882 Forward-Port-Of: odoo/enterprise#19445 Forward-Port-Of: odoo/enterprise#21630
Original PR description
Problem: Traceback occurs when in projects - tasks - Gant View if you group by assigned to then project. This only occurs if there is no tasks that are unassigned if 1 task is unassigned it works as it should. Solution: Use an empty array by default instead of sending undefined OPW-2587882 Forward-Port-Of: odoo/enterprise#19445 Forward-Port-Of: odoo/enterprise#21630
This fixes a few things related to the same goal: 1. domain for bom_ids was in incorrect module, leading to a stack track trying to filter a non-existant field. Steps to reproduce: - install quality_control (and NOT mrp) + try to click on "Quality Points" smart button in product form => stack track 2. domain also forgot to include non-operations related QCs, making it so all other QCs wouldn't show up. Steps to reproduce: - [after applying fix 1] create a QC (any non-Bo
Original PR description
This fixes a few things related to the same goal:
1. domain for bom_ids was in incorrect module, leading to a stack track
trying to filter a non-existant field. Steps to reproduce:
- install quality_control (and NOT mrp) + try to click on "Quality
Points" smart button in product form => stack track
2. domain also forgot to include non-operations related QCs, making it
so all other QCs wouldn't show up. Steps to reproduce:
- [after applying fix 1] create a QC (any non-BoM related one), click
on Product Form "Quality Points" smart button => nothing will show
3. count for "Quality Points" smart button forgot to take into account
non-operations related QCs. Steps to reproduce:
- same as fix 2, except # next to Quality Points = 0
Also did some small code cleanups (i.e. remove unused imports + cleanup
code syntax)
Part 1 of Task: 2660820
Related to PR: odoo/enterprise#20785
Forward-Port-Of: odoo/enterprise#21422During the automatic forward-port of 22d7ebd080034947f5692a4bbaa7f072a436ae0a Somehow, a firebase import was not removed properly. Since that library can be problematic because it's not available on every system, let us clean that unnecessary import. Task-2580462 Forward-Port-Of: odoo/enterprise#21684
Original PR description
During the automatic forward-port of 22d7ebd080034947f5692a4bbaa7f072a436ae0a Somehow, a firebase import was not removed properly. Since that library can be problematic because it's not available on every system, let us clean that unnecessary import. Task-2580462 Forward-Port-Of: odoo/enterprise#21684