Thursday, November 4, 2021
2 changes · master
Enhancements to existing features
Financial report control checks now cover more formula types, not just basic sum formulas. This helps businesses get more reliable report validations across positive, negative, and grouped calculations.
Original PR description
Currently, control domains only cover cases when the "formulas" field is "(-)sum". The goal is to be able to handle the other cases as well : - sum_if_pos(neg) - sum_if_pos(neg)_groupby
Resolved issues and error corrections
This fixes a display issue in the grid view where updated timesheet totals briefly appeared and then reverted to the previous value after selecting a cell. It helps users trust that the totals they see after entering time in days remain accurate and up to date.
Original PR description
Steps to reproduce: https://drive.google.com/file/d/1STB44wxVxkBCn-V4uIVMnI3TY7xJmj4R/view go to timesheets > settings > change the encoding unit to 'days' go to the 'all timesheets' menu and encode a few timesheets Observed behavior: when clicking on a cell, the new total is quickly displayed and then is reset to the previous value clicking on another cell makes the new total appear again Expected behavior: the new total should remain displayed after clicking on a cell This PR aims at having comprehensive tests to mimic the erratic behavior of the web_grid observed above. The tests are expected to fail but any fix brought to web_grid will hopefully fix them task-2522612