Monday, November 8, 2021
2 changes · master
Resolved issues and error corrections
This change removes an unnecessary import from the web testing helper code. It has no direct effect on users, but keeps the codebase cleaner and easier to maintain.
Original PR description
This commit removes a useless import from the tests helper. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The employee form now counts time off in the same way as the time off dashboard, including all requests that are not cancelled or refused. This avoids confusing differences between screens and gives managers and employees a more reliable view of remaining time off.
Original PR description
Description of the issue/feature this PR addresses: The holidays count on the employee form is not consistent with the count on the dashboard. The count on the employee form counts the holidays left based on the approved holiday. The count on the time off dashboard counts all the holidays that are not cancelled or refused. The time off counts should be consistent across the different screens. Current behavior before PR: The employee form smart button displays the count of time off based on the approved time off The time off dashboard displays the count of time off based on the time off that are not cancelled or refused Desired behavior after PR is merged: The count of time off is consistent across the different screens with the time off count based on the time off that are not cancelled or refused Task-2670658 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr