Monday, November 15, 2021
28 changes · master
Enhancements to existing features
This change makes it easier for developers to customize what happens when users click images in binary image fields. It supports more flexible extensions of the web interface without changing the standard user experience.
Original PR description
allow override handler in extended widget. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mail app now organizes attachment box actions in a dedicated internal model instead of keeping them in the display component. This makes the feature easier to maintain and helps support more reliable future improvements without changing the user experience.
Original PR description
Before this PR, attachment box event handlers where stored inside the attachment box component. This PR move the handlers inside a dedicated model. part of task-2579306
Resolved issues and error corrections
This update removes an unused styling marker from the company switching menu. It has no expected impact on user workflows, but keeps the web interface code cleaner and easier to maintain.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Forward-Port-Of: odoo/odoo#79676 Forward-Port-Of: odoo/odoo#79669
Original PR description
Forward-Port-Of: odoo/odoo#79676 Forward-Port-Of: odoo/odoo#79669
This fix stops users from creating time off allocations for leave types that do not require allocation. It helps keep HR records consistent and prevents unnecessary or incorrect allocation entries.
Original PR description
User should not be able to create allocations for Time Off Types that does not
requires allocation ('requires_allocation' is not 'yes').
task - 2658250
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update removes an unused styling marker from the mobile company switcher menu. It is a small cleanup that helps keep the web interface code simpler without changing how users interact with the system.
The error "ResizeObserver loop limit exceeded" was catch by the browser error global listener. this error was wrongly flagged as a CORS error. This error is well known to be useless and can safely be ignored. We do so. Task-2670745 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79571
Original PR description
The error "ResizeObserver loop limit exceeded" was catch by the browser error global listener. this error was wrongly flagged as a CORS error. This error is well known to be useless and can safely be ignored. We do so. Task-2670745 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79571
When selecting a link in the web editor, there were different glitches. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78301
Original PR description
When selecting a link in the web editor, there were different glitches. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78301
In the editor, there was a little spot where it was impossible to click in order to select a text. Task-2684378 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79355
Original PR description
In the editor, there was a little spot where it was impossible to click in order to select a text. Task-2684378 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79355
As an oversight of 2185e89e3f2a15b98b9cb8c3371a6031f9a6f055, it became impossible to move snippets. Task-2688281 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79633
Original PR description
As an oversight of 2185e89e3f2a15b98b9cb8c3371a6031f9a6f055, it became impossible to move snippets. Task-2688281 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79633
The commit 1b80fe9b56acea09a6784691561df65fe6349f50 made impossible to undo after dropping a snippet. Task-2688104 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79631
Original PR description
The commit 1b80fe9b56acea09a6784691561df65fe6349f50 made impossible to undo after dropping a snippet. Task-2688104 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79631
Steps to reproduce the bug: - Install POS - Go to the POS settings and enable “Gift Card” option - Create a new Gift card with initial amount of $50 - Open a new POS session > create an order of $50 and apply the gift card - Confirm the order > the order state becomes “paid” and the gift card balance is computed correctly: $0 Problem: Close the POS session, the order state becomes “done” and the balance is computed wrongly: $50 opw-2683523 -- I confirm I have signed the CLA
Original PR description
Steps to reproduce the bug: - Install POS - Go to the POS settings and enable “Gift Card” option - Create a new Gift card with initial amount of $50 - Open a new POS session > create an order of $50 and apply the gift card - Confirm the order > the order state becomes “paid” and the gift card balance is computed correctly: $0 Problem: Close the POS session, the order state becomes “done” and the balance is computed wrongly: $50 opw-2683523 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79701
The two fields (name & price) were only updated on pricelist (`product.pricelist`) save, not when the rules were updated (`product.pricelist.item`). The reason was that name and price are compute fields, which were added to the tree view but not added to the form view. This commit adds "name" and "price" to the `product.pricelist.item` form view and hence the values will be updated as soon as the popup form is saved. Fixes: #78488 -- I confirm I have signed the CLA and read the PR g
Original PR description
The two fields (name & price) were only updated on pricelist (`product.pricelist`) save, not when the rules were updated (`product.pricelist.item`). The reason was that name and price are compute fields, which were added to the tree view but not added to the form view. This commit adds "name" and "price" to the `product.pricelist.item` form view and hence the values will be updated as soon as the popup form is saved. Fixes: #78488 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78699
Updating the producing quantity may wrongly change the consumed quantity of tracked products To reproduce the issue: 1. Create two storable products P1, P2: - P2 is tracked by lots 2. Update P2's quantity >= 10 3. Create a BoM: - Product: P1 - Components: 1 x P2 4. Create and confirm a MO for 10 x P1 5. Check availability 6. Edit the MO and set the consumed quantity of P2 to 10 7. Edit the MO and set the producing quantity to 8 Error: The consumed quantity of P2 beco
Original PR description
Updating the producing quantity may wrongly change the consumed quantity
of tracked products
To reproduce the issue:
1. Create two storable products P1, P2:
- P2 is tracked by lots
2. Update P2's quantity >= 10
3. Create a BoM:
- Product: P1
- Components: 1 x P2
4. Create and confirm a MO for 10 x P1
5. Check availability
6. Edit the MO and set the consumed quantity of P2 to 10
7. Edit the MO and set the producing quantity to 8
Error: The consumed quantity of P2 becomes 1
When saving the MO, it also writes the `lot_ids` on `move_raw_ids` while
it shouldn't. As a result, it triggers method `_set_lot_ids` for no
reason and lead to an undesirable behavior.
OPW-2667412
Forward-Port-Of: odoo/odoo#79565Before this commit, it wasn't possible to save the volume of guests, the backend was already implemented but the feature hasn't been implemented in the frontend, this commit fixes this issue by completing the implementation. taskId-2679227 Forward-Port-Of: odoo/odoo#79131
Original PR description
Before this commit, it wasn't possible to save the volume of guests, the backend was already implemented but the feature hasn't been implemented in the frontend, this commit fixes this issue by completing the implementation. taskId-2679227 Forward-Port-Of: odoo/odoo#79131
Before this commit, granting the video permission when the call had already ended would generate a traceback. This commit fixes this issue. Forward-Port-Of: odoo/odoo#79702
Original PR description
Before this commit, granting the video permission when the call had already ended would generate a traceback. This commit fixes this issue. Forward-Port-Of: odoo/odoo#79702
Remove onbeforeunload pop-up if editor has no snippet. This fix pop-ups wrongly showing outside website editing. see: #79731 task-2666177 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79747
Original PR description
Remove onbeforeunload pop-up if editor has no snippet. This fix pop-ups wrongly showing outside website editing. see: #79731 task-2666177 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79747
Before this commit, it was possible to lock the transceivers of the streams when the remote was updating this stream. This commit fixes this issue. Forward-Port-Of: odoo/odoo#79750
Original PR description
Before this commit, it was possible to lock the transceivers of the streams when the remote was updating this stream. This commit fixes this issue. Forward-Port-Of: odoo/odoo#79750
Description of the issue/feature this PR addresses: When create expense product, it raise validation error. The issue was mandatory field of product was not available on form view. Fixes: #78498 Current behavior before PR:  Desired behavior after PR is merged: Able to create expense product. -- I confirm I have signed the
Original PR description
Description of the issue/feature this PR addresses: When create expense product, it raise validation error. The issue was mandatory field of product was not available on form view. Fixes: #78498 Current behavior before PR:  Desired behavior after PR is merged: Able to create expense product. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78750
The field contract_type_id is added in hr_contract, but is not present in the view. Why not a custom module to add this field in the view? The hr_contract is the base module, then, my custom module install it, but it need to set the contract type and the field is not present. The field cannot be added in the custom module, because some customers that use my module also needs hr_contract_salary, that adds the field in the view. Then, this is related with another PR in enterprise tha
Original PR description
The field contract_type_id is added in hr_contract, but is not present in the view. Why not a custom module to add this field in the view? The hr_contract is the base module, then, my custom module install it, but it need to set the contract type and the field is not present. The field cannot be added in the custom module, because some customers that use my module also needs hr_contract_salary, that adds the field in the view. Then, this is related with another PR in enterprise that removes the field from the view on that module. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79723
Description of the issue/feature this PR addresses: Make the is_css_preprocessed function return all attachments that meet the conditions. Current behavior before PR: When there are both .less and .scss files, The is_css_preprocessed function only returns the attachments of the last type (.less)，cause .scss attachment to never be deleted. Desired behavior after PR is merged: return all the attachments in the for loop #74952 -- I confirm I have signed the CLA and read the PR
Original PR description
Description of the issue/feature this PR addresses: Make the is_css_preprocessed function return all attachments that meet the conditions. Current behavior before PR: When there are both .less and .scss files, The is_css_preprocessed function only returns the attachments of the last type (.less)，cause .scss attachment to never be deleted. Desired behavior after PR is merged: return all the attachments in the for loop #74952 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79755 Forward-Port-Of: odoo/odoo#79458
Priori to this fix: * The domain provided to the invisible member of the attrs was wrong as it was using the '=' operator. After this fix: * The domain provided to the invisible member of the attrs is using the 'in' operator. task-2691562 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79793
Original PR description
Priori to this fix:
* The domain provided to the invisible member of the attrs was wrong
as it was using the '=' operator.
After this fix:
* The domain provided to the invisible member of the attrs is using
the 'in' operator.
task-2691562
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#79793In case of conflicts or uncovered work schedule, a too generic user error message is displayed, which is not useful enough to help find and solve the issue. We should add more information about the concerned time intervals in error. opw-2611123 Forward-Port-Of: odoo/enterprise#21949 Forward-Port-Of: odoo/enterprise#21814
Original PR description
In case of conflicts or uncovered work schedule, a too generic user error message is displayed, which is not useful enough to help find and solve the issue. We should add more information about the concerned time intervals in error. opw-2611123 Forward-Port-Of: odoo/enterprise#21949 Forward-Port-Of: odoo/enterprise#21814
Current behavior: When clicking on an analytic account it shows all the entries of the db Expected behavior: When clicking on an analytic account it should only show the entries for this account Steps top reproduce: Accounting ---> Reporting -----> Analytic report, click on an analytic account and click on analytic entries bug introduced by f546e1b overriding the domain set in the xml opw-2686516 Forward-Port-Of: odoo/enterprise#22242 Forward-Port-Of: odoo/enterprise#22240
Original PR description
Current behavior: When clicking on an analytic account it shows all the entries of the db Expected behavior: When clicking on an analytic account it should only show the entries for this account Steps top reproduce: Accounting ---> Reporting -----> Analytic report, click on an analytic account and click on analytic entries bug introduced by f546e1b overriding the domain set in the xml opw-2686516 Forward-Port-Of: odoo/enterprise#22242 Forward-Port-Of: odoo/enterprise#22240
The field contract_type_id is added in hr_contract, and now is added on the view of that module on https://github.com/odoo/odoo/pull/79723 Why not a custom module to add this field in the view? The hr_contract is the base module, then, my custom module install it, but it need to set the contract type and the field is not present. The field cannot be added in the custom module, because some customers that use my module also needs hr_contract_salary, that adds the field in the view. Fo
Original PR description
The field contract_type_id is added in hr_contract, and now is added on the view of that module on https://github.com/odoo/odoo/pull/79723 Why not a custom module to add this field in the view? The hr_contract is the base module, then, my custom module install it, but it need to set the contract type and the field is not present. The field cannot be added in the custom module, because some customers that use my module also needs hr_contract_salary, that adds the field in the view. Forward-Port-Of: odoo/enterprise#22239
Forward-Port-Of: odoo/enterprise#21801
Original PR description
Forward-Port-Of: odoo/enterprise#21801
Forward-Port-Of: odoo/enterprise#22037
Original PR description
Forward-Port-Of: odoo/enterprise#22037
Adding payroll structure and rules for KSA including end of services rules Forward-Port-Of: odoo/enterprise#21455
Original PR description
Adding payroll structure and rules for KSA including end of services rules Forward-Port-Of: odoo/enterprise#21455