Wednesday, November 17, 2021
1 change · master
Resolved issues and error corrections
Approved expense reports now prevent changes to their expense lines. This helps protect validated accounting information from accidental or unauthorized edits after manager approval.
Original PR description
Expected Behaviour When creating a journal entry for an expense, the journal shouldn't be editable once it has been submitted for approval. Observed Behaviour Even when the journal entry has been validated by the manager, the list of expenses is still editable, which can cause serious trouble. Reproducibility This bug can be reproduced following these steps: - Create a new expense - Create the related journal entry (Create report) - Submit the report for approval - Validate the report - Try to edit the expenses list Problem Root Cause As it can be seen in the PR, this issue came from the fact the expense list isn't in read-only mode Related Issue(s) opw-2659436 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr