Thursday, November 18, 2021
37 changes · master
Enhancements to existing features
Odoo Mail has removed an old text editing component that was no longer being used. This cleanup reduces unnecessary code and helps keep the mail module easier to maintain without changing the user experience.
Original PR description
It was no longer used.
Resolved issues and error corrections
This fix updates customer-facing wording so Customer 97 is no longer described in an insulting way. It helps avoid upsetting customers and supports a more respectful experience in the accounting area.
Original PR description
Description of the issue/feature this PR addresses: Poor customer 97 is being called dumb Current behavior before PR: Customer 97 is upset Desired behavior after PR is merged: Customer 97 is happy -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
When a backorder is created, the quantities are not reserved. This is an issue: the module should try to directly assign these quantities if the reservation method of the associated operation type is "At Confirmation" (Forward port of 723d4b35f9fa9c49249c1b4e9b8dc93e51c5d359) OPW-2658469 Forward-Port-Of: odoo/odoo#79873
Original PR description
When a backorder is created, the quantities are not reserved. This is an issue: the module should try to directly assign these quantities if the reservation method of the associated operation type is "At Confirmation" (Forward port of 723d4b35f9fa9c49249c1b4e9b8dc93e51c5d359) OPW-2658469 Forward-Port-Of: odoo/odoo#79873
This fix prevents existing analytic accounting values from being overwritten during account-related processing. It helps keep financial allocation data accurate while accounting for a small expected change in performance checks.
Original PR description
In [1], the analytic values are not computed together anymore, leading to a few more queries. [1] https://github.com/odoo/odoo/commit/676c568aeac2a9093eedac31daa6964f0b9e140b
Analytic Accounts can be defined in the MO and can be changed in any MO stage. So the analytic account lines will also have to be updated to be linked to the new AA opw-2674347 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79614
Original PR description
Analytic Accounts can be defined in the MO and can be changed in any MO stage. So the analytic account lines will also have to be updated to be linked to the new AA opw-2674347 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79614
Before this commit, the behavior disabling the unsed snippet assets was put directly in the autovaccum CRON instead of its own CRON. That behavior is leading to some perf-issue running the autovaccum cron since it would take too much time. Indeed, the code will loop inside as many snippet as it exists, and every time then perform an SQL Query to get the HTML fields using the snippet. An improvement will come later to not loop on every snippet anymore. task-2694120 Forward-Port-Of:
Original PR description
Before this commit, the behavior disabling the unsed snippet assets was put directly in the autovaccum CRON instead of its own CRON. That behavior is leading to some perf-issue running the autovaccum cron since it would take too much time. Indeed, the code will loop inside as many snippet as it exists, and every time then perform an SQL Query to get the HTML fields using the snippet. An improvement will come later to not loop on every snippet anymore. task-2694120 Forward-Port-Of: odoo/odoo#79951
In one week, this test failed about 6 times, seems mainly on nightly enterprise. Let us update counter accordingly. Forward-Port-Of: odoo/odoo#79961
Original PR description
In one week, this test failed about 6 times, seems mainly on nightly enterprise. Let us update counter accordingly. Forward-Port-Of: odoo/odoo#79961
This commit fixes and improves the suggested width that we compute for images optimizations. Before, images displayed outside .container elements were resized to their container size. As a result logos were resized to 2.5rem (40px). Now, it handles these scenarios : - The image is in the navbar, it is a logo - The image is in a container/container-small - The image is in a container-fluid - The image is outside a container Values are read from the css instead of being hardcoded.
Original PR description
This commit fixes and improves the suggested width that we compute for images optimizations. Before, images displayed outside .container elements were resized to their container size. As a result logos were resized to 2.5rem (40px). Now, it handles these scenarios : - The image is in the navbar, it is a logo - The image is in a container/container-small - The image is in a container-fluid - The image is outside a container Values are read from the css instead of being hardcoded. Note : another issue remains with our resizing method. Drawing on a canvas is not performant enough when there are large differences between the width and the resize width. A solution could be to use createImageBitmap for the resize, but it is not supported by enough browsers. In the meantime, imageSmoothing was enabled on the context. task-2506205 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72872
Steps to reproduce the bug: - Enable analytic accounting and analytic tags - Create a new analytic default to specify a product. Add an account and some tags - Create a new SO that triggers a replenishment rule for a PO The created PO does not have any analytic accounts or tags attached to it. Inspired from 14.0 opw:2585348 Forward-Port-Of: odoo/odoo#77686 Forward-Port-Of: odoo/odoo#76940
Original PR description
Steps to reproduce the bug: - Enable analytic accounting and analytic tags - Create a new analytic default to specify a product. Add an account and some tags - Create a new SO that triggers a replenishment rule for a PO The created PO does not have any analytic accounts or tags attached to it. Inspired from 14.0 opw:2585348 Forward-Port-Of: odoo/odoo#77686 Forward-Port-Of: odoo/odoo#76940
Steps to reproduce the bug: - Let's consider a delivery carrier DC with invoice policy = 'real' - Let's consider a consumable product P with a weight = 1kg and sales price = 10€ - Create a sale order SO with 2 P and add DC as shipping cost - Process the shipment for 1 P and create a backorder - Process the second shipment with the last P Bug: Two lines L1, L2 with DC were created on SO but only L1 as a price unit and a description. L2 had a price unit = 0€ and no description. op
Original PR description
Steps to reproduce the bug: - Let's consider a delivery carrier DC with invoice policy = 'real' - Let's consider a consumable product P with a weight = 1kg and sales price = 10€ - Create a sale order SO with 2 P and add DC as shipping cost - Process the shipment for 1 P and create a backorder - Process the second shipment with the last P Bug: Two lines L1, L2 with DC were created on SO but only L1 as a price unit and a description. L2 had a price unit = 0€ and no description. opw:2520135 Co-authored-by: simongoffin <sig@odoo.com> Forward-Port-Of: odoo/odoo#70454
This commit moves the ZXing library (used for QR/Barcode decoding) from `web_enterprise` to `web` so it can be reused in other modules. Change motivated by odoo/odoo#78204 Forward-Port-Of: odoo/odoo#79991
Original PR description
This commit moves the ZXing library (used for QR/Barcode decoding) from `web_enterprise` to `web` so it can be reused in other modules. Change motivated by odoo/odoo#78204 Forward-Port-Of: odoo/odoo#79991
To be able to copy an attachement, we need to be have write access on the linked record. In this wizard, write access on mail.template is then required which is no longer the case since cc012a086464e88f7ede1e5 Read access on the template is already checked when reading the values of the tempate. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79888
Original PR description
To be able to copy an attachement, we need to be have write access on the linked record. In this wizard, write access on mail.template is then required which is no longer the case since cc012a086464e88f7ede1e5 Read access on the template is already checked when reading the values of the tempate. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79888
Before this commit, the style of the pager in a grouped list was a little off. - The colors of the previous/next buttons were too dark in enterprise (because of: odoo/enterprise@f26203eb2472bef48cc0fd57dff766ada5a598d2) - The pager's input lost its alignment. After this commit, the situation is much better, colors are okay and the pager's input doesn't jump randomly somewhere else. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior aft
Original PR description
Before this commit, the style of the pager in a grouped list was a little off. - The colors of the previous/next buttons were too dark in enterprise (because of: odoo/enterprise@f26203eb2472bef48cc0fd57dff766ada5a598d2) - The pager's input lost its alignment. After this commit, the situation is much better, colors are okay and the pager's input doesn't jump randomly somewhere else. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79970
The field `invoice_policy` on the product model is defined in the module `sale`. So if you run the tests with only “purchase_stock” installed on the DB, an error will be thrown. Bug introduced by this commit: https://github.com/odoo/odoo/pull/75886/commits/72955411964440747125e7c9d00ef952bc69a80e#diff-f3237d6d25dc46b109ec461ad910dd4cf6f5c6572e29e1b7eedbd9cfa63cb5c2R22 opw-2685389 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Por
Original PR description
The field `invoice_policy` on the product model is defined in the module `sale`. So if you run the tests with only “purchase_stock” installed on the DB, an error will be thrown. Bug introduced by this commit: https://github.com/odoo/odoo/pull/75886/commits/72955411964440747125e7c9d00ef952bc69a80e#diff-f3237d6d25dc46b109ec461ad910dd4cf6f5c6572e29e1b7eedbd9cfa63cb5c2R22 opw-2685389 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79772
If we have two companies A and B with B selected and we try to access the Forecast Report via a product, company A's warehouse is automatically selected, which of course creates a security error. This fix modifies the ´get_warehouses´ method in order to return only the warehouses whose company is selected. opw-2688135 Forward-Port-Of: odoo/odoo#79992
Original PR description
If we have two companies A and B with B selected and we try to access the Forecast Report via a product, company A's warehouse is automatically selected, which of course creates a security error. This fix modifies the ´get_warehouses´ method in order to return only the warehouses whose company is selected. opw-2688135 Forward-Port-Of: odoo/odoo#79992
This commit reverts 0fff5b03270a88ab0f994bfa1ee780628607ce77 as it fetches all the records which is a bad idea. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80002
Original PR description
This commit reverts 0fff5b03270a88ab0f994bfa1ee780628607ce77 as it fetches all the records which is a bad idea. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80002
Whenever the link tooltip hide, the tooltip of the buttons could remain in the page but shouldn't. Task-2692301 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79856
Original PR description
Whenever the link tooltip hide, the tooltip of the buttons could remain in the page but shouldn't. Task-2692301 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79856
On an html field whenever selecting only text that contain an url and opening the link dialog, the url was not reused. Task-2580485 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79869
Original PR description
On an html field whenever selecting only text that contain an url and opening the link dialog, the url was not reused. Task-2580485 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79869
When trying to drop a snippet that could not be possibly dropped, a traceback is shown but shouldn't. Task-2692492 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79876
Original PR description
When trying to drop a snippet that could not be possibly dropped, a traceback is shown but shouldn't. Task-2692492 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79876
There is a fix in the editor to fix link selection (see _fixLinkMutatedElements). Prior to this commit, in mass mailing the main editable element had the class `o_not_editable`. This class on the editable disabled the link fix. Also, it was semantically strange to have the editable being `o_not_editable`. Task-2684360 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79393
Original PR description
There is a fix in the editor to fix link selection (see _fixLinkMutatedElements). Prior to this commit, in mass mailing the main editable element had the class `o_not_editable`. This class on the editable disabled the link fix. Also, it was semantically strange to have the editable being `o_not_editable`. Task-2684360 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79393
Before this commit, the link could be removed from the DOM before hiding the query popover. After being removed, the reference of the popover from the jquery element was lost. We now keep the reference to the popover to always be able to hide it. Task-2684819 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79765
Original PR description
Before this commit, the link could be removed from the DOM before hiding the query popover. After being removed, the reference of the popover from the jquery element was lost. We now keep the reference to the popover to always be able to hide it. Task-2684819 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79765
When a user was opening the payment_link_wizard and tried to select a preferred payment acquirer, he was getting an AccessError telling that he was not allowed to access 'payment.acquirer' records. Fix PR #69334 (task-2504225) task-2666881 Forward-Port-Of: odoo/odoo#78334
Original PR description
When a user was opening the payment_link_wizard and tried to select a preferred payment acquirer, he was getting an AccessError telling that he was not allowed to access 'payment.acquirer' records. Fix PR #69334 (task-2504225) task-2666881 Forward-Port-Of: odoo/odoo#78334
Prior to this commit, the `tasks_analysis` information was added to the panel data dict but never used clientside. This commit removes this useless call to avoid a Traceback on large projects, with lots of tasks (MemoryError). task-2694765 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80011
Original PR description
Prior to this commit, the `tasks_analysis` information was added to the panel data dict but never used clientside. This commit removes this useless call to avoid a Traceback on large projects, with lots of tasks (MemoryError). task-2694765 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80011
A wrong company was used in the Kiosk mode, preventing users to check in / out. TaskID: 2691031 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79853
Original PR description
A wrong company was used in the Kiosk mode, preventing users to check in / out. TaskID: 2691031 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79853
Before this commit the default template for mega menus was the "Multi Menus" template. After this commit the default template for mega menus is the "Odoo Menu" template. task-2675252 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78924
Original PR description
Before this commit the default template for mega menus was the "Multi Menus" template. After this commit the default template for mega menus is the "Odoo Menu" template. task-2675252 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78924
The domain on the allocation leave type was too restrictive for Time Off Officer and they couldn't create allocations when the "Employee Requests" of the Time Off Type was set to "no". This commit allows the Time Off Officer to request those allocations again. TaskID: 2694163 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/
Original PR description
The domain on the allocation leave type was too restrictive for Time Off Officer and they couldn't create allocations when the "Employee Requests" of the Time Off Type was set to "no". This commit allows the Time Off Officer to request those allocations again. TaskID: 2694163 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79959
Before this commit saving an incomplete link dialog triggered the display of a stacktrace error popup. After this commit saving is cancelled when an attempt at saving an incomplete link dialog is done. The incorrect fields already did display their error status. task-2675252 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/s
Original PR description
Before this commit saving an incomplete link dialog triggered the display of a stacktrace error popup. After this commit saving is cancelled when an attempt at saving an incomplete link dialog is done. The incorrect fields already did display their error status. task-2675252 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78916
In some cases, it is not possible to print the order changes To reproduce the issue: (Use demo data) 1. Point of Sale > Configuration > Order Printers, edit Kitchen Printer: - Printed Product Categories: Food 2. Edit the POS Bar: - Enable Order Printer 3. Start a session of POS Bar 4. Open table T1 5. Select a Food product and add a note 6. Submit the order to the kitchen 7. Select again the same product without any note Error: The order button isn't green, it is not poss
Original PR description
In some cases, it is not possible to print the order changes To reproduce the issue: (Use demo data) 1. Point of Sale > Configuration > Order Printers, edit Kitchen Printer: - Printed Product…
In some cases, it is not possible to print the order changes
To reproduce the issue:
(Use demo data)
1. Point of Sale > Configuration > Order Printers, edit Kitchen Printer:
- Printed Product Categories: Food
2. Edit the POS Bar:
- Enable Order Printer
3. Start a session of POS Bar
4. Open table T1
5. Select a Food product and add a note
6. Submit the order to the kitchen
7. Select again the same product without any note
Error: The order button isn't green, it is not possible to sent the
second order line to the kitchen
The issue comes from the logic used in `computeChanges`:
https://github.com/odoo/odoo/blob/75fb0aa6e9c314b61b30d49b5c463fa126dfc835/addons/pos_restaurant/static/src/js/multiprint.js#L215-L222
`old_res` contains the products already sent to the kitchen
As a result, since the line from step 5 and the one from step 7 have the
same product, we consider that the new line (step 7) was already
present. Then, when comparing the quantities, both lines have their
quantity equal to 1, so we consider there isn't any information that
should be sent to the kitchen
OPW-2557518
Forward-Port-Of: odoo/odoo#79526Some transactions can include charges in their total amount. If some are found, we must only look in the corresponding element including them, otherwise the retrieved amount will be incorrect and the closing balance won't match either. opw-2632582 Forward-Port-Of: odoo/enterprise#22342 Forward-Port-Of: odoo/enterprise#22206
Original PR description
Some transactions can include charges in their total amount. If some are found, we must only look in the corresponding element including them, otherwise the retrieved amount will be incorrect and the closing balance won't match either. opw-2632582 Forward-Port-Of: odoo/enterprise#22342 Forward-Port-Of: odoo/enterprise#22206
When effects are disabled, the fallback message was incorrect. This commit applies a fix to give the user more information using the standard notification Forward-Port-Of: odoo/enterprise#22339
Original PR description
When effects are disabled, the fallback message was incorrect. This commit applies a fix to give the user more information using the standard notification Forward-Port-Of: odoo/enterprise#22339
It was mistakenly removed here https://github.com/odoo/enterprise/commit/6289902310ff7d7c588b9363f2838c112e85d267 [opw-2646290](https://www.odoo.com/web#id=2646290&model=project.task&view_type=form&cids=1&menu_id=) Forward-Port-Of: odoo/enterprise#20858
Original PR description
It was mistakenly removed here https://github.com/odoo/enterprise/commit/6289902310ff7d7c588b9363f2838c112e85d267 [opw-2646290](https://www.odoo.com/web#id=2646290&model=project.task&view_type=form&cids=1&menu_id=) Forward-Port-Of: odoo/enterprise#20858
latam 666 / adhoc 44541 --- Only do dummy validation if there is not CAE Number set yet. This way we are avoiding setting a DUMMY CAE number into a real CAE number in a backup/copy database from production. Forward-Port-Of: odoo/enterprise#22147
Original PR description
latam 666 / adhoc 44541 --- Only do dummy validation if there is not CAE Number set yet. This way we are avoiding setting a DUMMY CAE number into a real CAE number in a backup/copy database from production. Forward-Port-Of: odoo/enterprise#22147
Purpose ======= Next activities on res_id = 0 leads to a traceback. Forward-Port-Of: odoo/enterprise#22308
Original PR description
Purpose ======= Next activities on res_id = 0 leads to a traceback. Forward-Port-Of: odoo/enterprise#22308
Have a 0% Exento Tax Create an invoice with just a line, featuring the said tax Invoice and send for validation The document will not pass validation, TasaOCuota and Importe attributes should not be present for Exento taxes opw-2680903 Forward-Port-Of: odoo/enterprise#22262
Original PR description
Have a 0% Exento Tax Create an invoice with just a line, featuring the said tax Invoice and send for validation The document will not pass validation, TasaOCuota and Importe attributes should not be present for Exento taxes opw-2680903 Forward-Port-Of: odoo/enterprise#22262
Steps to reproduce the bug: - Go to Manufacturing configuration - Enable Master Production Schedule and set Number of Columns to 10 - Save Bug: Number of Columns was still 12 opw:2451760 Forward-Port-Of: odoo/enterprise#17500
Original PR description
Steps to reproduce the bug: - Go to Manufacturing configuration - Enable Master Production Schedule and set Number of Columns to 10 - Save Bug: Number of Columns was still 12 opw:2451760 Forward-Port-Of: odoo/enterprise#17500
The module l10n_sa_hr_payroll is missing the dependency on l10n_sa and the flag auto_install. Meaning that it will not install itself when payroll and the saudi localization is installed Forward-Port-Of: odoo/enterprise#22268
Original PR description
The module l10n_sa_hr_payroll is missing the dependency on l10n_sa and the flag auto_install. Meaning that it will not install itself when payroll and the saudi localization is installed Forward-Port-Of: odoo/enterprise#22268
The following condition in the _analyze_sii_result_method is wrong since folio is the l10n_latam_document_number instead of the l10n_latam_document_type_id.code `doc['folio'] == int(self.l10n_latam_document_type_id.code)` More info -> https://www4c.sii.cl/bolcoreinternetui/api/ Forward-Port-Of: odoo/enterprise#22207
Original PR description
The following condition in the _analyze_sii_result_method is wrong since folio is the l10n_latam_document_number instead of the l10n_latam_document_type_id.code `doc['folio'] == int(self.l10n_latam_document_type_id.code)` More info -> https://www4c.sii.cl/bolcoreinternetui/api/ Forward-Port-Of: odoo/enterprise#22207