Monday, November 22, 2021
30 changes · master
Enhancements to existing features
This pull request adds proof-of-concept technical documentation for core product and inventory areas, including examples for the stock module. It helps teams understand and maintain these Odoo apps more easily, with no direct change expected for day-to-day users.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update makes a small internal adjustment to the Mail/Discuss interface so it aligns with requirements for a future framework upgrade. It helps keep the messaging experience reliable and easier to maintain, with no expected change for day-to-day users.
Original PR description
In preparation to using OWL v2 in discuss code Task-2695901
The bank account connection setup wizard has been simplified by removing outdated fields that were no longer used. This reduces internal clutter and helps keep the accounting synchronization flow easier to maintain without changing the user experience.
Original PR description
Remove two fields that were made deprecated and are no longer used in the account link wizard. task id #2691087
Resolved issues and error corrections
This update adjusts an internal CRM performance test so it matches expected database activity more accurately. It helps reduce false test failures in automated checks, supporting smoother maintenance and more reliable releases.
Original PR description
In one week, this test failed about 4 times, seems mainly on nightly enterprise. Let us update counter accordingly.
Miscellaneous changes
The fields `employee_type` and `user_id` were not properly replaced in the view. TaskID: 2694143 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79957
Original PR description
The fields `employee_type` and `user_id` were not properly replaced in the view. TaskID: 2694143 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79957
The sales order button on project updates now opens correctly instead of showing an error. This prevents disruption for users checking related sales orders from project status updates.
Original PR description
Currently, when we click on 'sales order' stat button of 'project.update' it shows traceback because action name is incorrect. In this commit, action is renamed-[odoo@3d10c7c](https://github.com/odoo/odoo/commit/3d10c7c70884993f1290a4fd430a1c52247a8420# ) closes #79739 task-2689432
This fixes an issue where the Message tab was not shown when users selected the send SMS option in account follow-up workflows. The change ensures users can access the expected message content area, reducing confusion when preparing customer follow-up communications.
Original PR description
Oversight of commit https://github.com/odoo/enterprise/commit/9cf821ee0485373a4674bff1c5f8f3bdc2527075 Task: 2669223
Steps to reproduce the issue: - Install "eCommerce" module - Create 2 attributes with 'Variants Creation Mode' is Never and one of them should have at least 2 values. - Create a product and add the two attributes as variants and one of them should have at least one value - Go to configure variant and select the first attribute and exclude one or more values from the second variant - Go to the website and change the variant to a value from the one you excluded and add to the ca
Original PR description
Steps to reproduce the issue:
- Install "eCommerce" module
- Create 2 attributes with 'Variants Creation Mode' is Never and
one of them should have at least 2 values.
- Create a product and add the two attributes as variants and
one of them should have at least one value
- Go to configure variant and select the first attribute and
exclude one or more values from the second variant
- Go to the website and change the variant to a value from the one
you excluded and add to the cart directly (you should be fast).
Issue:
Product with a not possible combination is added to cart.
Cause:
Not checking if the combination is possible before adding to cart.
Solution:
When adding product to cart, trigger _getCombinationInfo to retrieve
last combination info, then add it only if the combination is
possible.
opw-2569109
Forward-Port-Of: odoo/odoo#80032
Forward-Port-Of: odoo/odoo#79780Steps to reproduce the bug: - Create a BOM: - set the quantity of the finished product and component as more than 1 - save > print > BOM Structure Problem: The report generated shows the qty and cost for production of 1 unit of product, regardless of the BOM quantity opw-2691632 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80132 Forward-Port-Of: odoo/odoo#80093
Original PR description
Steps to reproduce the bug:
- Create a BOM:
- set the quantity of the finished product and component as more than 1
- save > print > BOM Structure
Problem:
The report generated shows the qty and cost for production of 1 unit of product, regardless of the BOM quantity
opw-2691632
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#80132
Forward-Port-Of: odoo/odoo#80093Steps to reproduce the problem: - Create a storable product tracked by a unique serial number. - use the product in a delivery - try to print the "Picking Operations" document Problem: Traceback is triggered because we cannot use two fields in a "t-field" opw-2692226 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80117
Original PR description
Steps to reproduce the problem: - Create a storable product tracked by a unique serial number. - use the product in a delivery - try to print the "Picking Operations" document Problem: Traceback is triggered because we cannot use two fields in a "t-field" opw-2692226 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80117
Before this commit, the "import module" feature of 'base_import_module' was broken since the imported module's manifest was lost after the import was performed. Now, 'ir.asset' records are created along with the attachments pointing to the imported static files. Forward-Port-Of: odoo/odoo#80039 Forward-Port-Of: odoo/odoo#79392
Original PR description
Before this commit, the "import module" feature of 'base_import_module' was broken since the imported module's manifest was lost after the import was performed. Now, 'ir.asset' records are created along with the attachments pointing to the imported static files. Forward-Port-Of: odoo/odoo#80039 Forward-Port-Of: odoo/odoo#79392
On large databases, the `postcommit` hook for Google|Microsoft Calendar was taking up to 10% of a leave validation even if the user has the sync disabled. This commit disables the postcommit hook for new leaves, as the event will be synced through the cron eventually. TaskID: 2693265 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.o
Original PR description
On large databases, the `postcommit` hook for Google|Microsoft Calendar was taking up to 10% of a leave validation even if the user has the sync disabled. This commit disables the postcommit hook for new leaves, as the event will be synced through the cron eventually. TaskID: 2693265 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79952
Description of the issue/feature this PR addresses: during the upgrade process, the database was failed and errors show like `ERROR: column reference "state" is ambiguous` Current behavior before PR: Not working during the upgrade process. (ref. below pad) https://pad.odoo.com/p/upgarde_request_42960_issue Desired behavior after PR is merged: it's working after changes are done in this query. (DB successes) upg-42960 Opw-2674714 Contract number: M10100561-kiticugt Forward-Port-Of
Original PR description
Description of the issue/feature this PR addresses: during the upgrade process, the database was failed and errors show like `ERROR: column reference "state" is ambiguous` Current behavior before PR: Not working during the upgrade process. (ref. below pad) https://pad.odoo.com/p/upgarde_request_42960_issue Desired behavior after PR is merged: it's working after changes are done in this query. (DB successes) upg-42960 Opw-2674714 Contract number: M10100561-kiticugt Forward-Port-Of: odoo/odoo#79074
…del button Steps to reproduce: - Create a journal with a custom currency - Create a statement line - Create a reconciliation model button putting the residual to a random account - Reconcile the statement line using the button => The amount lands inside the debit/credit instead of amount_currency Introduced by: https://github.com/odoo/odoo/commit/5ad660877f485d741a0120e07eb73178f59d2dfc# -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr For
Original PR description
…del button Steps to reproduce: - Create a journal with a custom currency - Create a statement line - Create a reconciliation model button putting the residual to a random account - Reconcile the statement line using the button => The amount lands inside the debit/credit instead of amount_currency Introduced by: https://github.com/odoo/odoo/commit/5ad660877f485d741a0120e07eb73178f59d2dfc# -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80099
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80105
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80105
Forward-Port-Of: odoo/odoo#79859
Original PR description
Forward-Port-Of: odoo/odoo#79859
Whenever the qweb plugin modified the dom for rendering purposes, the mutations were observed but shouldn't. The reason was that the reference to the editor was missing in the plugin and therfore it did not call `observerUnactive` and `observerActive`. Task-2695658 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80163
Original PR description
Whenever the qweb plugin modified the dom for rendering purposes, the mutations were observed but shouldn't. The reason was that the reference to the editor was missing in the plugin and therfore it did not call `observerUnactive` and `observerActive`. Task-2695658 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80163
…into account in project overview profitability Reproduce : - Install modules Purchase, Accounting, Project, Sales Timesheet - In Accounting settings, activate option Analytic Account - Create a Project and link it with an Analytic Account - Create a PO then Vendor Bill with this Analytic Account - Check the Overview for the Project associated with that Analytic Account - The amount of the bill will show in the "Other Costs" field of the Profitability section - Go back and add a Cred
Original PR description
…into account in project overview profitability Reproduce : - Install modules Purchase, Accounting, Project, Sales Timesheet - In Accounting settings, activate option Analytic Account - Create a…
…into account in project overview profitability Reproduce : - Install modules Purchase, Accounting, Project, Sales Timesheet - In Accounting settings, activate option Analytic Account - Create a Project and link it with an Analytic Account - Create a PO then Vendor Bill with this Analytic Account - Check the Overview for the Project associated with that Analytic Account - The amount of the bill will show in the "Other Costs" field of the Profitability section - Go back and add a Credit Note for the vendor bill Issue : - The amount of the PO still shows in the "Other Costs" section, where it is expected to be balanced (zeroed) by the Credit Note. Solution : - Don't take into account the Vendor Bills for whioch a Credit Note exists. opw-2527655 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80101 Forward-Port-Of: odoo/odoo#79390
Before this commit, since we promote the use of route without trailing / for best SEO (fee0113), we remove the trailing / during a redirect to avoid an extra request. Unfortunately, it will break some route with trailing / in case of multi lang. So we remove this optimization, it will increase potentially number of http request before to get the final url, but it will allow to continue to support trailing slash in v15. This commit partially revert the commit ae35117 Description o
Original PR description
Before this commit, since we promote the use of route without trailing / for best SEO (fee0113), we remove the trailing / during a redirect to avoid an extra request. Unfortunately, it will break some route with trailing / in case of multi lang. So we remove this optimization, it will increase potentially number of http request before to get the final url, but it will allow to continue to support trailing slash in v15. This commit partially revert the commit ae35117 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80109
Description of the issue/feature this PR addresses: As an HR officer, when you create an allocation of one day for a user, you need to be able to put a time off on that person, following the allocation. But for the moment, we got an error saying there is no valid allocation on that day. Current behavior before PR: There is no allocation found on that day when a time off is taken on the day of the allocation Desired behavior after PR is merged: If you create an allocation of 1 day, you
Original PR description
Description of the issue/feature this PR addresses: As an HR officer, when you create an allocation of one day for a user, you need to be able to put a time off on that person, following the allocation. But for the moment, we got an error saying there is no valid allocation on that day. Current behavior before PR: There is no allocation found on that day when a time off is taken on the day of the allocation Desired behavior after PR is merged: If you create an allocation of 1 day, you need to be able to put a time off on that specific day without any error message. task-2696771 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#80159
The state value 'open' does not exist on model account.invoice.report opw:2666887 Forward-Port-Of: odoo/odoo#80180
Original PR description
The state value 'open' does not exist on model account.invoice.report opw:2666887 Forward-Port-Of: odoo/odoo#80180
[FIX] sale_purchase_inter_company_rules: fix intercompany billing flow Before this commit: If we create a SO and create a draft invoice with the customer as another company whose rule_type for the inter-company transaction is selected to 'invoice_and_refund'. An error message is thrown as Incompatible companies on records on confirming the invoice. NB: It can also more likely be a configuration issue if journals are not correctly created. After this commit: As a simple fix, we i
Original PR description
[FIX] sale_purchase_inter_company_rules: fix intercompany billing flow Before this commit: If we create a SO and create a draft invoice with the customer as another company whose rule_type for the inter-company transaction is selected to 'invoice_and_refund'. An error message is thrown as Incompatible companies on records on confirming the invoice. NB: It can also more likely be a configuration issue if journals are not correctly created. After this commit: As a simple fix, we intend to set the company_id of the analytic account as 'false' in the respective SO (as well as linked project ) to continue the billing flow. Task : 2587103 Forward-Port-Of: odoo/enterprise#21611
Enterprise part of odoo/odoo#79859 Forward-Port-Of: odoo/enterprise#22283
Original PR description
Enterprise part of odoo/odoo#79859 Forward-Port-Of: odoo/enterprise#22283
Reproduce : - Install Helpdesk - Confugure working hours with values that are earlier than current time for every working days (For example, if the current time is 11:00, set 03:00 - 10:00 for working hours) - Go to Helpdesk > Configuration > SLA Policies and create a SLA Policy: * Team: "Customer Care" * Reach Stage: Solved * Reach In: 0 day 6 hour - Go to Helpdesk > Configuration > Helpdesk Teams and configure "Customer Care" team: * Activate SLA Policies * Select the previ
Original PR description
Reproduce : - Install Helpdesk - Confugure working hours with values that are earlier than current time for every working days (For example, if the current time is 11:00, set 03:00 - 10:00 for working hours) - Go to Helpdesk > Configuration > SLA Policies and create a SLA Policy: * Team: "Customer Care" * Reach Stage: Solved * Reach In: 0 day 6 hour - Go to Helpdesk > Configuration > Helpdesk Teams and configure "Customer Care" team: * Activate SLA Policies * Select the previously configured calendar with our working hours - Go to Helpdesk > Overview and create a new ticket for "Customer Care". Result : The deadline is computed at the right time, but for today, where we expect it to be computed the next day. Soltuion : Compute it for the next day. opw-2607782 Forward-Port-Of: odoo/enterprise#22306 Forward-Port-Of: odoo/enterprise#20595
In 14.0, with the structure of the title row on gantt view, if there is a row with: [employee avatar] [employee name] that has any overflow, we don't see the avatar or employee name and just see ellipsis symbol (...). Depending on side of window, columns, length of employee name this is easy to get the issue. With this changeset we clip overflow text in this particular case (showing employee avatar) so we see the text but cut instead of ellipsed. opw-2671160 Forward-Port-Of: odoo/enterpri
Original PR description
In 14.0, with the structure of the title row on gantt view, if there is a row with: [employee avatar] [employee name] that has any overflow, we don't see the avatar or employee name and just see ellipsis symbol (...). Depending on side of window, columns, length of employee name this is easy to get the issue. With this changeset we clip overflow text in this particular case (showing employee avatar) so we see the text but cut instead of ellipsed. opw-2671160 Forward-Port-Of: odoo/enterprise#22419
Steps: - install Helpdesk - go to Configuration > SLA Policies > Create/Edit - Add tags and try to change color. Bugs: The tag color doesn't change. Explanations: you need to save the color of the tags when updating (adding an option in field). Forward-Port-Of: #15501 opw-2413685 Forward-Port-Of: odoo/enterprise#22371 Forward-Port-Of: odoo/enterprise#22353
Original PR description
Steps: - install Helpdesk - go to Configuration > SLA Policies > Create/Edit - Add tags and try to change color. Bugs: The tag color doesn't change. Explanations: you need to save the color of the tags when updating (adding an option in field). Forward-Port-Of: #15501 opw-2413685 Forward-Port-Of: odoo/enterprise#22371 Forward-Port-Of: odoo/enterprise#22353
How to reproduce: - Use GS1 nomenclature and have at least two products and a package type to scan; - In the Barcode App, create and open a picking; - Scan the first product, then scan a new package through a GS1 barcode => It puts in pack the line. - Scan a second product, then scan the same package => It assigns the package on the second line. - Scan the package type => It applies the package type on the line's package, but the second line has disappear. The bug was caused by
Original PR description
How to reproduce: - Use GS1 nomenclature and have at least two products and a package type to scan; - In the Barcode App, create and open a picking; - Scan the first product, then scan a new package through a GS1 barcode => It puts in pack the line. - Scan a second product, then scan the same package => It assigns the package on the second line. - Scan the package type => It applies the package type on the line's package, but the second line has disappear. The bug was caused by a missing save. task-2636207 Forward-Port-Of: odoo/enterprise#21628
When trying to deliver a decimal quantity between 0 and 0.5, the qty is rounded to 0 and it leads to an error message from EasyPost OPW-2681859 Forward-Port-Of: odoo/enterprise#22196
Original PR description
When trying to deliver a decimal quantity between 0 and 0.5, the qty is rounded to 0 and it leads to an error message from EasyPost OPW-2681859 Forward-Port-Of: odoo/enterprise#22196
Steps to follow - Change the background image with studio - Refresh the page -> The background isn't applied Cause of the issue - The js file was loaded only after studio has been used opw-2692896 Forward-Port-Of: odoo/enterprise#22412
Original PR description
Steps to follow - Change the background image with studio - Refresh the page -> The background isn't applied Cause of the issue - The js file was loaded only after studio has been used opw-2692896 Forward-Port-Of: odoo/enterprise#22412
Before this commit, when trying to add a linkedin account with no page linked, there was no error, nothing was shown. Now, an explicit error is shown to the user. Steps to reproduce: - Have a V14 with social - Have a Linkedin account without any page created yet - Go to Marketing Social - Add a Stream - Choose Linkedin - Connect your account After theses steps, the browser comes back to the Social Marketing page but nothing has changed and the `social.account
Original PR description
Before this commit, when trying to add a linkedin account
with no page linked, there was no error, nothing was shown.
Now, an explicit error is shown to the user.
Steps to reproduce:
- Have a V14 with social
- Have a Linkedin account without any page created yet
- Go to Marketing Social
- Add a Stream
- Choose Linkedin
- Connect your account
After theses steps, the browser comes back to the Social
Marketing page but nothing has changed and the `social.account`
is not created.
OPW-2674174
Forward-Port-Of: odoo/enterprise#22271
Forward-Port-Of: odoo/enterprise#22002