Tuesday, December 28, 2021
15 changes · master
Miscellaneous changes
Steps to reproduce: - Create two bank journals Bank-1 and Bank-2 - Create one Oustanding Payments and one Outstanding Receipts account for each bank journal - Create and confirm an internal tranfer from Bank-1 to Bank-2 for 100$ - A second payment is created Issue: The account on the line in the second payment is the Outstanding Payments account of Bank-1, it should be the Outstanding Receipts account of Bank-2. After this commit, the second payment will take into account the acc
Original PR description
Steps to reproduce: - Create two bank journals Bank-1 and Bank-2 - Create one Oustanding Payments and one Outstanding Receipts account for each bank journal - Create and confirm an internal tranfer from Bank-1 to Bank-2 for 100$ - A second payment is created Issue: The account on the line in the second payment is the Outstanding Payments account of Bank-1, it should be the Outstanding Receipts account of Bank-2. After this commit, the second payment will take into account the account set on bank journal, and if not set, the one set on company. Otherwise, an error is raised. opw-2711252 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81399
Step to reproduce: - Have a fleet contract that need renewal Current Behaviour: - A new activity is created everytime the scheduler is called Behaviour after PR: - A new activity is only created if there is no current renewal activity present when the scheduler is called opw-2713537 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81671
Original PR description
Step to reproduce: - Have a fleet contract that need renewal Current Behaviour: - A new activity is created everytime the scheduler is called Behaviour after PR: - A new activity is only created if there is no current renewal activity present when the scheduler is called opw-2713537 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81671
In case the product is tracked and the "Ship Later" feature is enabled, the lots defined on the POS order are not the same that the ones on the SMLs of the associated picking To reproduce the issue: (Use demo data) 1. Create a product P: - Type: Storable - Tracked by lots - Available in POS 2. Update P's quantity: - 2 x Lot01 - 2 x Lot02 3. Edit the existing POS: - Enable the "Ship Later" feature 4. Start a POS session 5. Add some products: - 1 x P (
Original PR description
In case the product is tracked and the "Ship Later" feature is enabled, the lots defined on the POS order are not the same that the ones on the SMLs of the associated picking To reproduce the issue:…
In case the product is tracked and the "Ship Later" feature is enabled,
the lots defined on the POS order are not the same that the ones on the
SMLs of the associated picking
To reproduce the issue:
(Use demo data)
1. Create a product P:
- Type: Storable
- Tracked by lots
- Available in POS
2. Update P's quantity:
- 2 x Lot01
- 2 x Lot02
3. Edit the existing POS:
- Enable the "Ship Later" feature
4. Start a POS session
5. Add some products:
- 1 x P (Lot01)
- 1 x P (Lot02)
6. Process the order with the option "Ship Later" selected
7. Open the associated delivery order
Error: The reserved lots are incorrect: 2 x Lot01 instead of 1 x Lot01 +
1 x Lot02
When creating such a POS order, if the feature "Ship Later" is used, a
method creates a procurement for each POS order line thanks to
`_launch_stock_rule_from_pos_order_lines`
https://github.com/odoo/odoo/blob/72d6431eb26654b697fc0379f4b6d7e305bb79fc/addons/point_of_sale/models/pos_order.py#L677-L680
Then, these procurements are managed by the standard process, which does
not consider the defined lots. This is the reason why it simply uses the
available quantity in the first lot.
OPW-2704352
Forward-Port-Of: odoo/odoo#81879
Forward-Port-Of: odoo/odoo#81310### Current behavior PDF Preview in document layout settings doesn't match the downloaded one (colors of div with the total and the columns displayed) ### Steps to reproduce - Go to Settings - 'Configure Document Layout' under Companies - Set layout to Boxed - Change the colors - Download the PDF Preview ### Reason - The columns for the unit price and taxes had the 'd-none' class so they weren't visible when printing the pdf preview. To keep coherence, if we see them in the preview
Original PR description
### Current behavior PDF Preview in document layout settings doesn't match the downloaded one (colors of div with the total and the columns displayed) ### Steps to reproduce - Go to Settings - 'Configure Document Layout' under Companies - Set layout to Boxed - Change the colors - Download the PDF Preview ### Reason - The columns for the unit price and taxes had the 'd-none' class so they weren't visible when printing the pdf preview. To keep coherence, if we see them in the preview we must see them in the pdf. - Colors, especially the total div with a 'Boxed' layout, weren't taken into account for some elements in the preview. This is due to a character sanitized in the CSS, specifically `>` which becomes `>` for the '.row > div > table' selector. OPW-2716089 Forward-Port-Of: odoo/odoo#81716
### Step to reproduce: - create an invoice with an archived recipient bank account - confirm the invoice ### Current Behavior: The invoice can be confirmed, even if the recipient bank account link to the invoice is archived. ### Behavior after the PR: The user will be blocked with a "user error" to prevent him to confirm the invoice if the recipient bank account is archived. opw-2704605 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
### Step to reproduce: - create an invoice with an archived recipient bank account - confirm the invoice ### Current Behavior: The invoice can be confirmed, even if the recipient bank account link to the invoice is archived. ### Behavior after the PR: The user will be blocked with a "user error" to prevent him to confirm the invoice if the recipient bank account is archived. opw-2704605 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81287
Before, the system required a vat number on every partner, but that is not required. We need to send it as some other kind of ID however. To clarify, a partner without vat is not for the simplified case only. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81906
Original PR description
Before, the system required a vat number on every partner, but that is not required. We need to send it as some other kind of ID however. To clarify, a partner without vat is not for the simplified case only. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81906
Description of the issue/feature this PR addresses: The dutch COA is outdated and incomplete. Some accounts have wrong types associated to them, and some accounts are missing. Current behavior before PR: Some accounts are either wrong or missing Desired behavior after PR is merged: Every account is correctly categorized -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81718 Forward-Port-Of: odoo/odoo#79963
Original PR description
Description of the issue/feature this PR addresses: The dutch COA is outdated and incomplete. Some accounts have wrong types associated to them, and some accounts are missing. Current behavior before PR: Some accounts are either wrong or missing Desired behavior after PR is merged: Every account is correctly categorized -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81718 Forward-Port-Of: odoo/odoo#79963
A portal user couldn't download a survey certificate Steps to reproduce: 1. Install the Survey app and open it 2. Create a survey with a scoring and a certificate and copy the link 3. In an incognito tab, connect as portal and go to the survey 4. After completing the survey, try to download the certificate Solution: Change the call 'sudo()' to 'with_user(SUPERUSER_ID)' OPW-2687625 Forward-Port-Of: odoo/odoo#81242
Original PR description
A portal user couldn't download a survey certificate Steps to reproduce: 1. Install the Survey app and open it 2. Create a survey with a scoring and a certificate and copy the link 3. In an incognito tab, connect as portal and go to the survey 4. After completing the survey, try to download the certificate Solution: Change the call 'sudo()' to 'with_user(SUPERUSER_ID)' OPW-2687625 Forward-Port-Of: odoo/odoo#81242
**Description of the issue/feature this PR addresses:** As the message is thought to be posted in chatter replacing returns with html break. **Current behavior before PR:** Intended formatting not applied **Desired behavior after PR is merged:** Proper formatting applied in chatter Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81845 Forward-Port-Of: odoo/odoo#81628
Original PR description
**Description of the issue/feature this PR addresses:** As the message is thought to be posted in chatter replacing returns with html break. **Current behavior before PR:** Intended formatting not applied **Desired behavior after PR is merged:** Proper formatting applied in chatter Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81845 Forward-Port-Of: odoo/odoo#81628
Community: https://github.com/odoo/odoo/pull/81181 Themes: https://github.com/odoo/design-themes/pull/536 Upgrade: https://github.com/odoo/upgrade/pull/3107 Forward-Port-Of: odoo/odoo#81181
Original PR description
Community: https://github.com/odoo/odoo/pull/81181 Themes: https://github.com/odoo/design-themes/pull/536 Upgrade: https://github.com/odoo/upgrade/pull/3107 Forward-Port-Of: odoo/odoo#81181
Steps to reproduce: - Install `website_hr_recruiment` module - Go to `your_website.com/jobs` - Activate Edit mode and add a "3 Columns" block - Select one of the columns and set the shadow to `None` Issue: Shadow is not removed, and by default the "outset" mode is selected. Cause: When we check the state of the shadow with `css('box-shadow')`, it will always be set because a custom css 'box-shadow' is set by the module website_hr_recruitment on card element, a
Original PR description
Steps to reproduce:
- Install `website_hr_recruiment` module
- Go to `your_website.com/jobs`
- Activate Edit mode and add a "3 Columns" block
- Select one of the columns and set the shadow to `None`
Issue:
Shadow is not removed, and by default the "outset" mode is selected.
Cause:
When we check the state of the shadow with `css('box-shadow')`, it
will always be set because a custom css 'box-shadow' is set by the
module website_hr_recruitment on card element, and therefore the value
will always be either 'inset' or 'outset'.
Solution:
If widget value is 'outset' or 'none', set `box-shadow` style to
'none' so it will override the style from css file (for 'outset', the
shadow will still be applied by the 'shadow' class).
opw-2701512
Forward-Port-Of: odoo/odoo#81951
Forward-Port-Of: odoo/odoo#81038Bug === The tour to check the limit of replies for social Twitter randomly fail. There are 2 reason for that 1. Even if the view all Tweets were below the right message, the mock of the API returned the wrong value for "in_reply_to_status_id_str" 2. The check of the last message is done by checking the message in the DOM, but as it's fast enough, we didn't catch it. So the test fail when we correctly detect that the message is posted (and it shouldn't). So to fix this issue
Original PR description
Bug === The tour to check the limit of replies for social Twitter randomly fail. There are 2 reason for that 1. Even if the view all Tweets were below the right message, the mock of the API returned the wrong value for "in_reply_to_status_id_str" 2. The check of the last message is done by checking the message in the DOM, but as it's fast enough, we didn't catch it. So the test fail when we correctly detect that the message is posted (and it shouldn't). So to fix this issue, we return the right value for "in_reply_to_status_id_str", and we add an "extra_trigger" to the tour to wait before checking if the message is posted. Just in case, remove randomly generated Twitter identifiers and use a counter instead. Forward-Port-Of: odoo/enterprise#23120
If numerous journals were selected, their names could end up covering options From 5 selected, 'and others' is specified instead. task-2671733 Forward-Port-Of: odoo/enterprise#22129
Original PR description
If numerous journals were selected, their names could end up covering options From 5 selected, 'and others' is specified instead. task-2671733 Forward-Port-Of: odoo/enterprise#22129
[IMP] delivery_dhl: DHL shipment validation from v6.3 to v10.0 https://xmlportal.dhl.com/faq : All customers on older versions of Shipment Validation Services should plan on migrating to our newer Integration protocols (RESTFUL/JSON, SOAP XML) or upgrade to the latest version – 10.0 as DHL Express plans on deprecating all older versions soon. Our DHL representatives will be reaching out on more information regarding this. Only Shipment Validation was upgraded to version 10, which means
Original PR description
[IMP] delivery_dhl: DHL shipment validation from v6.3 to v10.0 https://xmlportal.dhl.com/faq : All customers on older versions of Shipment Validation Services should plan on migrating to our newer…
[IMP] delivery_dhl: DHL shipment validation from v6.3 to v10.0 https://xmlportal.dhl.com/faq : All customers on older versions of Shipment Validation Services should plan on migrating to our newer Integration protocols (RESTFUL/JSON, SOAP XML) or upgrade to the latest version – 10.0 as DHL Express plans on deprecating all older versions soon. Our DHL representatives will be reaching out on more information regarding this. Only Shipment Validation was upgraded to version 10, which means that we cannot upgrade the other tools yet. This means that we need to keep the XML documents for version 6.3. With version 10, we have access to more fields, but most are not required. > Here are some new fields that are now required: > - Dutiable.TermsOfTrade > - Piece.PieceID > - piece.Weight > > Here are some deprecated fields: > - ShipmentRequest.PiecesEnabled > - ShipmentDetails.NumberOfPieces > - ShipmentDetails.Weight > - Piece.PackageTypeCode > > Changes: > - AddressLine became AddressLine[1-3] I also updated the credentials and tests, because they were not up to date. task-2573503 Forward-Port-Of: odoo/enterprise#22972 Forward-Port-Of: odoo/enterprise#22692
Currently, the NL localization uses the generic balance sheet, which is not correct according to NL government. On top of that, the generic balance sheet is linked to the generic P&L, even though a specific P&L for NL has already been implemented. In order to be more robust, a control domain on top of a domain adds a security layer that can help in debugging when adding new accounts. This can be done by using account tags with control domains. Changes: - Add a balance sheet that respect
Original PR description
Currently, the NL localization uses the generic balance sheet, which is not correct according to NL government. On top of that, the generic balance sheet is linked to the generic P&L, even though a specific P&L for NL has already been implemented. In order to be more robust, a control domain on top of a domain adds a security layer that can help in debugging when adding new accounts. This can be done by using account tags with control domains. Changes: - Add a balance sheet that respects the NL format. - Rewrite the profit and loss report to make use of account codes and add control domain with tags. Task: [l10n_nl] Netherlands. Improve localization Task id=2674603 Forward-Port-Of: odoo/enterprise#23018 Forward-Port-Of: odoo/enterprise#22193