Thursday, December 30, 2021
14 changes · master
Resolved issues and error corrections
Cash on Delivery will now appear in the intended position among payment options when it is enabled, instead of always being pushed to the end. This makes checkout clearer for customers and helps businesses present available payment methods in the right priority.
Original PR description
Before this commit, COD was always shown last in the payment acquirers list, even when enabled. This commit fix it. task-2691186 upgrade PR: coming soon
Miscellaneous changes
Fix for task 2620026. _get_bom_component_qty function is only referred to once in the whole odoo app, which is on addons/sale_mrp/models/account_move.py#22. The result returned from this function is used as a multiplier to quantity to convert into the expected UoM. However, the quantity being referred to on _stock_account_get_anglo_saxon_price_unit (qty_invoiced, qty_to_invoice), are already converted into the SO Line's product's default UoM. In this function, it however tries to conv
Original PR description
Fix for task 2620026. _get_bom_component_qty function is only referred to once in the whole odoo app, which is on addons/sale_mrp/models/account_move.py#22. The result returned from this function is…
Fix for task 2620026. _get_bom_component_qty function is only referred to once in the whole odoo app, which is on addons/sale_mrp/models/account_move.py#22. The result returned from this function is used as a multiplier to quantity to convert into the expected UoM. However, the quantity being referred to on _stock_account_get_anglo_saxon_price_unit (qty_invoiced, qty_to_invoice), are already converted into the SO Line's product's default UoM. In this function, it however tries to convert 1 from SO Line's UoM to BoM's UOM. With this, if Product UoM=x, SO Line UoM=y, BOM UoM=x, in the function _stock_account_get_anglo_saxon_price_unit, the quantities will be multiplied by the same factor twice, resulting to the incorrect computation of price_unit to follow. -- Description of the issue/feature this PR addresses: More detail on error and its demonstration can be found in this [task](https://www.odoo.com/web#id=2620026&cids=5&menu_id=4720&action=333&active_id=3622&model=project.task&view_type=form). -- Current behavior before PR: Incorrect price_unit calculation due to BoM prod_qty_invoiced and prod_qty_to_invoice is incorrect on addons/sale_mrp/models/account_move.py/#27-28 after multiplying by incorrect factor. Error will occur if product has BoM and SO Line has different UoM from product's default UoM and its corresponding BoM's UoM. -- Desired behavior after PR is merged: price_unit calculation fixed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81588 Forward-Port-Of: odoo/odoo#81355
- Install stock with demo data - Log in Chicago company - Chicago partner has inter-company transit set on Customer and Supplier locations - Jeff Lawson (partner address of chicago warehouse) has Customer and supplier locations set instead of inter-company transit. However if you log in San Francisco company Jeff Lawson has inter-company transit set while it should not. It happens because during the demo install the partner is added through a write and the company is not provided an
Original PR description
- Install stock with demo data - Log in Chicago company - Chicago partner has inter-company transit set on Customer and Supplier locations - Jeff Lawson (partner address of chicago warehouse) has Customer and supplier locations set instead of inter-company transit. However if you log in San Francisco company Jeff Lawson has inter-company transit set while it should not. It happens because during the demo install the partner is added through a write and the company is not provided and the code was missing a part in that case. Forward-Port-Of: odoo/odoo#81970
Inside a scrollable popup, the scroll was not correctly triggered when moving one of its snippets through drag and drop. This commits correctly defines the SmoothScrollOnDrag.$scrollTarget when a modal is shown. task-2431469 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82000 Forward-Port-Of: odoo/odoo#78813
Original PR description
Inside a scrollable popup, the scroll was not correctly triggered when moving one of its snippets through drag and drop. This commits correctly defines the SmoothScrollOnDrag.$scrollTarget when a modal is shown. task-2431469 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82000 Forward-Port-Of: odoo/odoo#78813
This commit re-applies the commit that was merged at [1] but whose code was lost during Jabberwock revert at [2]. Make the draggable snippets "wizz" when the user clicks on an empty oe_structure. [1]: https://github.com/odoo/odoo/commit/3ed3537abd416ebc35f8bc2ee65f209840c071bf [2]: https://github.com/odoo/odoo/commit/e5572c317a7775a58675ed73efc89b5c9f6c0c39 Related to task-2363616 Forward-Port-Of: odoo/odoo#82034
Original PR description
This commit re-applies the commit that was merged at [1] but whose code was lost during Jabberwock revert at [2]. Make the draggable snippets "wizz" when the user clicks on an empty oe_structure. [1]: https://github.com/odoo/odoo/commit/3ed3537abd416ebc35f8bc2ee65f209840c071bf [2]: https://github.com/odoo/odoo/commit/e5572c317a7775a58675ed73efc89b5c9f6c0c39 Related to task-2363616 Forward-Port-Of: odoo/odoo#82034
Steps to reproduce: -Create a quote with 2 lines (same product - different lead time). -When a partial delivery is made (e.g., 5 of 10), Odoo places the operation related to the remaining undelivered quantity (5), on the last line in the Operations list. -When the next delivery is made, Odoo deducts the quantity from the first operation in the list instead of from the line whose deadline is closest. Current Behaviour : Odoo assign quantity to the first move line in the list. Behaviour
Original PR description
Steps to reproduce: -Create a quote with 2 lines (same product - different lead time). -When a partial delivery is made (e.g., 5 of 10), Odoo places the operation related to the remaining undelivered quantity (5), on the last line in the Operations list. -When the next delivery is made, Odoo deducts the quantity from the first operation in the list instead of from the line whose deadline is closest. Current Behaviour : Odoo assign quantity to the first move line in the list. Behaviour After the PR: Odoo assign quantity to the move line with the closest deadline. opw-2657048 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#81663 Forward-Port-Of: odoo/odoo#80534
Step to reproduce: - Create PO with an item rounded to 0.01 - Deliver 0.48/1 - Open Accrual Expense Entry Current Behaviour: - Order line is not taken into account due to rounding error - Wizard is empty Behaviour After PR: - Qty is correctly rounded and appear as expected - Order line is taken into account opw-2720161 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82051
Original PR description
Step to reproduce: - Create PO with an item rounded to 0.01 - Deliver 0.48/1 - Open Accrual Expense Entry Current Behaviour: - Order line is not taken into account due to rounding error - Wizard is empty Behaviour After PR: - Qty is correctly rounded and appear as expected - Order line is taken into account opw-2720161 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82051
Task-2702690 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82048
Original PR description
Task-2702690 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82048
Commit [1] added a rename button for custom snippets... but forgot to remove it once the snippet is being dragged. [1]: https://github.com/odoo/odoo/commit/1044a76a19d94ce93c4cd41841fb805d36a160e3 Forward-Port-Of: odoo/odoo#82058
Original PR description
Commit [1] added a rename button for custom snippets... but forgot to remove it once the snippet is being dragged. [1]: https://github.com/odoo/odoo/commit/1044a76a19d94ce93c4cd41841fb805d36a160e3 Forward-Port-Of: odoo/odoo#82058
Before that, uploading a file from a kanban was adding res_id=0 Was missing from 5e81850ea6 Forward-Port-Of: odoo/odoo#82089
Original PR description
Before that, uploading a file from a kanban was adding res_id=0 Was missing from 5e81850ea6 Forward-Port-Of: odoo/odoo#82089
Before this commit, COD was always shown last in the payment acquirers list, even when enabled. This commit fix it. task-2691186 Forward-Port-Of: odoo/enterprise#23170
Original PR description
Before this commit, COD was always shown last in the payment acquirers list, even when enabled. This commit fix it. task-2691186 Forward-Port-Of: odoo/enterprise#23170
When sending the email from marketing.participant, the wrong default campaign_id (set in action marketing_participant_action_campaign) was used to create a mail compose message. Odoo expects the utm_campaign_id to track the links and not the id of the campaign. It lead to issues if the id of the campaign doesn't exist in the table utm.campaign PS: On model mail.compose.message, the related field to utm.campaign is called campaign_id opw:2555207 Forward-Port-Of: odoo/enterprise#20754
Original PR description
When sending the email from marketing.participant, the wrong default campaign_id (set in action marketing_participant_action_campaign) was used to create a mail compose message. Odoo expects the utm_campaign_id to track the links and not the id of the campaign. It lead to issues if the id of the campaign doesn't exist in the table utm.campaign PS: On model mail.compose.message, the related field to utm.campaign is called campaign_id opw:2555207 Forward-Port-Of: odoo/enterprise#20754
Open a followup report of a customer Click on print letter The resulting pdf is not in letter format, the customer address is below the title and would not match an envelope opw-2689702 Forward-Port-Of: odoo/enterprise#22930
Original PR description
Open a followup report of a customer Click on print letter The resulting pdf is not in letter format, the customer address is below the title and would not match an envelope opw-2689702 Forward-Port-Of: odoo/enterprise#22930
Forward-Port-Of: odoo/enterprise#23082 Forward-Port-Of: odoo/enterprise#21579
Original PR description
Forward-Port-Of: odoo/enterprise#23082 Forward-Port-Of: odoo/enterprise#21579