Tuesday, February 15, 2022
3 changes · master
Resolved issues and error corrections
This fixes an issue where employees creating time off from the dashboard could see leave allocation amounts belonging to the default admin employee instead of their own. Time off type balances now reflect the actual employee, reducing confusion and helping staff choose the right leave type.
Original PR description
# Observed behavior When logged in as another employee than Mitchell Admin (or equivalent employee who has an ID of 1 in the database), the number of days allocated and displayed in the time off type name when creating a time off from the dashboard is by default the one of Mitchell Admin. # Expected behavior The allocation in the time off type should reflect the allocation of the employee # Steps to reproduce 1) Create a new user and an employee for this user 2) With the credentials of this user, create a new time off from the dashboard calendar 3) The default time off type has the allocations of Mitchell Admin (or equivalent employee who has an ID of 1 in the database) task-2712193 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Time Off app removes a confusing allocation approval option that was rarely used and overlapped with existing HR-managed allocation flows. When employees are not allowed to request their own allocations, the approval setting is now hidden and HR-created allocations are automatically approved, making setup clearer for administrators.
Original PR description
PURPOSE When we made the b2b on Time Off, we designed the allocation settings to be like this : 1. Allow Allocation : NO (stop here) 2. If YES Can the Employee requests Allocation himself ? 2.1. NO…
PURPOSE
When we made the b2b on Time Off, we designed the allocation settings to be like this :
1. Allow Allocation : NO (stop here)
2. If YES
Can the Employee requests Allocation himself ?
2.1. NO (stop here, cause the HR will create the allocation and it will be automatically accepted)
2.2. If YES
Who will approve the Allocation made by the Employee ?
2.2.1. Nobody, it's directly approved
2.2.2. The time off officer must approve
2.2.3. It's SET by the time off officer.
In the day to day live, the case 2.2.3. never happen. It's the same settings as 2.1. "the employee will not make an allocaiton request, it will be the HR officer"
In fact, nobody understand what is behind that settings and the technical code behind it seems obsolete.
SPECIFICATION
1. Remove the "set by time off officer"
2. If Employee Requests is set on "Not Allowed", don't display Approval : https://tinyurl.com/yxwwql83 if an allocation is created, it will be done by the HR officer and automatically approved.
task-2705150
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis change removes an unused and confusing approval option for employee time off allocation requests. When employees are not allowed to request allocations themselves, the approval setting is hidden, making the setup clearer for HR users while keeping HR-created allocations automatically approved.
Original PR description
PURPOSE When we made the b2b on Time Off, we designed the allocation settings to be like this : 1. Allow Allocation : NO (stop here) 2. If YES Can the Employee requests Allocation himself ? 2.1. NO…
PURPOSE
When we made the b2b on Time Off, we designed the allocation settings to be like this :
1. Allow Allocation : NO (stop here)
2. If YES
Can the Employee requests Allocation himself ?
2.1. NO (stop here, cause the HR will create the allocation and it will be automatically accepted)
2.2. If YES
Who will approve the Allocation made by the Employee ?
2.2.1. Nobody, it's directly approved
2.2.2. The time off officer must approve
2.2.3. It's SET by the time off officer.
In the day to day live, the case 2.2.3. never happen. It's the same settings as 2.1. "the employee will not make an allocaiton request, it will be the HR officer"
In fact, nobody understand what is behind that settings and the technical code behind it seems obsolete.
SPECIFICATION
1. Remove the "set by time off officer"
2. If Employee Requests is set on "Not Allowed", don't display Approval : https://tinyurl.com/yxwwql83 if an allocation is created, it will be done by the HR officer and automatically approved.
task-2705150