Tuesday, March 8, 2022
10 changes · master
Enhancements to existing features
A new automated test verifies that document uploads linked to projects continue to respect existing access checks. This helps catch future changes that could accidentally weaken protection around uploaded project documents.
Original PR description
Since aaf0ec2531ee0c50a370f97593adbfa346cb7179 it is possible to pass res_id and res_model to the upload_document route. This is not a security issue at this time as the check method is called on ir.attachment. The purpose of this commit is to ensure that we get warned if this check is no more performed / by-passed for any reason. task-2710539
Signature request emails now include the sender's usual email signature, matching the behavior users expect from other Odoo apps. This makes outgoing signing requests look more complete, consistent, and professional for recipients.
Original PR description
In many modules the signature of the user is sent together with the emails they send. For sign, it wasn't the case when requesting signatures. This PR adds the signature in the body of the email when sending sign.requests. task-2688134
Code cleanup and technical improvements
This update removes an older compatibility layer from several web modules and replaces it with the newer standard approach. It should not change day-to-day behavior, but it reduces technical debt and helps keep the interface easier to maintain and improve over time.
Original PR description
* dashboard,enterprise,grid,mobile,studio Before this commit, components used `el` and `trigger` but this works thanks to LegacyComponent. LegacyComponent has been introduced to ease the transition from owl 1 to owl 2. This commit replaces the uses of `el` by `useRef` and `trigger` by adding callback in props. Without these owl 1 features, components no longer need to extend LegacyComponent. This commit also adapts the tests to use `getFixture` instead of `el`. Co-authored-by: Aaron Bohy <aab@odoo.com> Co-authored-by: Simon Genin (ges) <ges@odoo.com> Co-authored-by: luvi <luvi@odoo.com> Co-authored-by: Jorge Pinna Puissant <jpp@odoo.com>
Miscellaneous changes
The order needs to be determinist. Without this patch, the order was not guaranteed. https://runbot.odoo.com/runbot/build/13462502 Forward-Port-Of: odoo/enterprise#25090
Original PR description
The order needs to be determinist. Without this patch, the order was not guaranteed. https://runbot.odoo.com/runbot/build/13462502 Forward-Port-Of: odoo/enterprise#25090
Steps to reproduce the bug: - Go to barcode app > print the barcode commands - Try to scan the cancel command Problem: There's `O-BTN.cancel` behind instead of `O-CMD.cancel` Solution: The cancel command has been changed in V15, so we have to update the barcode: https://github.com/odoo/enterprise/commit/c0151bce3c60c69e7cadeb719a81c4a702b71c34#diff-c9b8fb41c7e020c7afdc452b053489f09a630220b6b3a7a7eee1b5febf46eb07R347 opw-2774366 Forward-Port-Of: odoo/enterprise#25082
Original PR description
Steps to reproduce the bug: - Go to barcode app > print the barcode commands - Try to scan the cancel command Problem: There's `O-BTN.cancel` behind instead of `O-CMD.cancel` Solution: The cancel command has been changed in V15, so we have to update the barcode: https://github.com/odoo/enterprise/commit/c0151bce3c60c69e7cadeb719a81c4a702b71c34#diff-c9b8fb41c7e020c7afdc452b053489f09a630220b6b3a7a7eee1b5febf46eb07R347 opw-2774366 Forward-Port-Of: odoo/enterprise#25082
Since recent commit https://github.com/odoo/odoo/commit/6e743efa6117ce4a5251427064a253cba48edd25, there is now a check on res_id and create_uid when updating the linked resources of an attachment. To avoid inconsistency in the data, we first set res_id to 0 but this doesn't work anymore. We need to update both res_id and res_model at the same time instead. opw-2654058 Forward-Port-Of: odoo/enterprise#23919
Original PR description
Since recent commit https://github.com/odoo/odoo/commit/6e743efa6117ce4a5251427064a253cba48edd25, there is now a check on res_id and create_uid when updating the linked resources of an attachment. To avoid inconsistency in the data, we first set res_id to 0 but this doesn't work anymore. We need to update both res_id and res_model at the same time instead. opw-2654058 Forward-Port-Of: odoo/enterprise#23919
Forward-Port-Of: odoo/enterprise#25052
Original PR description
Forward-Port-Of: odoo/enterprise#25052
In #19577 a method `adjustSignatureSize` was added to adjust the signature size with the signature item box size keeping the original ratio of the image. However, the approach that was being used altered significantly the resolution of the signature image. This commit introduces a new approach where we change the canvas size instead of changing the image size. Forward-Port-Of: odoo/enterprise#24520
Original PR description
In #19577 a method `adjustSignatureSize` was added to adjust the signature size with the signature item box size keeping the original ratio of the image. However, the approach that was being used altered significantly the resolution of the signature image. This commit introduces a new approach where we change the canvas size instead of changing the image size. Forward-Port-Of: odoo/enterprise#24520
Before this commit the only way to modify the domain is to completely override my_helpdesk_tickets. Since this function is so big this is not clean/easy to do. By creating a separate function we can simply override it and we can reuse the same domain in two places. Forward-Port-Of: odoo/enterprise#24851 Forward-Port-Of: odoo/enterprise#24194
Original PR description
Before this commit the only way to modify the domain is to completely override my_helpdesk_tickets. Since this function is so big this is not clean/easy to do. By creating a separate function we can simply override it and we can reuse the same domain in two places. Forward-Port-Of: odoo/enterprise#24851 Forward-Port-Of: odoo/enterprise#24194
How to reproduce the bug ? - install the accounting and l10n_es modules - login as a non-administrator user - open the accounting app, then to go to Reporting > Tax Report (Mod 303) What is the bug ? As a non administrator user, you get an access error if you try generate an accounting report for a spanish company with the spanish accounting module. The error says that the user is not allowed to modify 'Companies' (res.company) records. opw-2767235 Signed-off-by: Adrien Minet
Original PR description
How to reproduce the bug ? - install the accounting and l10n_es modules - login as a non-administrator user - open the accounting app, then to go to Reporting > Tax Report (Mod 303) What is the bug ? As a non administrator user, you get an access error if you try generate an accounting report for a spanish company with the spanish accounting module. The error says that the user is not allowed to modify 'Companies' (res.company) records. opw-2767235 Signed-off-by: Adrien Minet <admi@odoo.com> Forward-Port-Of: odoo/enterprise#24927