Daily updates from Odoo
Friday, March 18, 2022
2 changes · master
Resolved issues and error corrections
Opening the timesheet pivot view could fail when certain helper content was not available. This fix adds the missing safety check so users can access the pivot view reliably when records are loaded.
Original PR description
When opening the pivot view when records are fetched, the noContentHelper is not present in the view which raises a traceback when trying to call querySelector on its el element which is undefined. 82122c15b42b20d9dcc9b53caa2756941908f07c was indeed missing testing whether this.noContentHelper.el was truthy prior to use it.
The timesheet pivot view now opens correctly after an underlying interface change caused an error. This prevents users from being blocked when analyzing timesheet data in pivot reports.
Original PR description
Prior to this commit: - A traceback was thrown when opening the pivot view in timesheet_grid as it was using a reference to this.el which is no more supported since owl2. After this commit: - The code is mode into the renderer where it can leverage the user of the useRef that is done into PivotRenderer.