Monday, March 21, 2022
52 changes · master
Enhancements to existing features
The mail composer now handles typing indicator information more consistently within the messaging interface. This helps keep the chat experience reliable without introducing a visible workflow change for users.
Original PR description
Task-2793280
The Discuss app now handles the mailbox ordering as a stored field rather than a calculated value. This should make mailbox selection more consistent and easier to maintain, especially on mobile.
Original PR description
Task-2793280
The mail app now stores the text used for message author avatar labels in a dedicated field. This is a small internal improvement that makes the messaging interface easier to maintain and helps ensure consistent display behavior.
Original PR description
Task-2793280
The mail app now stores suggested recipient dialog wording in a cleaner, reusable way. This is an internal improvement that helps keep recipient suggestions consistent and easier to maintain, with little direct change for end users.
Original PR description
Task-2793280
The mail app’s mobile messaging menu now shows a clearer placeholder when starting a new message. This small wording improvement helps users better understand where to begin composing a message on mobile devices.
Original PR description
Task-2793280
Message dates are now handled as a standard message field in the mail module. This makes message display data more consistent and easier to maintain, with minimal direct impact on end users.
Original PR description
Task-2793280
The mail module now stores prepared message display content as a regular field instead of recalculating it on demand. This should make message previews and replies more consistent and easier to maintain without changing the user workflow.
Original PR description
Task-2793280
Mail notification blocking is now stored as part of the messaging data rather than checked separately. This makes the notification alert behavior more consistent and easier to maintain, with minimal visible change for users.
Original PR description
Task-2793280
This update standardizes cursor behavior in several Odoo screens as part of the broader version 16 visual refresh. It helps make interfaces feel more consistent and avoids misleading click cues in areas that are not meant to be interactive.
Original PR description
This commit is part of v16 overall restyle, task#2704984. Enterprise: - https://github.com/odoo/enterprise/pull/25365 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mail attachment viewer now includes an added safeguard so it only opens when the required attachment data is available. This helps avoid errors or broken previews, giving users a smoother experience when viewing attachments in conversations.
Original PR description
Task-2797754
Unread message tracking has been simplified by moving the counter from general discussion threads to mail channels where it is actually used. This reduces unnecessary complexity behind the scenes and helps keep messaging performance and maintenance cleaner without changing the user experience.
Original PR description
The field could have been removed from thread since https://github.com/odoo/odoo/commit/88b8cd058713bfad2942f7e7434c34b6c1a6e7da task-2746109
This update refines how the mail discussion interface decides when to show the thread name in the message composer. It supports a more consistent user experience in conversations while keeping the change small and internal to the mail app.
Original PR description
Task-2793280
The mail composer’s footer visibility is now handled as a stored view setting rather than calculated directly in the component. This makes the composer interface easier to maintain and helps ensure consistent behavior across mail screens.
Original PR description
Task-2793280
The mail app now adds extra safeguards when showing attachment cards, helping prevent display issues when attachment information is incomplete or unavailable. This improves reliability for users working with messages and attachments without changing their workflow.
Original PR description
Task-2797754
The mail attachment area now includes an extra safeguard so it only appears when the needed information is available. This reduces the chance of display issues or interruptions when users work with messages and attachments.
Original PR description
Task-2797754
The mail app now adds an extra safeguard around the attachment deletion confirmation window. This helps prevent errors when the confirmation component is shown without the expected attachment data, making the experience more reliable for users.
Original PR description
Task-2797754
The mail composer now stores the explanatory text for suggested recipients as a field instead of calculating it only in the display component. This keeps recipient information more consistent and easier to reuse, with minimal visible impact for users.
Original PR description
Task-2793280
This update adds a safeguard around image attachments in the messaging area to prevent display issues when attachment data is incomplete or unavailable. It helps keep conversations stable and avoids small visual errors disrupting the user experience.
Original PR description
Task-2797754
This update adds a safeguard around the attachment list in the Mail app so it behaves more reliably when attachment data is not ready or unavailable. It helps prevent small display issues or interruptions when users view messages with attachments.
Original PR description
Task-2797754
The mail app now better protects the member list view from loading in situations where required information is missing. This helps avoid display issues and provides a smoother experience when using channels or conversations.
Original PR description
Task-2797754
The mail activity completion popover now includes an extra safeguard so it only appears or behaves when the needed activity data is available. This reduces the chance of users encountering an error while marking activities as done, supporting a smoother workflow.
Original PR description
Task-2797754
Chat and live chat channels must now always have a defined type when created or edited. This helps prevent incomplete channel records, reducing configuration errors and improving data reliability.
Original PR description
Make the channel_type required in UI and add SQL constraint for the database. task-2774970 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adds a safeguard to the email swipe view so it only runs when the needed component is available. This helps prevent interface errors and improves reliability for users working in the mail experience.
Original PR description
Task-2797754
The approvals app now better protects its approval display from unexpected missing information. This helps prevent small interface issues and keeps approval workflows smoother for users.
Original PR description
Task-2797754
The signing request screen has been made more robust so it better handles cases where expected information may not be available. This helps reduce unexpected errors for users preparing or managing documents to sign.
Original PR description
Task-2797754
This update standardizes cursor behavior in several Odoo screens as part of the version 16 visual refresh. It helps create a more consistent and polished user experience across Helpdesk, Planning, Map, Grid, and Studio interfaces.
Original PR description
This commit is part of v16 overall restyle, task#2704984. community: - https://github.com/odoo/odoo/pull/86626
Resolved issues and error corrections
This fixes an internal inconsistency in how live chat or call session records are identified. It helps prevent unnecessary change detection and keeps messaging session data more reliable without changing the user experience.
Original PR description
Before this commit, mismatching types between String and Number would cause inserts to register a change. `rtc.js` used `rtcSession.peerToken`(String) and `rtcSession.id`(number) interchangeably, this commit fixes this issue by favoring the usage of `rtcSession.id`.
Code cleanup and technical improvements
The project sales and timesheet accounting links have been consolidated into the main related modules because the separate bridge modules were no longer needed. This simplifies the app structure and should reduce maintenance complexity without changing business workflows.
Original PR description
Since the sale module depends on the account module, the bridges account_sale_timesheet and sale_project_account can be merged with sale_timesheet and sale_project respectively. This PR removes those bridges and merges them with the other modules. Task-2772395
Miscellaneous changes
Workorder _action_confirm works in batch and is designed to link workorders and moves per production. Original code breaks the 'per production' constraint by linking moves from all productions to workorders of the last one when called on workorders from multiple productions. task: 2797201 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at
Original PR description
Workorder _action_confirm works in batch and is designed to link workorders and moves per production. Original code breaks the 'per production' constraint by linking moves from all productions to workorders of the last one when called on workorders from multiple productions. task: 2797201 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#86633
The live chat code was reorganized by moving shared timer logic into a separate utility file. This does not change the customer-facing chat experience, but it makes the code easier to maintain and prepares it for future improvements.
Original PR description
The `public_livechat.js` file should be split into multiple files, to prepare for a refactoring. Timer and Timers from `public_livechat.js` will now be located in `public_livechat_utils.js` Task-2212347
**ISSUE 01 (fixed thanks to a backport):** Suppose a product with several suppliers, all with the same partner. On the purchase order, the product description will always be based on the last supplier To reproduce the issue: 1. Create a vendor V 2. Create a product P: - Type: Storable - In Purchase, add a line L01: - Vendor: V - Vendor Product Name: Name01 - Vendor Product Code: C01 - Quantity: 1 - Price: 10 - In Purchase, add
Original PR description
**ISSUE 01 (fixed thanks to a backport):** Suppose a product with several suppliers, all with the same partner. On the purchase order, the product description will always be based on the last…
**ISSUE 01 (fixed thanks to a backport):**
Suppose a product with several suppliers, all with the same partner. On
the purchase order, the product description will always be based on the
last supplier
To reproduce the issue:
1. Create a vendor V
2. Create a product P:
- Type: Storable
- In Purchase, add a line L01:
- Vendor: V
- Vendor Product Name: Name01
- Vendor Product Code: C01
- Quantity: 1
- Price: 10
- In Purchase, add a second line L02:
- Vendor: V
- Vendor Product Name: Name02
- Vendor Product Code: C02
- Quantity: 20
- Price: 2
- Once P is saved, ensure the lines order in the purchase tab:
- L01
- L02
3. Create a PO with vendor V
4. Add a line with 1 x P
Error: The description is incorrect ("[C02] Name02" instead of "[C01]
Name01")
Partial backport of https://github.com/odoo/odoo/commit/9fae8e2aa15cefefec8052fd9a072f0e288510a0
(All details about issue are explained in the commit description)
**ISSUE 02**
When confirming a sale order, if a purchase order is generated, the
descriptions of the PO's lines won't be adapted to the vendor
To reproduce the issue:
1. Create a vendor V
2. Create a product P:
- Type: Service
- In Purchase, add a line L01:
- Vendor: V
- Vendor Product Name: Name01
- Vendor Product Code: C01
- Purchase Automatically: True
3. Create and Confirm a SO with 1 x P
4. Open the generated PO
Error: The description is incorrect (it's the standard name of P instead
of "[C01] Name01")
OPW-2777702
Forward-Port-Of: odoo/odoo#86663
Forward-Port-Of: odoo/odoo#86256Step to reproduce: - Install contacts - create a new contact and add "Côte d'Ivoire" to the Company Address field - add a phone number like this one: (+225) 05 06 00 79 95 - try to send a sms to the number, it's says "(Invalid number)" instate of the number, so it's not possible to send the SMS The Ivory Coast has a new standard for the phone number since the 31 January 2021, the phone number can have a length of ten digits. And we use the library `phonenumbers` with the version `8.9
Original PR description
Step to reproduce: - Install contacts - create a new contact and add "Côte d'Ivoire" to the Company Address field - add a phone number like this one: (+225) 05 06 00 79 95 - try to send a sms to the number, it's says "(Invalid number)" instate of the number, so it's not possible to send the SMS The Ivory Coast has a new standard for the phone number since the 31 January 2021, the phone number can have a length of ten digits. And we use the library `phonenumbers` with the version `8.9.10` and `8.8.1` for the runbot and the SaaS server, but it's quite old (the `8.9.10` is released on Jul 12 2018). The library in version `8.12.29` resolve the issue, but we probably won't update them. If we update the library, we should revert this commit. opw-2726582 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#83045
In case an open balance needs to be created on a receivable or payable account after reconciliation, but no partner was defined on the statement line, we want to keep the partner from the counterpart values that was identified through reference matching. Description of the issue/feature this PR addresses: Error "Unable to create an open balance for a statement line without a partner set" is displayed although a partner can be identified through reference matching. Current behavior be
Original PR description
In case an open balance needs to be created on a receivable or payable account after reconciliation, but no partner was defined on the statement line, we want to keep the partner from the counterpart values that was identified through reference matching. Description of the issue/feature this PR addresses: Error "Unable to create an open balance for a statement line without a partner set" is displayed although a partner can be identified through reference matching. Current behavior before PR: Error message is displayed. Desired behavior after PR is merged: Open balance is created properly. OPW-2793384 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#86391
When clicking on readonly stat button (website related), it would sometimes raise a traceback since there is no action to redirect to. Step to reproduce: - Go to Website > Visitors > Visitors - Select a Visitor to enter its form view - Now, either: A. Enter edit mode B. Enter edit mode and discard (or save) - Click on stat button This will raise a traceback, since the `disabled` property is now gone. Indeed, the framework is adding/removing that attribute when entering or leav
Original PR description
When clicking on readonly stat button (website related), it would sometimes raise a traceback since there is no action to redirect to. Step to reproduce: - Go to Website > Visitors > Visitors - Select a Visitor to enter its form view - Now, either: A. Enter edit mode B. Enter edit mode and discard (or save) - Click on stat button This will raise a traceback, since the `disabled` property is now gone. Indeed, the framework is adding/removing that attribute when entering or leaving edit mode. See disableButtons()/enableButtons()` called by _setEditMode()/_onDiscard()/..` Note: - With the new framework/owl, there is no TB as the `disabled` attribute is not removed anymore. - In 14.0, there is no issue despite the `disabled` attributed being removed. Fixes https://github.com/odoo/odoo/issues/78500 Closes https://github.com/odoo/odoo/pull/80884 Courtesy of @odooaktiv Forward-Port-Of: odoo/odoo#86392
Steps to reproduce the bug: - Enable “Storage Locations” option in the inventory settings - Go to Inventory > Configuration > Warehouse > locations - Choose any Location > Click on Current stock > Select any product - Try to add two line Problem: Traceback is triggered, Because the line should not be added twice(like in “Inventory Adjustments” view) and as in the `_onchange_location_or_product_id` we access the quantity, it should be only one quant: https://github.com/odoo/odoo/blob/15
Original PR description
Steps to reproduce the bug: - Enable “Storage Locations” option in the inventory settings - Go to Inventory > Configuration > Warehouse > locations - Choose any Location > Click on Current stock >…
Steps to reproduce the bug: - Enable “Storage Locations” option in the inventory settings - Go to Inventory > Configuration > Warehouse > locations - Choose any Location > Click on Current stock > Select any product - Try to add two line Problem: Traceback is triggered, Because the line should not be added twice(like in “Inventory Adjustments” view) and as in the `_onchange_location_or_product_id` we access the quantity, it should be only one quant: https://github.com/odoo/odoo/blob/15.0/addons/stock/models/stock_quant.py#L517 In v14, this list view is not editable, but since the refactor in v15 added the new view `stock.quant.inventory.tree.editable`, it is being called by this action Solution: set the `view_id` to `stock.quant.tree`, which is the view it was previously using opw-2779795 https://user-images.githubusercontent.com/78867936/158364388-ca8a3837-26ee-4ef1-a04a-bcbc6c0d8e95.mp4 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#86432
### Current behavior If no completed template (`completed_template_id`) is selected in the options of an elearning course, an error occurs when a user completes this course. ### Steps - Install elearning - (*with demo data*) Go to a course (e.g. Basics of Gardening) - Remove the selected "Completion Email" then save - Complete the course ### Reason We are trying to access a `record_email_values` value here [1] but no value is assigned to `record_email_values` unless we have a comple
Original PR description
### Current behavior If no completed template (`completed_template_id`) is selected in the options of an elearning course, an error occurs when a user completes this course. ### Steps - Install elearning - (*with demo data*) Go to a course (e.g. Basics of Gardening) - Remove the selected "Completion Email" then save - Complete the course ### Reason We are trying to access a `record_email_values` value here [1] but no value is assigned to `record_email_values` unless we have a completed_template [2]. [1] : https://github.com/odoo/odoo/blob/f4d83f31c12cb13d626bcaaa619c0f3be680cdbc/addons/website_slides/models/slide_channel.py#L110 [2] : https://github.com/odoo/odoo/blob/f4d83f31c12cb13d626bcaaa619c0f3be680cdbc/addons/website_slides/models/slide_channel.py#L105-L106 OPW-2753078 Forward-Port-Of: odoo/odoo#86486 Forward-Port-Of: odoo/odoo#84377
task-2734733 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82915
Original PR description
task-2734733 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#82915
Since [1] non-image documents uploaded in web editor were stored as received in base64 without being decoded. This led to downloading them as they were stored in base64. After this commit uploaded documents are base64-decoded before being stored. Steps to reproduce: - edit a web page - drop a "Text - Image" snippet - replace the image - upload a document (PDF, TXT...) - save page - download document => received document was base64-encoded [1]: https://github.com/odoo/odoo/comm
Original PR description
Since [1] non-image documents uploaded in web editor were stored as received in base64 without being decoded. This led to downloading them as they were stored in base64. After this commit uploaded documents are base64-decoded before being stored. Steps to reproduce: - edit a web page - drop a "Text - Image" snippet - replace the image - upload a document (PDF, TXT...) - save page - download document => received document was base64-encoded [1]: https://github.com/odoo/odoo/commit/6b8752604898bf2b583b7f5334e35f6a1583595e task-2782269 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#85733
Context ------- Web design specific require a lot of work and need maintenance. So far the style files were not taken into account despite the amount of maintenance they require. With this commit they are going to be counted, knowing they still can be excluded in the manifest. Imported module allow to deploy frontend assets: stylesheet, javascript, xml template and Qweb view that require as well some maintenance. They are going to be counted Implementation -------------- -
Original PR description
Context ------- Web design specific require a lot of work and need maintenance. So far the style files were not taken into account despite the amount of maintenance they require. With this commit they are going to be counted, knowing they still can be excluded in the manifest. Imported module allow to deploy frontend assets: stylesheet, javascript, xml template and Qweb view that require as well some maintenance. They are going to be counted Implementation -------------- - Add method to parse css and scss file - Include .scss and .css file in the count - Add external_id to attachment that store frontend asset of imported module - Find all attachment with .js, .css, .scss, .xml from imported module - Find qweb view from imported module - cound the content of the attachment and the qweb view -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#85854
Before this commit The style for `li.oe-nested` was loaded only when the editor loaded. The problem is that the style needs to be visible even when the editor has never been loaded. After this commit The style for `li.oe-nested` is always loaded in the backend and in the frontend. Task-2793528 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#86758
Original PR description
Before this commit The style for `li.oe-nested` was loaded only when the editor loaded. The problem is that the style needs to be visible even when the editor has never been loaded. After this commit The style for `li.oe-nested` is always loaded in the backend and in the frontend. Task-2793528 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#86758
When changing the structure of a kit, it lead to undesirable behaviors on Odoo **Issue 01:** 1. Create 3 products P_kit, P_compo01, P_compo02 - Type: Storable - Category: PC 2. Create a bill of materials: - Product: P_kit - Type: Kit - Components: - 1 x P_compo01 3. Create a purchase order PO with 2 x P_kit 4. Confirm PO and process the receipt 5. Edit the bill of materials of P_kit: - Add 1 x P_compo02 in components 6. Return 1 x P_compo01 7. Go
Original PR description
When changing the structure of a kit, it lead to undesirable behaviors on Odoo **Issue 01:** 1. Create 3 products P_kit, P_compo01, P_compo02 - Type: Storable - Category: PC 2. Create a bill of…
When changing the structure of a kit, it lead to undesirable behaviors
on Odoo
**Issue 01:**
1. Create 3 products P_kit, P_compo01, P_compo02
- Type: Storable
- Category: PC
2. Create a bill of materials:
- Product: P_kit
- Type: Kit
- Components:
- 1 x P_compo01
3. Create a purchase order PO with 2 x P_kit
4. Confirm PO and process the receipt
5. Edit the bill of materials of P_kit:
- Add 1 x P_compo02 in components
6. Return 1 x P_compo01
7. Go back to the PO
Error: The received quantity is 0 while it should be 1.0
When processing the return, the received quantity is recomputed, which
lead to:
https://github.com/odoo/odoo/blob/59fcb31f5a0b8136dae26b70ca0087f9b5cf3d24/addons/purchase_mrp/models/purchase_mrp.py#L29
However, since in the mean time the user added a new line in the BoM,
`_compute_kit_quantities` doesn't find any associated SM
(`bom_line_moves` is empty in [3]) and thus returns 0.
**Issue 02:**
(Need account_accountant. Use demo data)
1. Create a product category PC:
- Costing Method: AVCO
- Inventory Valuation: Automated
- Set up the Price Difference Account
2. Create 3 products P_kit, P_compo01, P_compo02
- Type: Storable
- Category: PC
3. Create a bill of materials:
- Product: P_kit
- Type: Kit
- Components:
- 1 x P_compo01
4. Create a purchase order PO with 1 x P_kit
5. Confirm PO and process the receipt
6. Edit the bill of materials of P_kit:
- Add 1 x P_compo02 in components
7. Create and Post the bill
Error: an Odoo Error is raised "ZeroDivisionError: float division by
zero"
While confirming the bill, some anglo saxo lines are generated. To do
so, the valuation of the kit is computed: [1]. In the above case, it
will lead to [2]. However, since in the mean time the user added a new
line in the BoM, `_compute_kit_quantities` doesn't find any associated
SM (`bom_line_moves` is empty in [3]) and thus returns 0. Back to [1],
the quantity is used to divide the total price -> it will raise an error
if this quantity is zero
**Suggestion:**
Such situations should not happen: once a product is used at least once,
it should not become a kit nor have a new structure (if it was already a
kit). Otherwise, `_compute_kit_quantities` will not correctly work since
it is not possible to take the BoM changes into consideration.
[1]
https://github.com/odoo/odoo/blob/abfe37fcea5b20f77799d9331d4d011530880669/addons/purchase_stock/models/account_invoice.py#L72-L74
[2]
https://github.com/odoo/odoo/blob/75191404788ab83645ee35b779991ea6fcdfa406/addons/purchase_mrp/models/stock_move.py#L19
[3]
https://github.com/odoo/odoo/blob/7d1af314320547ab5e37c1d97cad22992c98565b/addons/mrp/models/stock_move.py#L275-L294
OPW-2780855
Forward-Port-Of: odoo/odoo#86731
Forward-Port-Of: odoo/odoo#86670Forward-Port-Of: odoo/enterprise#25432 Forward-Port-Of: odoo/enterprise#24809
Original PR description
Forward-Port-Of: odoo/enterprise#25432 Forward-Port-Of: odoo/enterprise#24809
Step to reproduce: - Go to planning - Add a shift, on Field 'Resource'- Create New one - Save the shift - Publish and Send the shift - As there is no email set on newly created resource a pop op displayed - Click on field Manager/Coach/Department Current Behaviour: - Traceback - Company_id is not fetched but is necessary to change Manager/ Coach/Department Behaviour after PR: - Company is fetched and displayed in multicompany env opw-2783057 Forward-Port-Of: odoo/enterprise
Original PR description
Step to reproduce: - Go to planning - Add a shift, on Field 'Resource'- Create New one - Save the shift - Publish and Send the shift - As there is no email set on newly created resource a pop op displayed - Click on field Manager/Coach/Department Current Behaviour: - Traceback - Company_id is not fetched but is necessary to change Manager/ Coach/Department Behaviour after PR: - Company is fetched and displayed in multicompany env opw-2783057 Forward-Port-Of: odoo/enterprise#25122
Prior to this commit: - When a search containing (a) goup_by date field(s) was saved and set as favorite, the date field(s) were not removed from the group_by at the start of the timesheet app although it should be prevented as it leads to an inconsistant view as the dates are already displayed in the columns. A logic was actually set in place for the reload of the view but not for the load. After this commit: - The logic used in the reload of the view will be applied in t
Original PR description
Prior to this commit: - When a search containing (a) goup_by date field(s) was saved and set as favorite, the date field(s) were not removed from the group_by at the start of the timesheet app although it should be prevented as it leads to an inconsistant view as the dates are already displayed in the columns. A logic was actually set in place for the reload of the view but not for the load. After this commit: - The logic used in the reload of the view will be applied in the load, which will prevent applying the group_by on dates field when the app starts. - The sorting of the rows in the override of `_apply_grid_grouped_expand` in `account.analytic.line` now correctly handle non m2o fields in the group_by. task-2798904 Forward-Port-Of: odoo/enterprise#25418
To reproduce (V15): 1. Have PoS & IoT installed and connect an IoT box with a Worldline/Ingenico terminal 2. Enable Worldine in the PoS settings 3. Configure a payment method which use worldline and add the terminal as a device 4. Delete the IoT box (or unplug/replug the worldline terminal I guess ? didn't tested this yet) -> at this point the payment method doesn't have any terminal set (despite the fact that it is a mandatory field) 5. Open the PoS session (nothing prevent to do so
Original PR description
To reproduce (V15): 1. Have PoS & IoT installed and connect an IoT box with a Worldline/Ingenico terminal 2. Enable Worldine in the PoS settings 3. Configure a payment method which use worldline and…
To reproduce (V15): 1. Have PoS & IoT installed and connect an IoT box with a Worldline/Ingenico terminal 2. Enable Worldine in the PoS settings 3. Configure a payment method which use worldline and add the terminal as a device 4. Delete the IoT box (or unplug/replug the worldline terminal I guess ? didn't tested this yet) -> at this point the payment method doesn't have any terminal set (despite the fact that it is a mandatory field) 5. Open the PoS session (nothing prevent to do so) 6. Attempt to pay with the payment method => JS errors with `addlisteners` on `undefined` It does not reproduce in V13 and V14 as the error message is called in both version: https://github.com/odoo/enterprise/blob/4cf0e5364bf431b6f0429423298f84f7ae9e499a/pos_iot/static/src/js/payment.js#L15-L19 (this PR is based on this part of the code) It is not called in V15 due to the PR with Worldline made by ANP: https://github.com/odoo/enterprise/pull/19752 In particular: https://github.com/odoo/enterprise/pull/19752/files#diff-20e0165d72f4178ce9a9fdef6bcc66bef8cf6f1fb9198d4443b0a057d166de67L15-L19 OPW-2796474 OPW-2781069 OPW-2797155 Forward-Port-Of: odoo/enterprise#25413
When a user created a snapshot, the message `SNAPSHOT_CREATED` never reached the spreadsheet because the id was missing. Since the message is missed, the client does not have acknoledged the last server revision. All following operations are therefore sent with the wrong server revision id and they are all refused. Co-authored-by: Paul Morelle <pmo@odoo.com> Forward-Port-Of: odoo/enterprise#25409
Original PR description
When a user created a snapshot, the message `SNAPSHOT_CREATED` never reached the spreadsheet because the id was missing. Since the message is missed, the client does not have acknoledged the last server revision. All following operations are therefore sent with the wrong server revision id and they are all refused. Co-authored-by: Paul Morelle <pmo@odoo.com> Forward-Port-Of: odoo/enterprise#25409
Current behavior: When using the map the dates where not converted to the user timezone. Steps to reproduce: - Have inventory installed - Go in transfers - Go in the map view - The scheduled date of the transfers are wrong. opw-2743357 Forward-Port-Of: odoo/enterprise#24766
Original PR description
Current behavior: When using the map the dates where not converted to the user timezone. Steps to reproduce: - Have inventory installed - Go in transfers - Go in the map view - The scheduled date of the transfers are wrong. opw-2743357 Forward-Port-Of: odoo/enterprise#24766
Step to reproduce: - Create a new customer - Create a sale order for the customer. - Add a product and a section to the order lines - Confirm and deliver the order - Go to helpdesk and try to create a ticket for this customer Current Behaviour: - Traceback https://github.com/odoo/enterprise/blob/saas-15.1/helpdesk_stock/models/helpdesk.py#L24-L27 Also fetch notes and section which lead to traceback when processed Behaviour after PR: - Does not fetch Sections and Notes opw-278
Original PR description
Step to reproduce: - Create a new customer - Create a sale order for the customer. - Add a product and a section to the order lines - Confirm and deliver the order - Go to helpdesk and try to create a ticket for this customer Current Behaviour: - Traceback https://github.com/odoo/enterprise/blob/saas-15.1/helpdesk_stock/models/helpdesk.py#L24-L27 Also fetch notes and section which lead to traceback when processed Behaviour after PR: - Does not fetch Sections and Notes opw-2789110 Forward-Port-Of: odoo/enterprise#25160
To reproduce ============ - Create a user and give him/her ***Social Manager*** access rights. - Publish a post from another user. - The user with ***Social Manager*** access rights can't see this post. Purpose ======= The issue is that while creating a post that contains images, ***res_id*** field of created attachments is not set up. Specification ============= To solve the issue, while creating a post that contains images, ***res_id*** field of created attachments is set
Original PR description
To reproduce ============ - Create a user and give him/her ***Social Manager*** access rights. - Publish a post from another user. - The user with ***Social Manager*** access rights can't see this post. Purpose ======= The issue is that while creating a post that contains images, ***res_id*** field of created attachments is not set up. Specification ============= To solve the issue, while creating a post that contains images, ***res_id*** field of created attachments is set up to : `res_id = post.id` opw-2762203 Forward-Port-Of: odoo/enterprise#25379 Forward-Port-Of: odoo/enterprise#24830
There is an error occurring where because no default transaction code is provided by the results of the sql query when performing the cbs export. Some features of the intrastat report are difficult to retrieve within the sql query. Fortunately there exists a function on account.intrastat.report that fills in the missing values for you. However, it was not applied to the CBS export, this commit adds the _fill_missing_values method to the export. Forward-Port-Of: odoo/enterprise#25355
Original PR description
There is an error occurring where because no default transaction code is provided by the results of the sql query when performing the cbs export. Some features of the intrastat report are difficult to retrieve within the sql query. Fortunately there exists a function on account.intrastat.report that fills in the missing values for you. However, it was not applied to the CBS export, this commit adds the _fill_missing_values method to the export. Forward-Port-Of: odoo/enterprise#25355
#### The issue: The DTE XML sometimes includes flat discounts in the 'Detalle' section which are indicated using the `DescuentoMonto` tag. At the moment, these are not taken into account when generating a vendor bill from an incoming XML file. (Only percentage discounts, indicated using the `DescuentoPct` tag, are taken into account). #### The solution: Take the `DescuentoMonto` tag into account as well. Video explaining the issue and the solution: https://drive.google.com/
Original PR description
#### The issue: The DTE XML sometimes includes flat discounts in the 'Detalle' section which are indicated using the `DescuentoMonto` tag. At the moment, these are not taken into account when generating a vendor bill from an incoming XML file. (Only percentage discounts, indicated using the `DescuentoPct` tag, are taken into account). #### The solution: Take the `DescuentoMonto` tag into account as well. Video explaining the issue and the solution: https://drive.google.com/file/d/13J3DEx9iBdNrFhqjNQOaeWxCZ1KxkxtG/view?usp=sharing Issue 3 of ticket 2713156 Forward-Port-Of: odoo/enterprise#25344 Forward-Port-Of: odoo/enterprise#25124
When creating Quality Checks of type 'product' the sequence was not respecting the sequence of the corresponding Quality Points. Task-ID: 2784982 Forward-Port-Of: odoo/enterprise#25033
Original PR description
When creating Quality Checks of type 'product' the sequence was not respecting the sequence of the corresponding Quality Points. Task-ID: 2784982 Forward-Port-Of: odoo/enterprise#25033