Daily updates from Odoo
Wednesday, March 30, 2022
10 changes · master
Resolved issues and error corrections
This update prevents shared test settings in the Gantt planning view from being accidentally changed by one test and affecting later tests. It improves the reliability of automated checks, reducing false failures and helping development teams maintain quality with less rework.
Original PR description
Since https://github.com/odoo/enterprise/commit/fc5179a3580e1a01d66f5ebd0e2fc58854476e44 `ganttViewParams` which is used for all the tests is modified during the test on `collapse_first_level`. As such, it is potentially breaking tests that are performed after as they were relying on the fact that `collapse_first_level` is not set. This commit prevent the mutation of `ganttViewParams`. This commit also: - Adds missing `;` in tests. - Modifies some of the assert in order to improve debugging when test fails.
Code cleanup and technical improvements
The Gantt planning view was updated to stay compatible with a related platform change in how linked records are handled. This is an internal cleanup that helps keep scheduling features stable without changing the user experience.
Miscellaneous changes
Step to reproduce: - Create an approval with automated_sequence name (e.g. Number N) - Create another and discard before saving/submitting - Create a third approval Current Behaviour: - Third approval has number N+2 Behaviour after PR: - Approval are named on submission/write - Third approval has number N+1 opw-2715603 Forward-Port-Of: odoo/enterprise#24784 Forward-Port-Of: odoo/enterprise#23117
Original PR description
Step to reproduce: - Create an approval with automated_sequence name (e.g. Number N) - Create another and discard before saving/submitting - Create a third approval Current Behaviour: - Third approval has number N+2 Behaviour after PR: - Approval are named on submission/write - Third approval has number N+1 opw-2715603 Forward-Port-Of: odoo/enterprise#24784 Forward-Port-Of: odoo/enterprise#23117
**[FIX] stock_barcode: display warning** > Before this commit, the warning triggered by an onchange wasn't shown. > > How to reproduce: > - Create a product tracked by serial number; > - Create a new transfer and add a move line for this product; > - Open this transfer with the barcode application and open the move line form view; > - For the `qty_done`, set the quantity upper than 1 -> Should display a warning but doesn't. **[FIX] stock_barcode_picking_batch: suggested pack** >
Original PR description
**[FIX] stock_barcode: display warning** > Before this commit, the warning triggered by an onchange wasn't shown. > > How to reproduce: > - Create a product tracked by serial number; > - Create a new…
**[FIX] stock_barcode: display warning** > Before this commit, the warning triggered by an onchange wasn't shown. > > How to reproduce: > - Create a product tracked by serial number; > - Create a new transfer and add a move line for this product; > - Open this transfer with the barcode application and open the move line form view; > - For the `qty_done`, set the quantity upper than 1 -> Should display a warning but doesn't. **[FIX] stock_barcode_picking_batch: suggested pack** > Before this commit, if a package is scanned and assigned on a move line of a batch, it will not be immediately suggested on the other same picking's lines. It was due to the suggested packages were only computed when the state is created/refreshed. Now, it will also be done when a package is assigned on a line. **[FIX] stock_barcode: picking form view traceback** > How to reproduce: > - Use GS1 nomenclature; > - Open a picking form view and edit it; > - Scan a barcode -> Traceback. > > The issue was, when the barcode is parsed, the parsed result isn't the same if it's parsed by the default nomenclature (returns always a dict) or by the GS1 nomenclature (returns a list of dict or nothing at all) and the current code doesnt' support if the parsing result is None. > > With this fix, the barcode will be parsed only if the nomenclature isn't a GS1 nomenclature. That means the default search on the different model's types will be processed in case the company use the GS1 nomenclature. task-2641528 Forward-Port-Of: odoo/enterprise#20922
The supplier can now be identified by its associated IBANs. Task: 2800584 Forward-Port-Of: odoo/enterprise#25651 Forward-Port-Of: odoo/enterprise#25550
Original PR description
The supplier can now be identified by its associated IBANs. Task: 2800584 Forward-Port-Of: odoo/enterprise#25651 Forward-Port-Of: odoo/enterprise#25550
Steps : Install Subscription. Create a 2nd company (say B, and A the first one). Create a Subscription for Portal in B, and make sure you already have 3 Subs for him in A. Log in with Portal in A. On the home page, note 'Subscription - x' (x the Subs count in A). Click on it. Issue : You see all your Subs, A and B included (more than x Subs). Fix : If user has access, count with sudo. opw-2802829 Forward-Port-Of: odoo/enterprise#25557
Original PR description
Steps : Install Subscription. Create a 2nd company (say B, and A the first one). Create a Subscription for Portal in B, and make sure you already have 3 Subs for him in A. Log in with Portal in A. On the home page, note 'Subscription - x' (x the Subs count in A). Click on it. Issue : You see all your Subs, A and B included (more than x Subs). Fix : If user has access, count with sudo. opw-2802829 Forward-Port-Of: odoo/enterprise#25557
Purpose ======= This issue is caused by the forwarded fix from my [PR](https://github.com/odoo/enterprise/pull/25234) where I didn't pay attention that `tag_ids` was renamed to `tax_tag_ids` in v14 and `tax_exigible = True` was removed in v15. Specification ============= To solve the issue the domain was corrected opw-2809024 Forward-Port-Of: odoo/enterprise#25721 Forward-Port-Of: odoo/enterprise#25712
Original PR description
Purpose ======= This issue is caused by the forwarded fix from my [PR](https://github.com/odoo/enterprise/pull/25234) where I didn't pay attention that `tag_ids` was renamed to `tax_tag_ids` in v14 and `tax_exigible = True` was removed in v15. Specification ============= To solve the issue the domain was corrected opw-2809024 Forward-Port-Of: odoo/enterprise#25721 Forward-Port-Of: odoo/enterprise#25712
A write function should always have a return statement opw-2797958 Forward-Port-Of: odoo/enterprise#25531
Original PR description
A write function should always have a return statement opw-2797958 Forward-Port-Of: odoo/enterprise#25531
It was no longer possible to mark an appraisal as done without HR Officer rights. TaskID: 2802762 Forward-Port-Of: odoo/enterprise#25545
Original PR description
It was no longer possible to mark an appraisal as done without HR Officer rights. TaskID: 2802762 Forward-Port-Of: odoo/enterprise#25545
Steps to reproduce: 1) Create the system parameter 'l10n_be_reports.xml_export_representative_*'. To do so, first, ensure that you are on debug mode then, go to the application ‘Setting’, then click on ‘Technical > Parameter > System parameter’. Create a new parameter (l10n_be_reports.xml_export_representative_*) and replace the * by the ID of your company and define the value of the parameter as the Partner ID to be used as a proxy (ID of the accounting company). For example: if the ID of you
Original PR description
Steps to reproduce: 1) Create the system parameter 'l10n_be_reports.xml_export_representative_*'. To do so, first, ensure that you are on debug mode then, go to the application ‘Setting’, then click…
Steps to reproduce: 1) Create the system parameter 'l10n_be_reports.xml_export_representative_*'. To do so, first, ensure that you are on debug mode then, go to the application ‘Setting’, then click on ‘Technical > Parameter > System parameter’. Create a new parameter (l10n_be_reports.xml_export_representative_*) and replace the * by the ID of your company and define the value of the parameter as the Partner ID to be used as a proxy (ID of the accounting company). For example: if the ID of your company is 4 and the ID of the fiduciary is 12, you will create the following parameter l10n_be_reports.xml_export_representative_4 with 12 as the value. More information in the following video: https://drive.google.com/file/d/1FVKqVXYyYa4VbBGZEomDFOBdt3_ZETsj/view 2) Ensure that the Partner has a phone number 3) Export XML for report (Partner VAT Listing) Issue: The file contains phone numbers with spaces => NOK Cause: Partners and companies numbers are sanitised automatically with `phonenumbers`. And those numbers have spaces in their format which is not accepted according to the specification https://finances.belgium.be/fr/E-services/Intervat/documentation-technique. Solution: Extract the pattern accepted by intervat; That is, phone numbers with no spaces. The library `phonenumbers` has not been used to avoid complexity in case of the library is not installed. OPW-2454136 Forward-Port-Of: odoo/enterprise#25542 Forward-Port-Of: odoo/enterprise#24923