Tuesday, April 12, 2022
8 changes · master
Resolved issues and error corrections
This update adjusts an internal Belgian payroll accounting performance test to allow for extra database work when a company logo is loaded. It helps keep automated testing reliable after a related platform change, with no expected impact on day-to-day users.
Original PR description
Following change at odoo/odoo@3c6263316054b In case the company of the user is not cached, may produce more queries. The queries are to fetch the logo (related partner_id.image_1920) on the tested company instead of keeping the one of the user. Related to odoo/odoo#86356
Code cleanup and technical improvements
The spreadsheet document functionality has been consolidated back into one module to simplify how it is maintained. This reduces internal complexity and should make future additions, including accounting-related features, easier and safer to deliver.
Original PR description
The Split between the 2 modules (`documents_spreadsheet`, `documents_spreadsheet_bundle`) was introduced for clarify the split of lazy loaded files from the other files. There are 2 issues introduced with this split: 1. it introduced some weird dependency map between the modules: `documents_spreadsheet_bundle` depends on `documents_spreadsheet` even though the latter cannot work without the former. 2. The split is not that clear and is somewhat faulty: some code that can be lazy loaded is in `documents_sreapdsheets` - some templates are separated from the compnent definition file We are now adding features that will depend on Accounting and the dependency mapping will be even more complicated. All-in-all, it seems like it's not really necessary and we can split the files in different folders inside a single module. Task 2809220
This update simplifies internal filtering rules used across several Odoo business modules. It keeps behavior the same while making queries easier to maintain and less likely to cause future issues.
Miscellaneous changes
Forward-Port-Of: odoo/enterprise#26119
Original PR description
Forward-Port-Of: odoo/enterprise#26119
fix the bug by filtering sign.item.types by new flag editWhileSigningAllowed reproduce: Use non en_US "sign now" a new document click 'edit' button result: no item in the toolbar reason: the 'name' of the item is translated in non en_US Forward-Port-Of: odoo/enterprise#26094
Original PR description
fix the bug by filtering sign.item.types by new flag editWhileSigningAllowed reproduce: Use non en_US "sign now" a new document click 'edit' button result: no item in the toolbar reason: the 'name' of the item is translated in non en_US Forward-Port-Of: odoo/enterprise#26094
Following odoo/odoo#88025, create a new Transifex project for localisations Forward-Port-Of: odoo/enterprise#26060 Forward-Port-Of: odoo/enterprise#26037
Original PR description
Following odoo/odoo#88025, create a new Transifex project for localisations Forward-Port-Of: odoo/enterprise#26060 Forward-Port-Of: odoo/enterprise#26037
Steps to reproduce: - install the Field Service app and activate worksheets in the settings - create and try to delete a worksheet template (in the configuration menu) Current behavior: The deletion creates an error and the worksheet template is not deleted Expected behavior: The deletions creates no error and the worksheet template is deleted The error was due to fact that the worksheet template was deleted twice. A first time during the deletion of the model link to its model_id
Original PR description
Steps to reproduce: - install the Field Service app and activate worksheets in the settings - create and try to delete a worksheet template (in the configuration menu) Current behavior: The deletion…
Steps to reproduce: - install the Field Service app and activate worksheets in the settings - create and try to delete a worksheet template (in the configuration menu) Current behavior: The deletion creates an error and the worksheet template is not deleted Expected behavior: The deletions creates no error and the worksheet template is deleted The error was due to fact that the worksheet template was deleted twice. A first time during the deletion of the model link to its model_id field via the "ondelete=cascade" option and a second time when it called super.unlink(). https://github.com/odoo/enterprise/blob/1f969053186413aaf67a92cfdf5a822b3a8ea002/worksheet/models/worksheet_template.py#L23 https://github.com/odoo/enterprise/blob/1f969053186413aaf67a92cfdf5a822b3a8ea002/worksheet/models/worksheet_template.py#L86-L88 Because we can not modify the model to remove the cascade deletion and that the deletion of the linked model is necessary, we just return True instead of the second deletion. opw-2810142 Forward-Port-Of: odoo/enterprise#25872
Following change at odoo/odoo@3c6263316054b In case the company of the user is not cached, may produce more queries. The queries are to fetch the logo (related partner_id.image_1920) on the tested company instead of keeping the one of the user. Related to odoo/odoo#88416 Forward-Port-Of: odoo/enterprise#26108
Original PR description
Following change at odoo/odoo@3c6263316054b In case the company of the user is not cached, may produce more queries. The queries are to fetch the logo (related partner_id.image_1920) on the tested company instead of keeping the one of the user. Related to odoo/odoo#88416 Forward-Port-Of: odoo/enterprise#26108