Monday, April 25, 2022
5 changes · master
Enhancements to existing features
Product variant records will now prevent missing combination information, reducing the chance of duplicate or inconsistent variants after migrations or external database updates. This helps keep product catalogs more reliable without changing day-to-day workflows.
Original PR description
On [1] it was wrongly assumed that `required` was unnecessary because the field is computed and the compute method never set NULL. However [2] highlighted cases where the field was NULL in database. This can especially happen after a migration, or more generally for any database change made outside the ORM. To avoid issues, we need to ensure the same product.template does not have two variants one with empty string and one with NULL, thus making the field required to prevent NULL values. [1] 22a11a6f4d0b08a56712fafd0f87a2e7bb5b00ec [2] 03e7efc3b4592c5f063c665130011a91fcc4d683
This update adds test coverage to help ensure timesheet reminders, attendance reporting, multi-company timesheets, and time off-related timesheet entries behave correctly. It reduces the risk of payroll, approval, and absence-tracking issues by validating important business scenarios such as holidays overlapping with approved time off.
Original PR description
Reminders- - employee reminder: an email should be sent when the employee has timesheet less hours than he should have - manager reminder: an email should be sent when the manager has not validated timesheets within the corresponding timeframe. Timesheet / attendance report Time off - public holidays should not generate an entry if the employee is already on time off - the project and task set on the time off type should be set on the generated timesheets task-2727561
This update aligns the activity component with Odoo interface guidelines in Mail and eLearning slides. Users get a more consistent experience when viewing and managing activities across these areas.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adds checks to ensure timesheet reminder emails are sent when employees are short on hours and when managers have pending validations. It also improves testing around resetting validated timesheets back to draft, helping protect key timesheet approval workflows from regressions.
Original PR description
Reminders- - employee reminder: an email should be sent when the employee has timesheet less hours than he should have - manager reminder: an email should be sent when the manager has not validated timesheets within the corresponding timeframe. Timesheets validation - reset a timesheet to draft task-2727561
New PLM engineering change records created together now receive separate sequence numbers instead of sharing the same order. This improves list ordering and helps teams distinguish and manage newly created records more reliably.
Original PR description
`_add_missing_default_values` was made to work in batch, and this commit takes advantage of that to increase the sequence for each new record in the batch. Before this commit, all records created in a batch would have the same sequence. Enterprise counterpart of odoo/odoo#36704