Sunday, May 15, 2022
3 changes · master
Miscellaneous changes
The current problem is that the codice fiscale field is validated using a regex that matches an alphanumeric code of 16 digits (that causes no problems) and both a simple numeric code (of 11 digits) and an alphanumeric code (of 13 digits, starting with the country code 'IT') for businesses. The problem is that the systems that make use of the codice fiscale code tend to utilise the former (i.e. the 11 digit code, without the 'IT' prefix). The filename for the EDI comprises a country cod
Original PR description
The current problem is that the codice fiscale field is validated using a regex that matches an alphanumeric code of 16 digits (that causes no problems) and both a simple numeric code (of 11 digits)…
The current problem is that the codice fiscale field is validated using a regex that matches an alphanumeric code of 16 digits (that causes no problems) and both a simple numeric code (of 11 digits) and an alphanumeric code (of 13 digits, starting with the country code 'IT') for businesses. The problem is that the systems that make use of the codice fiscale code tend to utilise the former (i.e. the 11 digit code, without the 'IT' prefix). The filename for the EDI comprises a country code, the codice fiscale of the company and a progressive number. When the codice fiscale is completed as being eg. 'IT00465840031', the country code + codice fiscale will be 'ITIT00465840031', which will be rejected by the edi system (a single country code is expected). This commit removes the 'IT' by utilising a function on the template (normalise_codice_fiscale). The reason this function is employed here is that clients will have already registered using the codice fiscale on the proxy server. The validation regex has also been changed to prevent new companies from registering using a codice fiscale prefixed with IT. related ticket-id: 2845341 Forward-Port-Of: odoo/odoo#90900
Prevent erasing of a tax line entry if there is a tax related to it in the invoice This is actually checking if for each tax of each line of invoice in the move, there exist a tax entry. This will prevent the users from accidentally or dully erasing tax lines which includes 0% taxes. If the users delete the line containing tax, it will be added again the same way as the counterpart line for an invoice-line is being added. Also, fixes the following: Recalculating all invoices if a singl
Original PR description
Prevent erasing of a tax line entry if there is a tax related to it in the invoice This is actually checking if for each tax of each line of invoice in the move, there exist a tax entry. This will prevent the users from accidentally or dully erasing tax lines which includes 0% taxes. If the users delete the line containing tax, it will be added again the same way as the counterpart line for an invoice-line is being added. Also, fixes the following: Recalculating all invoices if a single invoice in a batch has a line with `recompute_tax_line` set should not be allowed. Deleting a tax account entry of a posted move should not be allowed. task ID:2834679 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91140 Forward-Port-Of: odoo/odoo#90834
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91020
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91020