Tuesday, May 17, 2022
25 changes · master
Enhancements to existing features
This update changes how a sales stock screen button is handled so other customizations can still find and reuse it. It helps businesses with tailored Odoo setups avoid unnecessary conflicts when extending stock-related sales workflows.
Original PR description
Maybe a custom module wants to use/reference this button. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Features or functions removed from Odoo
This update removes unused menu entries and renames an internal file so its purpose is clearer. The change reduces background clutter in the database without altering day-to-day sales or inventory workflows.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
The mail invitation interface for real-time calls was reviewed and its styling was simplified as part of a broader visual cleanup. This should make the code easier to maintain while preserving the existing user experience.
Original PR description
Part of the overall v16 SCSS optimization/restyle, task-2704984 task-2855524 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
To reproduce ============ - Create a new Survey. - Add questions under at least two sections. - In Options, ensure that each section is displayed on its own page. - Click "Share" and open the share link. - Partially complete the survey and close the window before submitting. - From the survey click "See Results". Then choose a response to a question from the partially completed answer. - A traceback raised Purpose ======= On this condition : https://github.com/odoo/odoo/blob/36
Original PR description
To reproduce ============ - Create a new Survey. - Add questions under at least two sections. - In Options, ensure that each section is displayed on its own page. - Click "Share" and open the share link. - Partially complete the survey and close the window before submitting. - From the survey click "See Results". Then choose a response to a question from the partially completed answer. - A traceback raised Purpose ======= On this condition : https://github.com/odoo/odoo/blob/3602fdfc0ce8ed76a530c8c3cc1d49eecf9d250c/addons/survey/views/survey_templates.xml#L27 we check if we have to display the progression or not, in case of consulting results it doesn't make sense displaying it. That means the check made in `t-if` was not enough in this case and a condition is missing. Specification ============= to solve the issue the condition `not survey_form_readonly` was added opw-2821478 Forward-Port-Of: odoo/odoo#91442
Before this commit, when searching something via the searchbar snippet when it is in a mega menu, the dropdown that appears could not overflow the mega menu dropdown and thus was mostly hidden. opw-2779432 Before this commit:  After this commit:  Forward-Port-Of:
Original PR description
Before this commit, when searching something via the searchbar snippet when it is in a mega menu, the dropdown that appears could not overflow the mega menu dropdown and thus was mostly hidden. opw-2779432 Before this commit:  After this commit:  Forward-Port-Of: odoo/odoo#91461 Forward-Port-Of: odoo/odoo#91193
How to reproduce the bug ? - install the inventory app - open the app and try to import a file where at least one cell has a wrong value What is the bug ? When you try to import a file in the inventory app where at least one cell has a wrong value, the file won't be imported. In addition to that, you will get an error saying that one python module is missing while this might not be the case. opw-2715625 Signed-off-by: Adrien Minet <admi@odoo.com> -- I confirm I have signe
Original PR description
How to reproduce the bug ? - install the inventory app - open the app and try to import a file where at least one cell has a wrong value What is the bug ? When you try to import a file in the inventory app where at least one cell has a wrong value, the file won't be imported. In addition to that, you will get an error saying that one python module is missing while this might not be the case. opw-2715625 Signed-off-by: Adrien Minet <admi@odoo.com> -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#84690
Description of the issue/feature this PR addresses: - Could not use standard external layouts - alignment of some fields were weird Current behavior before PR: - layout was stuck to a custom one Desired behavior after PR is merged: - it is now possible to select the layout from the general settings -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#88900 Forward-Port-Of: odoo/odoo#84050
Original PR description
Description of the issue/feature this PR addresses: - Could not use standard external layouts - alignment of some fields were weird Current behavior before PR: - layout was stuck to a custom one Desired behavior after PR is merged: - it is now possible to select the layout from the general settings -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#88900 Forward-Port-Of: odoo/odoo#84050
Since 15.2, when creating an invoice containing both a recipient address and an invoice address, the addresses would both appear on the left, one after the other. This made reading difficult and the invoice unclear. This PR aligns the delivery and the recipient address on each side of the page when necessary, while not changing the outcome if a single address is given. Also displays a "title" to the recipient when necessary address to make things clearer. task-2809240 Forward-Port-O
Original PR description
Since 15.2, when creating an invoice containing both a recipient address and an invoice address, the addresses would both appear on the left, one after the other. This made reading difficult and the invoice unclear. This PR aligns the delivery and the recipient address on each side of the page when necessary, while not changing the outcome if a single address is given. Also displays a "title" to the recipient when necessary address to make things clearer. task-2809240 Forward-Port-Of: odoo/odoo#89827 Forward-Port-Of: odoo/odoo#87575
Lines cannot be deleted if the order is confirmed. However, notes/sections lines still might be changed. So, let delete such lines too. STEPS: 1. Create SO, add product and add note 2. Confirm SO 3. Remove note --- opw-2852676 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91509
Original PR description
Lines cannot be deleted if the order is confirmed. However, notes/sections lines still might be changed. So, let delete such lines too. STEPS: 1. Create SO, add product and add note 2. Confirm SO 3. Remove note --- opw-2852676 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91509 Forward-Port-Of: odoo/odoo#91336
This commit fixes the Signup link under the quiz validation. widget.url is not defined in widget. Now we use the redirectUrl from the widget as redirect after the signup. It has been detected by a high number of hit on /web/undefined Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91374 For
Original PR description
This commit fixes the Signup link under the quiz validation. widget.url is not defined in widget. Now we use the redirectUrl from the widget as redirect after the signup. It has been detected by a high number of hit on /web/undefined Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91374 Forward-Port-Of: odoo/odoo#91342
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91546
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#91546
New name and email same github account. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#90945
Original PR description
New name and email same github account. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#90945
…ing newer messages on the server Actually, the risk is almost nothing to not send acks of received messages. Doing the ack is a bigger risk if right before the ack a newer message would arrive. This state is the default state that does not need to be acked at all as there is no file associated with it. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the P
Original PR description
…ing newer messages on the server Actually, the risk is almost nothing to not send acks of received messages. Doing the ack is a bigger risk if right before the ack a newer message would arrive. This state is the default state that does not need to be acked at all as there is no file associated with it. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#85551
Issue: When receiving a mail with a facturx XML file as attachment, the datas in the XML files are not parsed. Cause: For security reason, if a mail attachment is a XML file, it will be saved as plain text and therefore not be parsed. Solution: If attachment mimetype is `plain/text` and content starts with `<?xml`, consider attachment as XML for the parsing. opw-2655445 Forward-Port-Of: odoo/odoo#91196
Original PR description
Issue: When receiving a mail with a facturx XML file as attachment, the datas in the XML files are not parsed. Cause: For security reason, if a mail attachment is a XML file, it will be saved as plain text and therefore not be parsed. Solution: If attachment mimetype is `plain/text` and content starts with `<?xml`, consider attachment as XML for the parsing. opw-2655445 Forward-Port-Of: odoo/odoo#91196
…ccount.move It was noticed while testing that by duplicating an accepted boleta it would be added to an existing vat book in the draft state, while we never add it in the draft state. The link to the sales book was copied and that seemed to be the culprit. So, we put copy False. Forward-Port-Of: odoo/enterprise#26917
Original PR description
…ccount.move It was noticed while testing that by duplicating an accepted boleta it would be added to an existing vat book in the draft state, while we never add it in the draft state. The link to the sales book was copied and that seemed to be the culprit. So, we put copy False. Forward-Port-Of: odoo/enterprise#26917
The search method for the computed company_id field goes through `_compute_fields` which has restrictions on computing records belonging to multiple models. Any search or method that uses a field computed by `_compute_fields` and does not group by records' res_model will cause a validation error in getting the _original_records if there are records from different models. Changing the _compute_fields to group by model. Forward-Port-Of: odoo/enterprise#27424
Original PR description
The search method for the computed company_id field goes through `_compute_fields` which has restrictions on computing records belonging to multiple models. Any search or method that uses a field computed by `_compute_fields` and does not group by records' res_model will cause a validation error in getting the _original_records if there are records from different models. Changing the _compute_fields to group by model. Forward-Port-Of: odoo/enterprise#27424
Merges fixes related to bug introduced after the refactor in OWL2. Forward-Port-Of: odoo/enterprise#27432
Original PR description
Merges fixes related to bug introduced after the refactor in OWL2. Forward-Port-Of: odoo/enterprise#27432
Since https://github.com/odoo/enterprise/pull/23903, when in the reports pages, having no journal checked would turn them all to checked. This was coherent with the displayed report. However, selecting a single journal (for example) from having them all selected had become uncomfortable. Furthermore and more importantly, the "All journals" filter would continue to be applied on audited journal items. --***Description of the bug***-- Register two payments for two bills, one from the Ban
Original PR description
Since https://github.com/odoo/enterprise/pull/23903, when in the reports pages, having no journal checked would turn them all to checked. This was coherent with the displayed report. However,…
Since https://github.com/odoo/enterprise/pull/23903, when in the reports pages, having no journal checked would turn them all to checked. This was coherent with the displayed report. However, selecting a single journal (for example) from having them all selected had become uncomfortable. Furthermore and more importantly, the "All journals" filter would continue to be applied on audited journal items. --***Description of the bug***-- Register two payments for two bills, one from the Bank account, the other from the Cash account. On the Cash Flow Statement report, under 'Cash paid for operating activities', click 600000 Expenses --> Journal Items. No line would appear because the journal filter would still be silently applied. It wasn't however possible to deactivate it from this page. --***Further informations discovered during the fixing***-- This was the opportunity to realize that the informations displayed under the lines displayed in the audited journal items weren't coherent with the information we wish to display. The filters applied are not pertinent and the lines in themselves are not always relevant to the situation. Since this is error-prone and problematic, we decided to remove the access to those informations. A bigger fix is planned and will make them available again, corrected. --***FIX***-- Reverted the previous way of functioning concerning the Checking of Journals in the reports : If no journal is selected, all of them still are taken into account in the reports, but they do not appear as checked. This makes checking a few journals more comfortable and the filter doesn't transfer to another report's page afterwards. Disabled the possibility to display the problematic journal items from the Cash Flow Report. Related : https://github.com/odoo/enterprise/pull/27374 Forward-Port-Of: odoo/enterprise#27403 Forward-Port-Of: odoo/enterprise#26968
Without this, the `_log_access` flag is reset to its default value (`True`), which declares the log access column. These columns are however not defined in the SQL view. Forward-Port-Of: odoo/enterprise#27392 Forward-Port-Of: odoo/enterprise#27305
Original PR description
Without this, the `_log_access` flag is reset to its default value (`True`), which declares the log access column. These columns are however not defined in the SQL view. Forward-Port-Of: odoo/enterprise#27392 Forward-Port-Of: odoo/enterprise#27305
If you had an account.move field required in a view, but not required on field values, the creation of account.move from document should not be blocked. With this change, we keep using the "Form" to get onchange result, but we (as is the case since ebe819b603) but we ignore any view required modifiers (if the field is really required, it would fail at record creation). opw-2802277 Forward-Port-Of: odoo/enterprise#27212
Original PR description
If you had an account.move field required in a view, but not required on field values, the creation of account.move from document should not be blocked. With this change, we keep using the "Form" to get onchange result, but we (as is the case since ebe819b603) but we ignore any view required modifiers (if the field is really required, it would fail at record creation). opw-2802277 Forward-Port-Of: odoo/enterprise#27212
Adapted the xpath of l10n_mx_edi_cfdi_supplier_rfc to allow it to display correctly after the modifications made to report_invoice. See https://github.com/odoo/odoo/pull/89827 task-2809240 Forward-Port-Of: odoo/enterprise#27240
Original PR description
Adapted the xpath of l10n_mx_edi_cfdi_supplier_rfc to allow it to display correctly after the modifications made to report_invoice. See https://github.com/odoo/odoo/pull/89827 task-2809240 Forward-Port-Of: odoo/enterprise#27240
When looking for taxes used on previous invoices, the filtering on `amount`, `amount_type` and `type_tax_use` weren't applied. Forward-Port-Of: odoo/enterprise#27274 Forward-Port-Of: odoo/enterprise#26839
Original PR description
When looking for taxes used on previous invoices, the filtering on `amount`, `amount_type` and `type_tax_use` weren't applied. Forward-Port-Of: odoo/enterprise#27274 Forward-Port-Of: odoo/enterprise#26839
Current behavior: When selling a product with a weight set on in a package. Then going in the barcode app > delivery orders, the computed weight in the delivery order linked to the sale order is always 0 Steps to reproduce: - Create a product with a weight (e.g. 1kg) - Create a quotation with this product - Confirm the quotation and in the delivery put the product in a pack - Go in the barcode app > operations > delivery orders - Select your delivery order - Click on the "Pen" next t
Original PR description
Current behavior: When selling a product with a weight set on in a package. Then going in the barcode app > delivery orders, the computed weight in the delivery order linked to the sale order is always 0 Steps to reproduce: - Create a product with a weight (e.g. 1kg) - Create a quotation with this product - Confirm the quotation and in the delivery put the product in a pack - Go in the barcode app > operations > delivery orders - Select your delivery order - Click on the "Pen" next to the product - Open the external link of the pack - The computed weight is always 0 opw-2843200 Forward-Port-Of: odoo/enterprise#27322
Forward-Port-Of: odoo/enterprise#27350 Forward-Port-Of: odoo/enterprise#27307
Original PR description
Forward-Port-Of: odoo/enterprise#27350 Forward-Port-Of: odoo/enterprise#27307
Step to reproduce: -Install and set up accounting with colombian localization and l10n_co_edi -Create an invoice with a note that contains a full URL and confirm it -print and check the xml file generated Expected behavior: The <NOT_1>3.- field contains the url once Current behavior: The <NOT_1>3.- field contains twice the url Explanation: The function html2plaintext called on the narration removes the a tag but not the href field so the URL appears twice. To solve the issue we
Original PR description
Step to reproduce: -Install and set up accounting with colombian localization and l10n_co_edi -Create an invoice with a note that contains a full URL and confirm it -print and check the xml file generated Expected behavior: The <NOT_1>3.- field contains the url once Current behavior: The <NOT_1>3.- field contains twice the url Explanation: The function html2plaintext called on the narration removes the a tag but not the href field so the URL appears twice. To solve the issue we remove the <a ...> tags before applying html2plaintext. opw-2794739 Forward-Port-Of: odoo/enterprise#27335 Forward-Port-Of: odoo/enterprise#26763