Thursday, May 26, 2022
3 changes · master
Miscellaneous changes
Correct forward port of https://github.com/odoo/odoo/commit/d80dfd30ffb6524024999f88e069a400884e605b. This fixes a bad forward port (see https://github.com/odoo/odoo/pull/90866). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#92230
Original PR description
Correct forward port of https://github.com/odoo/odoo/commit/d80dfd30ffb6524024999f88e069a400884e605b. This fixes a bad forward port (see https://github.com/odoo/odoo/pull/90866). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#92230
Since (at least) Chrome 94+, some element's sizing computation returns a slightly different value (in the order of a fraction of a pixel). Sadly, due to rounding, this difference has an impact on exact sizing assertion. As the difference is *really* small, introducing a margin of error (i.e. <= 1px) looks reasonnable ; as implemented in this commit. More specifically as Element.scrollHeight can have either an int or a decimal value (cf. fractional-scaling), this commit allows to propert
Original PR description
Since (at least) Chrome 94+, some element's sizing computation returns a slightly different value (in the order of a fraction of a pixel). Sadly, due to rounding, this difference has an impact on exact sizing assertion. As the difference is *really* small, introducing a margin of error (i.e. <= 1px) looks reasonnable ; as implemented in this commit. More specifically as Element.scrollHeight can have either an int or a decimal value (cf. fractional-scaling), this commit allows to property handle both usecases. Reference: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight#determine_if_an_element_has_been_totally_scrolled Forward-Port-Of: odoo/odoo#92320 Forward-Port-Of: odoo/odoo#92182
Since (at least) Chrome 94+, some element's sizing computation returns a slightly different value (in the order of a fraction of a pixel). Sadly, due to rounding, this difference has an impact on exact sizing assertion. As the difference is *really* small, introducing a margin of error (i.e. <= 1px) looks reasonnable ; as implemented in this commit. More specifically as Element.scrollHeight can have either an int or a decimal value (cf. fractional-scaling), this commit allows to propert
Original PR description
Since (at least) Chrome 94+, some element's sizing computation returns a slightly different value (in the order of a fraction of a pixel). Sadly, due to rounding, this difference has an impact on exact sizing assertion. As the difference is *really* small, introducing a margin of error (i.e. <= 1px) looks reasonnable ; as implemented in this commit. More specifically as Element.scrollHeight can have either an int or a decimal value (cf. fractional-scaling), this commit allows to property handle both usecases. Reference: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight#determine_if_an_element_has_been_totally_scrolled Forward-Port-Of: odoo/enterprise#27786 Forward-Port-Of: odoo/enterprise#27727