Monday, June 13, 2022
24 changes · master
Enhancements to existing features
This update makes the messaging framework available to the website live chat experience, laying groundwork for a future modernization of live chat behavior and interface. It also includes reliability fixes that prevent repeated service startup and avoid error loops when website assets are missing.
Original PR description
This commit make messaging service available in the frontend and in the livechat external lib bundle. This is preparation to refactoring JS livechat to use models and OWL. *: bus, mail, survey, web, website_livechat Task-2870899
The mail chat window header no longer includes controls for shifting a chat left or right. This simplifies the chat interface and reduces options that were likely unnecessary or confusing for users.
Original PR description
Task-2882557
The spreadsheet document action label was adjusted from “Save as Template” to “Save as template” for more consistent wording. This is a small user interface polish that helps keep menu and wizard text aligned across the Documents spreadsheet experience.
Original PR description
`Save as Template` => `Save as template` task 2824232
Miscellaneous changes
Since this commit https://github.com/odoo/odoo/commit/06a8c5264eb6e87c29ad1d23a14e12dd45aa281c the function sleep was not available when executing python code in safe_eval opw:2858779 Forward-Port-Of: odoo/odoo#93045
Original PR description
Since this commit https://github.com/odoo/odoo/commit/06a8c5264eb6e87c29ad1d23a14e12dd45aa281c the function sleep was not available when executing python code in safe_eval opw:2858779 Forward-Port-Of: odoo/odoo#93045
Description of the issue/feature this PR addresses: The template of the standard emoji picker has recently been updated. This commit will update the emoji picker of Knowledge to make the custom components compatible with the new standard templates. Current behavior before PR: When the user opens the emoji picker, the system shows a traceback because some template variables are not defined on the custom emoji component of Knowledge. ``` Error: Invalid loop expression prepareList@h
Original PR description
Description of the issue/feature this PR addresses: The template of the standard emoji picker has recently been updated. This commit will update the emoji picker of Knowledge to make the custom…
Description of the issue/feature this PR addresses:
The template of the standard emoji picker has recently been updated. This commit will update the emoji picker of Knowledge to make the custom components compatible with the new standard templates.
Current behavior before PR:
When the user opens the emoji picker, the system shows a traceback because some template variables are not defined on the custom emoji component of Knowledge.
```
Error: Invalid loop expression
prepareList@https://16138668-master-all.runbot71.odoo.com/web/assets/1694-d28bc19/web.assets_common.min.js:1230:12
template@https://16138668-master-all.runbot71.odoo.com/web/assets/1694-d28bc19/web.assets_common.min.js line 1583 > Function:19:67
_render@https://16138668-master-all.runbot71.odoo.com/web/assets/1694-d28bc19/web.assets_common.min.js:1092:96
render@https://16138668-master-all.runbot71.odoo.com/web/assets/1694-d28bc19/web.assets_common.min.js:1091:6
initiateRender@https://16138668-master-all.runbot71.odoo.com/web/assets/1694-d28bc19/web.assets_common.min.js:1132:47
```
Desired behavior after PR is merged:
The emoji picker works properly.
task-2871883
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#92863There was an issue when canceling the move of an article from one section to another: a previous move which was not canceled could be undone when it should not have been. Impacted versions: * 15.4+ Steps to reproduce: 1. Have one article (A) in the "workspace" section and one article (B) in the "private" section 2. move (A) into "private", validate the move in the dialog 3. move (B) into "workspace", discard the move in the dialog Current behavior: * (A) is
Original PR description
There was an issue when canceling the move of an article from one section to another: a previous move which was not canceled could be undone when it should not have been. Impacted versions: * 15.4+…
There was an issue when canceling the move of an article from one section to
another: a previous move which was not canceled could be undone when it should
not have been.
Impacted versions:
* 15.4+
Steps to reproduce:
1. Have one article (A) in the "workspace" section and one article (B) in the
"private" section
2. move (A) into "private", validate the move in the dialog
3. move (B) into "workspace", discard the move in the dialog
Current behavior:
* (A) is displayed as if it is currently in "workspace" but it is in fact
still in "private"
Expected behavior:
* (A) and (B) should be displayed in the "private" section
This commit fixes the problem by manually replacing the article whose move was
discarded (B) at its previous position while triggering a "change" event instead
of a "cancel" event.
The bug is caused by an incorrect implementation of the "cancel" handler in
`jquery.mjs.nestedSortable` library. Since this library uses jQuery and it is
discontinued, we should consider to reimplement the feature internally in the
future.
This commit also synchronizes data-attr attributes (parent-id and section) with
the hidden value data('attr') from jQuery for consistency.
Task-2877766
Forward-Port-Of: odoo/odoo#93003Patching the window object is not robust and can lead to errors. In order to make patchUiSize more robust, patching of window have been replaced by a patch of the uiService. Forward-Port-Of: odoo/odoo#93347
Original PR description
Patching the window object is not robust and can lead to errors. In order to make patchUiSize more robust, patching of window have been replaced by a patch of the uiService. Forward-Port-Of: odoo/odoo#93347
Fine tuning of da8def8e410de68256ba4ab09ebf7a8b699355ac Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#93211
Original PR description
Fine tuning of da8def8e410de68256ba4ab09ebf7a8b699355ac Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#93211
Trigger up o-message-posted was inadvertently removed in https://github.com/odoo/odoo/pull/76718 task-2880739 Forward-Port-Of: odoo/odoo#93357 Forward-Port-Of: odoo/odoo#93282
Original PR description
Trigger up o-message-posted was inadvertently removed in https://github.com/odoo/odoo/pull/76718 task-2880739 Forward-Port-Of: odoo/odoo#93357 Forward-Port-Of: odoo/odoo#93282
no need to make rounding during computing qty_available STEPS (see the test): * create product with uom dozens * create product with uom units * create bom kit to convert one to another * set qty on hand to 1 for product dozens * check qty for product units opw-2849397 All ready issue is fixed in v14 https://github.com/odoo/odoo/pull/76145 Forward-Port-Of: odoo/odoo#92744
Original PR description
no need to make rounding during computing qty_available STEPS (see the test): * create product with uom dozens * create product with uom units * create bom kit to convert one to another * set qty on hand to 1 for product dozens * check qty for product units opw-2849397 All ready issue is fixed in v14 https://github.com/odoo/odoo/pull/76145 Forward-Port-Of: odoo/odoo#92744
Forward-Port-Of: odoo/odoo#93307
Original PR description
Forward-Port-Of: odoo/odoo#93307
currently there were no changes in the 'next occurrences' dates while clicking checkbox of the particular weekdays. so in this commit we have called onchange explicitly. task id-2823432 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#89846
Original PR description
currently there were no changes in the 'next occurrences' dates while clicking checkbox of the particular weekdays. so in this commit we have called onchange explicitly. task id-2823432 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#89846
STEPS: * switch to serbian language * start chat with a user who is out of office * refresh page BEFORE: Incorrect locale information provided AFTER: no errors Similar change for web module in v15: https://github.com/odoo/odoo/commit/1bb9cb89c8b5b5c55299afd3c53df14c3aea5ee7 opw-2859402 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at
Original PR description
STEPS: * switch to serbian language * start chat with a user who is out of office * refresh page BEFORE: Incorrect locale information provided AFTER: no errors Similar change for web module in v15: https://github.com/odoo/odoo/commit/1bb9cb89c8b5b5c55299afd3c53df14c3aea5ee7 opw-2859402 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#93200
Update to latest runbot state, at least for tests known to be deterministic. Notably mail tests are lower than before, probably due to odoo/odoo#73271 Forward-Port-Of: odoo/odoo#93398
Original PR description
Update to latest runbot state, at least for tests known to be deterministic. Notably mail tests are lower than before, probably due to odoo/odoo#73271 Forward-Port-Of: odoo/odoo#93398
Since #75862, the group "Upsell & Cross Sell" was shown in the "Sales" tab of the product views, even if empty (its content is only defined in modules sale_product_configurator & website_sale). This commit makes sure that the group is invisible while it has no content. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#93442 Forward-Port-Of: odoo/odoo#93339
Original PR description
Since #75862, the group "Upsell & Cross Sell" was shown in the "Sales" tab of the product views, even if empty (its content is only defined in modules sale_product_configurator & website_sale). This commit makes sure that the group is invisible while it has no content. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#93442 Forward-Port-Of: odoo/odoo#93339
Before this commit the feature to auto-reload on attachment changed only worked through composer or attachment box, now also works with "upload file" activity. Forward-Port-Of: odoo/odoo#93361 Forward-Port-Of: odoo/odoo#93288
Original PR description
Before this commit the feature to auto-reload on attachment changed only worked through composer or attachment box, now also works with "upload file" activity. Forward-Port-Of: odoo/odoo#93361 Forward-Port-Of: odoo/odoo#93288
Since #79093, the onchange updating taxes according to fpos was replaced by a compute, but the dependency on the order fpos was not kept to avoid full recomputation of taxes (& potentially other things) when SO fields are modified. Nevertheless, it makes sense in some flows to update the fpos after creation of SOlines, and to want the taxes to be updated accordingly. To provide this ability, a new button is added, following the existing logic to update the prices & discounts when the
Original PR description
Since #79093, the onchange updating taxes according to fpos was replaced by a compute, but the dependency on the order fpos was not kept to avoid full recomputation of taxes (& potentially other things) when SO fields are modified. Nevertheless, it makes sense in some flows to update the fpos after creation of SOlines, and to want the taxes to be updated accordingly. To provide this ability, a new button is added, following the existing logic to update the prices & discounts when the pricelist is changed. Task - 2865882 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#93420 Forward-Port-Of: odoo/odoo#92365
Inner `afterNextRender` could potentially resolve/reject after the test has already ended due to missing await (arrow function with bracket is sync). This will prevent tests from overlapping each other. Forward-Port-Of: odoo/odoo#93365 Forward-Port-Of: odoo/odoo#93345
Original PR description
Inner `afterNextRender` could potentially resolve/reject after the test has already ended due to missing await (arrow function with bracket is sync). This will prevent tests from overlapping each other. Forward-Port-Of: odoo/odoo#93365 Forward-Port-Of: odoo/odoo#93345
After the refactor performed on 3fea5b213 to start using OWL, a lot of ARIA attributes were lost. ARIA attributes are required to ensure good compatibility with asistive technologies and keyboard users. This commit reintroduces such attributes, which include: - `aria-label`: used for elements with title but no text - `role`: mainly used for elements that behaves as buttons or links - `aria-expanded`: used on buttons that toggle menus or content, e.g. button to open attachments or f
Original PR description
After the refactor performed on 3fea5b213 to start using OWL, a lot of ARIA attributes were lost. ARIA attributes are required to ensure good compatibility with asistive technologies and keyboard users. This commit reintroduces such attributes, which include: - `aria-label`: used for elements with title but no text - `role`: mainly used for elements that behaves as buttons or links - `aria-expanded`: used on buttons that toggle menus or content, e.g. button to open attachments or followers - And another ones like `aria-pressed`, `tabindex`, etc -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#93299 Forward-Port-Of: odoo/odoo#86324
Create a standard tax that is included in the product price. Add that tax to a product and the down payment product. Create a sales order (i.e. 1 line, 115$ total, 15% tax incl). Create a percentage down payment invoice, i.e. 50%. The downpayment amount will be 50% of the untaxed amount, i.e. 100$ @ 50% = 50$ with tax already included, so actually lower than 50% Forward-Port-Of: https://github.com/odoo/odoo/pull/65275 opw-2858506 Forward-Port-Of: odoo/odoo#93408
Original PR description
Create a standard tax that is included in the product price. Add that tax to a product and the down payment product. Create a sales order (i.e. 1 line, 115$ total, 15% tax incl). Create a percentage down payment invoice, i.e. 50%. The downpayment amount will be 50% of the untaxed amount, i.e. 100$ @ 50% = 50$ with tax already included, so actually lower than 50% Forward-Port-Of: https://github.com/odoo/odoo/pull/65275 opw-2858506 Forward-Port-Of: odoo/odoo#93408
Whilst introducing the fix to allow for some rudimentary processing of supplementary units f1d4b31 , in formatting a section of the p/st codes was not included. This commit adds them in the place where they belong in the dictionary. task-id: 2853030 Forward-Port-Of: odoo/enterprise#28292
Original PR description
Whilst introducing the fix to allow for some rudimentary processing of supplementary units f1d4b31 , in formatting a section of the p/st codes was not included. This commit adds them in the place where they belong in the dictionary. task-id: 2853030 Forward-Port-Of: odoo/enterprise#28292
Update to latest runbot state, at least for tests known to be deterministic. Forward-Port-Of: odoo/enterprise#28294
Original PR description
Update to latest runbot state, at least for tests known to be deterministic. Forward-Port-Of: odoo/enterprise#28294
In certain conditions, the pivot data were not correctly fetched from the `pivotModel`when loading the `PivotDialog`to re-insert a cell. Specifically, the issue arises when at least one groupBy is a relational field which is not set for some records. (e.g. user_id not set on res.partner records). The problem was that when parsing the groupBy value in `parsePivotFormulaFieldValue`, the code only worked if the input groupValue was always a string. This commit ensures that `parsePivot
Original PR description
In certain conditions, the pivot data were not correctly fetched from the `pivotModel`when loading the `PivotDialog`to re-insert a cell. Specifically, the issue arises when at least one groupBy is a relational field which is not set for some records. (e.g. user_id not set on res.partner records). The problem was that when parsing the groupBy value in `parsePivotFormulaFieldValue`, the code only worked if the input groupValue was always a string. This commit ensures that `parsePivotFormulaFieldValue` properly handles all types of inputs, therefore fixing the aforementionned symptom. Task 2870790 Forward-Port-Of: odoo/enterprise#28033
…d on the bank reco widget Forward-Port-Of: odoo/enterprise#28252
Original PR description
…d on the bank reco widget Forward-Port-Of: odoo/enterprise#28252