Thursday, June 16, 2022
12 changes · master
Enhancements to existing features
The spreadsheet selection window now waits briefly while users type before refreshing search results. This reduces unnecessary loading and makes finding spreadsheets feel smoother, especially when typing quickly.
Original PR description
With this commit, the call to fetch the spreadsheets is debounce when the user is typing on the search bar. Task-id 2884670
The expense screen no longer shows the option to report an expense on an employee's next payslip when the expense was paid by the company. This reduces confusion and keeps payroll-related actions visible only when they are relevant.
Original PR description
Purpose ======= Reduce UI clutter/nonsensical options in expense: reporting an expense in the employee's next payslip should only be suggested if the expense sheet was paid by the employee. Specification ============= Have the button for the action `action_report_in_next_payslip` in hr_payroll_expense invisible for this domain (addition: when payment mode is 'company_account', the button should be invisible) TaskID: 2859389
HR responsible users are now notified only after the applicant or employee has signed their contract, rather than when the contract is first created. This reduces premature follow-up tasks and helps HR focus on contracts that are ready for their action.
Original PR description
Currently, once a contract is created, it notifies both applicant/employee and the HR responsible person via an activity. The HR responsible person should only be notified of a contract signature once the employee/applicant has signed his contract. task-2677246
Resolved issues and error corrections
Subscription portal links no longer repeat the access token when users navigate back and forth. This keeps portal URLs clean and prevents automated checks or users from hitting errors caused by excessively long repeated parameters.
Original PR description
Go to the subscription portal (/my/subscription) Access the portal view of a given sub (/my/subscription/ID?access_token=...) Go back to the subscription portal (the token is kept in the url bc of the keep_query in portal_breadcrumbs) Hover/click on the link to the portal view of a specific sub, you'll see the token twice in the url GET params. This commit removes the keep_query for the links on the subscription portal homepage, following the existing behavior in sale, purchase, ... This avoids a crash when the runbot crawl test reaches a python recursion error after reaching an url where the access token is present more than 30 times (probably even more).
Code cleanup and technical improvements
The Documents Spreadsheet area now counts available spreadsheets using a more efficient database method. This reduces unnecessary data loading and network traffic, which can improve responsiveness when many spreadsheets exist.
Original PR description
`search_count` is more efficient since it's done at SQL level (`SELECT COUNT (*) ...`) `search_read` will fetch in memory every row matching the domain (and over the network here)
Miscellaneous changes
currently there was traceback error in map view on groupby start date. so it is fixed after this commit. task id-2823432 Forward-Port-Of: odoo/enterprise#28435 Forward-Port-Of: odoo/enterprise#26664
Original PR description
currently there was traceback error in map view on groupby start date. so it is fixed after this commit. task id-2823432 Forward-Port-Of: odoo/enterprise#28435 Forward-Port-Of: odoo/enterprise#26664
The spreadsheet insertion dialog now clearly shows which spreadsheet is currently selected. This removes confusion when users choose a spreadsheet to insert, helping them confirm the right item before proceeding.
Original PR description
Before this commit, a selected spreadsheet in the inserting dialog was not identifiable. task-id 2884665
and add them into odoo-master project Forward-Port-Of: odoo/enterprise#28389 Forward-Port-Of: odoo/enterprise#28365
Original PR description
and add them into odoo-master project Forward-Port-Of: odoo/enterprise#28389 Forward-Port-Of: odoo/enterprise#28365
This PR adds tests to ensure that the basic project features, subtasks and task dependencies, behave as intended on fsm projects. Those features should be disabled by default on new and existing projects when enabling them globally, but should also get disabled when disabling them globally, should they have been enabled on fsm projects in the meantime. Related: https://github.com/odoo/odoo/pull/92856 Task-2871448 Forward-Port-Of: odoo/enterprise#28447 Forward-Port-Of: odoo/enterprise#2
Original PR description
This PR adds tests to ensure that the basic project features, subtasks and task dependencies, behave as intended on fsm projects. Those features should be disabled by default on new and existing projects when enabling them globally, but should also get disabled when disabling them globally, should they have been enabled on fsm projects in the meantime. Related: https://github.com/odoo/odoo/pull/92856 Task-2871448 Forward-Port-Of: odoo/enterprise#28447 Forward-Port-Of: odoo/enterprise#28036
Steps to reproduce: - Install accounting with german localization - Activate multi-currency in settings - Create an invoice with a currency different than EUR - Add multiple lines of products on the invoice - Go to reporting>general ledger and download datev ZIP Current behavior: The value in the non EUR currency only corresponds to the first line of the invoice. Expected behavior: The value in the non EUR currency corresponds to the total of the invoice. Explanation: In the f
Original PR description
Steps to reproduce: - Install accounting with german localization - Activate multi-currency in settings - Create an invoice with a currency different than EUR - Add multiple lines of products on the…
Steps to reproduce: - Install accounting with german localization - Activate multi-currency in settings - Create an invoice with a currency different than EUR - Add multiple lines of products on the invoice - Go to reporting>general ledger and download datev ZIP Current behavior: The value in the non EUR currency only corresponds to the first line of the invoice. Expected behavior: The value in the non EUR currency corresponds to the total of the invoice. Explanation: In the fix commit that added the non EUR currency to the datev report (134978b16fcd62c8da72767830b3323846f86521), a mistake was made and the code was misunderstood so that only the first line price_total of the invoice was added to the report. We also add a check on the number of currencies used by move so that the fields 3,4,5 are only filled when there is only one currency for every lines and that currency is different than the company currency. opw-2842120 Forward-Port-Of: odoo/enterprise#28283
The feature was lost during refactoring to OWL. Refactoring: https://github.com/odoo/enterprise/commit/c0151bce3c60c69e7cadeb719a81c4a702b71c34 V14 implementation: https://github.com/odoo/enterprise/blob/88aa448f2b2587faef73f6ce59dd4e996e995056/stock_barcode/static/src/js/client_action/picking_client_action.js#L68-L72 https://github.com/odoo/enterprise/blob/88aa448f2b2587faef73f6ce59dd4e996e995056/stock_barcode/static/src/js/client_action/picking_client_action.js#L349-L376 opw-28
Original PR description
The feature was lost during refactoring to OWL. Refactoring: https://github.com/odoo/enterprise/commit/c0151bce3c60c69e7cadeb719a81c4a702b71c34 V14 implementation: https://github.com/odoo/enterprise/blob/88aa448f2b2587faef73f6ce59dd4e996e995056/stock_barcode/static/src/js/client_action/picking_client_action.js#L68-L72 https://github.com/odoo/enterprise/blob/88aa448f2b2587faef73f6ce59dd4e996e995056/stock_barcode/static/src/js/client_action/picking_client_action.js#L349-L376 opw-2835171 Forward-Port-Of: odoo/enterprise#28323 Forward-Port-Of: odoo/enterprise#28251
When cancelling a SM, it also cancels all quality checks of the associated picking. This is not accurate enough. To reproduce the issue: 1. In Settings, enable "Multi-Step Routes" 2. Edit the warehouse: - Incoming Shipments: 2-steps 3. Create two storable products P1 and P2 4. For each product, add a quality control point: - Operation: Internal Transfer 5. Process a receipt (to the input location) with: - 1 x P1 - 1 x P2 6. Process a second receipt (still to the inp
Original PR description
When cancelling a SM, it also cancels all quality checks of the associated picking. This is not accurate enough. To reproduce the issue: 1. In Settings, enable "Multi-Step Routes" 2. Edit the…
When cancelling a SM, it also cancels all quality checks of the
associated picking. This is not accurate enough.
To reproduce the issue:
1. In Settings, enable "Multi-Step Routes"
2. Edit the warehouse:
- Incoming Shipments: 2-steps
3. Create two storable products P1 and P2
4. For each product, add a quality control point:
- Operation: Internal Transfer
5. Process a receipt (to the input location) with:
- 1 x P1
- 1 x P2
6. Process a second receipt (still to the input location) with:
- 1 x P1
7. Open the internal transfer for the received produits
8. Open the quality checks
Error: There is only one quality check (for P1), the QC of P2 is missing
When processing the second receipt, the module creates an internal
transfer to move the received P1 from input to stock location. However,
because there is already a similar SM (from the first receipt), both SM
are merged and the second one is cancelled:
https://github.com/odoo/odoo/blob/c08ebc3a24f2326bfdf5a98b5533a501ade57c04/addons/stock/models/stock_move.py#L768-L772
As a result, in `quality_control`, we delete all quality checks (then a
new one will be created for the merged SM)
OPW-2837078
Forward-Port-Of: odoo/enterprise#28384
Forward-Port-Of: odoo/enterprise#27807