Tuesday, July 5, 2022
9 changes · master
Resolved issues and error corrections
Kanban views with progress bars now handle records that have an empty progress value without crashing. This keeps dashboards and workflow boards accessible when some data is missing or uncategorized.
This fixes a display issue in kanban views where setup information placed outside a card could be ignored. Users now see the correct buttons and status-dependent actions, such as installed apps no longer incorrectly showing an Install button.
Original PR description
*base, event, hr_holidays Before this commit, `<t t-set/>` nodes declared outside the main div of a kanban card where ignored by the kanban compiler. This commit fixes that issue. To do so, we refactor a bit the way the compiler and KanbanRecord handle multiple root cards (typically, several roots with a t-if/t-elif/t-else, s.t. there's a unique rendered root), by removing the faulty logic from the compiler that identified card root nodes (and filtered out t-set nodes), and introducing a div for the KanbanRecord component on which we can set classNames, attributes and handlers. The issue could be observed on the Apps kanban view, as it displayed the "Install" button, whether the app was already installed or not.
This fix improves how certain accounting screens adapt to different screen sizes by removing unnecessary layout wrappers. Users should see better responsiveness in tax and partner accounting views, especially in the web client.
Original PR description
Both the CE and EE web clients don't support proper responsivity when a subtree view is inside a `<group>`. By removing them (they were unnecessary anyway) we recover proper responsivity in these views. @moduon MT-688 OPW-2843895 See (video is from v15, but the same problem exists in v14 and v13): https://user-images.githubusercontent.com/973709/167584174-e2405df7-8a60-4be6-ab81-b722ec82bb78.mp4 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix removes obsolete website page-management styling from public search results pages. Search result tables now better follow the site's theme instead of using outdated colors and spacing, improving visual consistency for visitors.
Original PR description
Commit [1] made a mistake of copy/pasting the "list_website_pages" ID in two views related to the "search in everything" and "search in pages" views (used when checking all results after a search…
Commit [1] made a mistake of copy/pasting the "list_website_pages" ID in
two views related to the "search in everything" and "search in pages"
views (used when checking all results after a search using the "search"
snippet that you can configure to search in everything or in pages).
At the time, that ID induced some CSS rules and JS related to the page
manager (not made for visitors).
- For the "search in everything" page, both the CSS rules and JS had no
effect (except instantiating an useless widget in JS).
- For the "search in pages" page, the JS had no effect (except the same
instantiation of an useless widget) but the CSS had an impact on the
`<table>` used to display the results:
- The header used an hardcoded odoo-purple background color.
- The table paddings were not the ones defined by the theme.
Of course, in custos, more of the CSS could have had an impact (for
example some icons would use bootstrap blue info color by default for
no apparent reason).
Since [2], the page manager was removed (converted into a backend view)
so the CSS and JS rules actually became totally useless. The JS was
removed with [2] but the CSS was kept thinking it was necessary for the
"search in everything" and "search in pages" pages.
This commit removes the useless CSS and the useless ID in the two views.
It also modifies the "search in pages" layout a bit.
A fix could be made in stable later on to at least remove the hardcoded
odoo-purple background color in the "search in pages" page. The rest
should stay as per-stable policy.
[1]: https://github.com/odoo/odoo/commit/7559626c54e34b41e1549e28276a650accec6986
[2]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3bFixed an issue in the Mail app that could cause an error when users clicked reply on a message. This improves reliability for everyday communication and adds test coverage to help prevent the problem from returning.
Original PR description
Fix bug introduced in https://github.com/odoo/odoo/pull/94948.
This fixes an internal test issue that occurred when Odoo was run with only the base setup and a settings form contained no fields. The change avoids an unnecessary read step in that case, helping keep automated validation stable without affecting everyday users.
Original PR description
Since #91909, the settings form view is tested with different levels of access rights, post install. But when the test is run with only the base module, it crashes because the settings view specified in base is empty, without any field. On save, the test form reads the view fields, but read fallbacks on all fields if no field is specified, and it breaks when we try to compare the read results to the fields requested (empty). This commit skips the read when no fields is present in the view. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
New products will now start with a Sales Price of 0.00 instead of 1.00. This prevents unintended default pricing and lets users set the correct price when needed.
Original PR description
Ref #49822 Description of the issue/feature this PR addresses: product `Sales Price` had a default of 1.0 Current behavior before PR: product `Sales Price` had a default of 1.0 Desired behavior after PR is merged: Sales Price should be set to 0.0 by default, a user can change this value if necessary -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects several visual and usability problems in Odoo’s web interface, especially around Kanban quick creation, field sizing, translation buttons, and legacy UTM Kanban styling. It also prevents an error when navigating from an empty Kanban view, making everyday workflows smoother and more reliable.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update reduces internal data inconsistencies and unnecessary processing when records are read, improving stability across several business apps. It also adjusts related tests and fixes edge cases that could cause errors or unexpected empty values in areas like payroll, helpdesk, planning, assets, reporting, manufacturing, and field service.
Original PR description
Companion of https://github.com/odoo/odoo/pull/66938