Sunday, July 31, 2022
2 changes · master
Miscellaneous changes
Steps to reproduce: 1- create a company in saudi arabia 2- install l10n_sa and l10n_gcc_invoice 3- enable LN/SN on invoice from settings 4- configure a product with lot number 5- make a SO with that product 6- create an invoice and post it 7- print the invoice 8- Lot number information is missing on the invoice Bug: the implementation in https://github.com/odoo/odoo/blob/15.0/addons/l10n_gcc_invoice/views/report_invoice.xml#L11-L16 is ignoring the inheritance in https://github
Original PR description
Steps to reproduce: 1- create a company in saudi arabia 2- install l10n_sa and l10n_gcc_invoice 3- enable LN/SN on invoice from settings 4- configure a product with lot number 5- make a SO with that…
Steps to reproduce: 1- create a company in saudi arabia 2- install l10n_sa and l10n_gcc_invoice 3- enable LN/SN on invoice from settings 4- configure a product with lot number 5- make a SO with that product 6- create an invoice and post it 7- print the invoice 8- Lot number information is missing on the invoice Bug: the implementation in https://github.com/odoo/odoo/blob/15.0/addons/l10n_gcc_invoice/views/report_invoice.xml#L11-L16 is ignoring the inheritance in https://github.com/odoo/odoo/blob/15.0/addons/stock_account/views/report_invoice.xml so any view inheriting "account.report_invoice_document" will not be called. For stable, it can be solved with a bridge module. For Master or for future versions, I think the implementation in https://github.com/odoo/odoo/blob/15.0/addons/l10n_gcc_invoice/views/report_invoice.xml#L18 should be inheriting "account_report_invoice_document" instead of overriding it. this will help eliminate the need for such bridge modules in the future and reduce redundancy Fix: Create a bridge module between `l10n_gcc_invoice` and `stock_account` OPW-2893130 Forward-Port-Of: odoo/odoo#95579
Description of the issue/feature this PR addresses: When tax is configured to be "Include in Price", the e-faktur document violates official regulation. Prices columns in e-faktur has to be declared without tax inclusion. Current code does not differentiate behaviour when "Include in Price" configuration in tax is True or False. Current behavior before PR: When tax is configured to be "Include in Price", the prices columns (unit price and the total) includes tax, which violated the e-faktur
Original PR description
Description of the issue/feature this PR addresses: When tax is configured to be "Include in Price", the e-faktur document violates official regulation. Prices columns in e-faktur has to be declared…
Description of the issue/feature this PR addresses: When tax is configured to be "Include in Price", the e-faktur document violates official regulation. Prices columns in e-faktur has to be declared without tax inclusion. Current code does not differentiate behaviour when "Include in Price" configuration in tax is True or False. Current behavior before PR: When tax is configured to be "Include in Price", the prices columns (unit price and the total) includes tax, which violated the e-faktur documentation rule. Consequently, the calculation for discount will be flawed since the current discount amount computation is (price_unit * quantity) - price_subtotal. Desired behavior after PR is merged: Price columns (unit price and total) should no longer include tax, and will result to correct discount amount calculation. Task: 2889400 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#96525 Forward-Port-Of: odoo/odoo#94114