Daily updates from Odoo
Thursday, August 25, 2022
13 changes · master
Enhancements to existing features
Users who open a signing link for a deleted signature request now see a clearer and more polished error page. This reduces confusion and helps people understand why the document is no longer available.
Original PR description
Improve the wording and visual of the page on linked to deleted sign request task-id 2928673
Resolved issues and error corrections
The Belgian payroll accounting test module now cleans up its setup data properly when it is uninstalled. This prevents reinstall failures and helps keep test environments stable.
Original PR description
Reinstalling the `test_l10n_be_hr_payroll_account` fails when calling the post init hook. The failure happens because of a constraint violation caused by data left behind after the first uninstall. As a result the registry cannot be loaded. The problem is resolved by assigning xml ids to the population data, so that the data is properly removed when uninstalling the module.
Closing a subscription could send the customer rating email twice when the closed stage had a rating template. This fix ensures the email is sent only once, avoiding duplicate customer communications.
Original PR description
Since bbee402d3d98f62f459cfa5c54465ae9600fe09d , if the closed stage contains a rating email, the email is sent twice. This is because we manually set as closed the subscription, and so the stage is written 2 times. Task-2207626
The lightbulb icon in Helpdesk settings now appears inline with its related text. This small visual fix makes the settings page look cleaner and easier to read.
Original PR description
This commit fixes the style of the lightbulb icon present in the settings. After this commit, the icon is now displayed inline with the text.
The barcode operations screen now shows its action buttons with the correct active styling. This avoids confusion for warehouse users by making available actions look clickable as intended.
Original PR description
In barcode/operations the buttons looks like disabled, because of missing type and name. https://github.com/odoo/odoo/blob/b2a0a1c7d3ba2c71502e272ff12e2c74fb95ff91/addons/web/static/src/views/view_button/view_button.js#L74-L77 Since: https://github.com/odoo/enterprise/pull/27747/files#diff-afa348e5fe6d5c58c2708f41069a1b7c3733c2c24c3dd540ab92a560d79159f8R75
The spreadsheet module now correctly declares a required dependency used during setup. This prevents isolated spreadsheet builds from failing and helps keep deployments more reliable.
Original PR description
The spreadsheet module depends on bus, but don't mark it as a dependency. As a result, single build of the spreadsheet module fails, because the `ir.websocket` module, which is defined on the bus module, can't be resolved. This commit fixes this issue by adding the required dependency in the manifest. https://runbot.odoo.com/runbot/build/18667107
Code cleanup and technical improvements
This update simplifies the styling behind timesheet and timer screens as part of a broader visual and code cleanup. Users should see the same functionality with a more maintainable interface foundation, helping future improvements be delivered more efficiently.
Original PR description
This commit simplifies the SCSS of timesheet task-2789206
This update reorganizes mail and rating-related files across multiple Odoo apps so each business object is easier to find and maintain. It is mostly internal cleanup, with a small correction to scheduled task methods to better match how they are used.
Original PR description
[MOV] various Move code, views and data of mail / rating models into their own files. Purpose is to have one file / model, easier when searching for inherited parts of the code and see at a glance various usage of those models. [FIX] in ir_cron Trigger methods are defined as api.model but actually use self. Those are therefore not model. Smart. LINKS Spotted during Task-2207626 (Rating: Delay rating notification to ease feedback)
This update renames an internal message list component to use a clearer, shorter name. It helps keep the messaging code easier to maintain without changing how users interact with the product.
Original PR description
part of task-2918956
Miscellaneous changes
A big issue with the "create bill" action from document is that the partner is not synced unless everything is configured properly in the settings as far as documents > Accounting goes and the journal/main attachment is changed. However there is a clear issue with partners not being synchronized on the documents. Assume the following flow: - Bill is uploaded to the documents app - Create Bill action is used to create the account.move - Information on the bill is added partner, date
Original PR description
A big issue with the "create bill" action from document is that the partner is not synced unless everything is configured properly in the settings as far as documents > Accounting goes and the journal/main attachment is changed. However there is a clear issue with partners not being synchronized on the documents. Assume the following flow: - Bill is uploaded to the documents app - Create Bill action is used to create the account.move - Information on the bill is added partner, date, etc The document will now also follow any change on the partner. TaskId-2751063 Forward-Port-Of: odoo/enterprise#30659
Steps to reproduce: - Add in an auto fill partner field of type float, or monetary in the sign app and pull that onto a document template. Current behavior: The auto-fill does not take into consideration the field precision Expected behavior: The auto-fill takes into consideration the field precision Example for a latitude variable with 5 digits of precision: current value shown on the document 50.503 expected value shown on the document 50.50300 Solution: We use the conv
Original PR description
Steps to reproduce: - Add in an auto fill partner field of type float, or monetary in the sign app and pull that onto a document template. Current behavior: The auto-fill does not take into consideration the field precision Expected behavior: The auto-fill takes into consideration the field precision Example for a latitude variable with 5 digits of precision: current value shown on the document 50.503 expected value shown on the document 50.50300 Solution: We use the convert_to_column function to get the right representation even if it was not meant for this use it returns the string of a float or a monetary field with re right precision. To our knowledge this is the only function that does that. Depending of the field type it will get the digits precision for the float and the rounding precision for the monetary field to give the right format. opw-2920379 Forward-Port-Of: odoo/enterprise#30644 Forward-Port-Of: odoo/enterprise#29854
Purpose: ======== Fix unfolded articles caching: previously, articles where added or removed from the list of unfodled articles in the cache only when clicking on the caret that folds or unfolds an article. Therefore, when a child article was created or when an article was moved under a parent article, these new parent articles were not added to the cache and were folded when selecting another article. Article ids are now also added/removed from the list of unfolded articles when an a
Original PR description
Purpose: ======== Fix unfolded articles caching: previously, articles where added or removed from the list of unfodled articles in the cache only when clicking on the caret that folds or unfolds an…
Purpose: ======== Fix unfolded articles caching: previously, articles where added or removed from the list of unfodled articles in the cache only when clicking on the caret that folds or unfolds an article. Therefore, when a child article was created or when an article was moved under a parent article, these new parent articles were not added to the cache and were folded when selecting another article. Article ids are now also added/removed from the list of unfolded articles when an article has been (un)folded without clicking on a caret. Fix moving articles under folded articles: previously, moving an article under a folded article was either not possible if the article had been unfolded and refolded before, or it overwrote the other existing children if it had not been unfolded before. The former issue arises because when one folds an article, the "ul" containing the children articles was simply hidden, which is not compatible with NestedSortable. Therefore, instead of only hiding the "ul", it is moved to one of its siblings, so that one can move it back when one unfolds the parent again, or when an article is moved under it. This trick also allows to always place the moved article as the last child of it's parent, which was not the case with other approaches tried. To solve the latter issue, an RPC is now done to fetch the other children of the parent when an article is moved under this parent and when the children have not been fetched yet. Fix ordering of articles fetched through a RPC: previously, the order of the articles fetched when unfolding an article was not the same as the one when these articles were loaded on page load, causing articles to change position when unfolding then selecting an article. The order is now the same in both cases. Scroll to articles in the sidebar when created: when one creates an article, it spawns at the bottom of its section/group of children in the sidebar. Now, the sideview is scrolled in order to have the handle of the newly created article in the view. Task-2858704 Forward-Port-Of: odoo/enterprise#29282
This PR fixes the move reversal wizard, because it was showing the reference doc code for any kind of account entry and not only for invoices/refunds. Also fixes the required field "reason" in the cross-references, since recent change truncating this to its maximum allowed length, (90) caused an exception if the field was false. [FIX] l10n_cl_edi: in reversal, moves hide the reference code if a normal account entry (not invoice or refund) [FIX] l10n_cl_edi: define the reason as required s
Original PR description
This PR fixes the move reversal wizard, because it was showing the reference doc code for any kind of account entry and not only for invoices/refunds.
Also fixes the required field "reason" in the cross-references, since recent change truncating this to its maximum allowed length, (90) caused an exception if the field was false.
[FIX] l10n_cl_edi: in reversal, moves hide the reference code if a normal account entry (not invoice or refund)
[FIX] l10n_cl_edi: define the reason as required since it is truncated to 90 chars
and if this field is not completed, there will be an exception
Forward-Port-Of: odoo/enterprise#29826