Friday, September 2, 2022
15 changes · master
Resolved issues and error corrections
This fix prevents rating-related message processing from failing when a notification is not linked to a specific record. It filters out incomplete messages so users avoid unexpected errors during communication workflows.
Original PR description
As message_notify can be done on empty recordset, message.res_id and message.model can be Falsy. During filtering on rating messages, we need to prevent the code to crash when filtering on those two properties and filter out messages that are not linked to any record. Task-2850521
The settings search now avoids showing empty section headings or app headers when a match only exists in hidden settings. It also improves search highlighting for setting descriptions that include formatted content, making results clearer for users.
Original PR description
When searching a text of a hidden field (for example, "gate"), the setting itself will not be shown, but the group title, and the app Search Header will be shown. This issue arise because, we use an if condition with all the label of all the fields (hidden or not) in the group (or app) to decide if the group title or the app header will be showed. Now, we modify this to hide (d-none) the group title or the app header if there is not a settings below them.
Downloading call logs from online calls no longer triggers an error. This restores a small but important Mail collaboration action so users can access call records reliably.
Original PR description
Before this commit, since https://github.com/odoo/odoo/pull/96954 , the `CallActionListView` had its `channel` field renamed into `thread`. A reference to this old field name was missed which caused the traceback, this commit fixes this issue by using the right field name.
This fix ensures sale order discounts can be calculated safely even when a product's unit of measure is not yet filled in. It prevents temporary setup timing issues from causing incorrect behavior while the order line continues to update normally once the unit is set.
Original PR description
`_compute_discount` from subscription add dependencies that triggered the compute of the discount before the `product_uom` was set in a sale order line, once the uom is set, the `_compute_discount` will be triggered again. Setting a fallback on the product uom will solve the bug before the source of the problem can be fixed. task-2960768 See also: - https://github.com/odoo/enterprise/pull/30721
This fixes a confusing error that could appear after a hosted database goes to sleep while a browser tab remains open. Users now receive a clearer message instead of a technical traceback when the system status request gets an unexpected server response.
Original PR description
[aju] not sure how to reproduce, but I get this traceback when I leave the helpdesk.ticket or project.task kanban views open for a long time: https://pastebin.com/rs91XEsx
--> [DAM] seems related to a bad response in const { error: responseError, result: responseResult } = JSON.parse(request.response); (rpc_service line 67)
nginx responds with an error 404 to the im_status request when the db is no longer available (sleeping) --> the request response
is not JSON parsable as expected by the rpc service...This fix restores the previous text color used for list view table headers after a Bootstrap upgrade changed it unintentionally. It keeps list titles visually consistent with earlier Odoo versions and improves readability without changing functionality.
Original PR description
Before in BS4, the table used the `$table-head-color` SCSS variable to
color the header of table. This variable doesn't exist anymore on BS5.
In the commit of the BS5's merge, we have replaced the old value by
a value calculated with the color contrast in the case of the list view
it wasn't the right fix, so in this commit we restore the original value
like it was before the merge of BS5.
Note:
In BS4 branch the result is `#212529`:
```scss
$o-gray-900: #212529 !default;
$o-main-headings-color: $o-gray-900 !default;
$table-head-color: $o-main-headings-color !default;
.o_list_view .o_list_table thead {
color: $table-head-color;
}
```
In BS5 branch the result is `#00000`:
```scss
.o_list_view .o_list_table thead {
color: color-contrast(opaque($body-bg, $light));
}
```
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update corrects an accounting test so it checks the current tax template fields. It helps ensure accounting templates are validated reliably across environments, reducing the risk of missed configuration issues.
Original PR description
plus_report_line_ids and minus_report_line_ids have now been replaced by plus_report_expression_ids and minus_report_expression_ids on tax templates. The test was failing locally but not on runbot, because it was missing the post_install tag.
This fixes the color used for list view table headers so they match the appearance users had before the Bootstrap 5 migration. The change keeps the interface visually consistent and removes an obsolete styling line left over from the migration.
Original PR description
Before in BS4, the table used the `$table-head-color` SCSS variable to
color the header of table. This variable doesn't exist anymore on BS5.
In the commit of the BS5's merge, we have replaced the old value by
a value calculated with the color contrast in the case of the list view
it wasn't the right fix, so in community commit we restore the original
value like it was before the merge of BS5.
In this commit, we remove the unused line that was left in
the migration of BS5.
Note:
In BS4 branch the result is `#212529`:
```scss
$o-gray-900: #212529 !default;
$o-main-headings-color: $o-gray-900 !default;
$table-head-color: $o-main-headings-color !default;
.o_list_view .o_list_table thead {
color: $table-head-color;
}
```
In BS5 branch the result is `#00000`:
```scss
.o_list_view .o_list_table thead {
color: color-contrast(opaque($body-bg, $light));
}
```This fix updates internal tests so they keep working after a backend optimization changed when data is refreshed. It helps maintain reliability for Helpdesk and Field Service Sales without changing customer-facing features.
Original PR description
…ed_triggers`. `_modified_triggers` read and flush much less than before. Then some test crash because of that, fix it. https://github.com/odoo/odoo/pull/99274
Account reports now apply the correct number styling to all numerical values. This helps keep financial report figures visually consistent and easier to scan for users.
Original PR description
Sometimes the numerical values on an account report will not have the number class. This insures that the number class is properly applied to all numerical values. Signed-off-by: Ruben Gomes <rugo@odoo.com>
The Helpdesk ticket portal layout was adjusted to use page layout components more consistently. This helps keep ticket pages visually aligned and avoids minor display issues for portal users.
Original PR description
In this commit, we replace wrong usage of col without row, also adapt some gutter instead of padding and replace the old btn-block.
This fixes an issue in the sales subscription flow where the wrong unit of measure could be used on order lines. It helps ensure quantities and pricing are calculated consistently for recurring sales.
Original PR description
task-2960768 see also: - https://github.com/odoo/odoo/pull/98780
This fixes how Knowledge pages are accessed through web requests, helping ensure the right user context is used. It reduces the chance of access or permission issues when people open Knowledge content.
Removing someone from a Knowledge article's sharing panel now works without triggering an error. This prevents confusion and keeps collaboration management smooth when updating article access.
Original PR description
When the user removes a member from the share panel, the user will get a missing record error. The error occurs in the `article_remove_member` method: In that method, we fetch the partner from the member after deleting it. When we try to fetch the partner, the model raises an error as the member partner no longer exists. To fix the issue, we will backup a reference of the partner associated to the member we want to delete before deleting it. We will then use that reference in the following instructions. task-2968657
The Knowledge share panel no longer shows article links that the current user cannot open. This prevents users from clicking links that would lead to an access error and makes permission inheritance clearer.
Original PR description
In Knowledge, an article can inherit its permissions and its members from one of its parents. When it happens, the share panel includes a link to the article giving new permissions or members. When the user does not have access to the article, the user will get an access error by clicking on the provided link. To avoid that, we will no longer display a link in the share panel if the user does not have access to the target article. task-2968511